Page MenuHomeFreeBSD

kibab (Ilya Bakulin)
User

Projects

User Details

User Since
Sep 26 2014, 6:46 AM (233 w, 4 d)

Recent Activity

Jun 21 2018

kibab created D15955: Discover cards on boot.
Jun 21 2018, 6:05 PM
kibab committed rS335476: Add MMCCAM support to AllWinner MMC driver.
Add MMCCAM support to AllWinner MMC driver
Jun 21 2018, 11:49 AM
kibab closed D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 21 2018, 11:49 AM

Jun 20 2018

kibab added inline comments to D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 20 2018, 8:40 AM

Jun 19 2018

kibab updated the summary of D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 19 2018, 9:15 PM
kibab updated the test plan for D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 19 2018, 9:13 PM
kibab added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.
In D15891#336175, @manu wrote:

This looks okay for me except one comment.
But due to the fact that I/We had a lot of problems with different revision of the hardware IP let me test on different SoC before commiting.
Also I won't set this review as accepted as I don't know anything about CAM.

Jun 19 2018, 9:09 PM
kibab created D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Jun 19 2018, 8:43 PM
kibab committed rS335384: Fix setting RCA for MMC cards.
Fix setting RCA for MMC cards
Jun 19 2018, 8:02 PM
kibab closed D13063: Fix setting RCA for MMC cards.
Jun 19 2018, 8:02 PM
kibab added 1 blocking reviewer(s) for D15892: Use information about max data size that the controller is able to operate: imp.
Jun 19 2018, 11:29 AM
kibab committed rS335367: Don't try to turn power down MMC bus if it is already down.
Don't try to turn power down MMC bus if it is already down
Jun 19 2018, 11:29 AM
kibab closed D15890: Don't try to turn power down MMC bus if it is already down.
Jun 19 2018, 11:29 AM
kibab added inline comments to D15890: Don't try to turn power down MMC bus if it is already down.
Jun 19 2018, 11:26 AM
kibab committed rS335366: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Correctly define rawscr so initializing it doesn't result in overwriting memory.
Jun 19 2018, 11:26 AM
kibab closed D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Jun 19 2018, 11:26 AM
kibab committed rS335365: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Set MMC_DATA_MULTI flag when doing multi-block transfers
Jun 19 2018, 11:24 AM
kibab closed D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Jun 19 2018, 11:24 AM

Jun 18 2018

kibab added a child revision for D15891: Add MMCCAM support to AllWinner MMC driver: D15892: Use information about max data size that the controller is able to operate.
Jun 18 2018, 9:55 PM
kibab added a parent revision for D15892: Use information about max data size that the controller is able to operate: D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:55 PM
kibab created D15892: Use information about max data size that the controller is able to operate.
Jun 18 2018, 9:54 PM
kibab added parent revisions for D15891: Add MMCCAM support to AllWinner MMC driver: D15890: Don't try to turn power down MMC bus if it is already down, D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory., D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Jun 18 2018, 9:23 PM
kibab added a child revision for D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers: D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:23 PM
kibab added a child revision for D15890: Don't try to turn power down MMC bus if it is already down: D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:23 PM
kibab added a child revision for D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory.: D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:23 PM
kibab created D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:20 PM
kibab created D15890: Don't try to turn power down MMC bus if it is already down.
Jun 18 2018, 9:14 PM
kibab created D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Jun 18 2018, 9:13 PM
kibab created D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Jun 18 2018, 9:11 PM

Jun 5 2018

kibab committed rS334651: Enable high-speed on the card before increasing frequency on the controller.
Enable high-speed on the card before increasing frequency on the controller
Jun 5 2018, 11:03 AM
kibab closed D15568: Enable high-speed on the card before increasing frequency on the controller.
Jun 5 2018, 11:03 AM · ARM, arm64

May 29 2018

kibab added inline comments to D14168: BCM2835 (Raspberry Pi 3) sdhost device driver.
May 29 2018, 9:07 AM

May 25 2018

kibab committed rS334218: Fix building GENERIC-MMCCAM on arm64.
Fix building GENERIC-MMCCAM on arm64
May 25 2018, 7:00 PM
kibab closed D15569: Fix building GENERIC-MMCCAM on arm64.
May 25 2018, 7:00 PM · arm64
kibab created D15569: Fix building GENERIC-MMCCAM on arm64.
May 25 2018, 10:12 AM · arm64
kibab created D15568: Enable high-speed on the card before increasing frequency on the controller.
May 25 2018, 9:46 AM · ARM, arm64

May 22 2018

kibab committed rS334065: Implement initial MMC partitions support for MMCCAM..
Implement initial MMC partitions support for MMCCAM.
May 22 2018, 10:17 PM
kibab closed D12762: Implement initial MMC partitions support for MMCCAM.
May 22 2018, 10:17 PM · ARM
kibab committed rS334059: Fix MMCCAM scanning for new cards..
Fix MMCCAM scanning for new cards.
May 22 2018, 4:32 PM
kibab closed D15521: Fix MMCCAM scanning for new cards.
May 22 2018, 4:32 PM · ARM
kibab created D15521: Fix MMCCAM scanning for new cards.
May 22 2018, 3:24 PM · ARM

May 18 2018

kibab added a comment to D13063: Fix setting RCA for MMC cards.

In any case, I think support for busses is a must for MMCCAM due to eSD. Judging Linux code and commit messages I've read, designs with multiple eSDIO devices on a bus are real.

May 18 2018, 7:19 PM

Mar 11 2018

kibab added a reviewer for D12467: Add sdio(4) peripheral device: scottl.
Mar 11 2018, 8:32 AM
kibab updated subscribers of D12467: Add sdio(4) peripheral device.
Mar 11 2018, 8:32 AM
kibab added a comment to D13064: Netconsole implementation for FreeBSD.

Have you looked at markj's netdump branch? Would his lower-level UDP send routines be a better transport for the console messages?

That code is specifically designed to run after a panic, while this is not. Ideally netcons would be usable in either context, but I wouldn't consider that to be a gating feature.

Actually I need precisely that! Running UDP send after panic would help to see a panic message. What is the purpose of netdump branch, what are you developing there?

The aim is to make it possible to transmit kernel dumps after a panic. See the netdump.4 and dumpon.8 man pages in that branch. I've been meaning to get it into FreeBSD for a long time and would rather not hold it up to add new features now, as I'm basically ready to get it reviewed and merged, but I'd be happy to work on refactoring it for use by other subsystems afterwards.

Mar 11 2018, 5:05 AM
kibab added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Marius,
thanks for your review.
I have created separate issues for each of the point you've mentioned: https://github.com/kibab/freebsd/projects/1
Seems none of those are directly related to the scope of this particular change. Do you think it's fine to commit this code so that partition functionality is in -HEAD?

Mar 11 2018, 2:17 AM · ARM

Mar 10 2018

kibab requested review of D13063: Fix setting RCA for MMC cards.

So, as I wrote in reply to the inline comment, supporting multiple MMC cards on the same bus is not something I would try to implement in the new stack, given that I have never seen any hardware with such setup and that the old stack AFAIK doesn't properly support this.
Apart from that, any comments?

Mar 10 2018, 2:31 PM
kibab added a comment to D13063: Fix setting RCA for MMC cards.

RCA = 2 is just because I need to send _some_ RCA to the card. So I chose to send 2, could also choose any other number :-)

Unlike SD prior to eSD, MMC is a bus which may have multiple children that in case of MMC require unique RCAs to be assigned. So while you may start with 2 for the first child, you need code which increments the RCA for additional children on the same bus.

Mar 10 2018, 2:29 PM
kibab added a comment to D13064: Netconsole implementation for FreeBSD.
In D13064#303809, @cem wrote:

Haven't done a thorough review, but will take another look when some of the outstanding issues are cleaned up.

Mar 10 2018, 8:58 AM
kibab added a comment to D13064: Netconsole implementation for FreeBSD.

Have you looked at markj's netdump branch? Would his lower-level UDP send routines be a better transport for the console messages?

That code is specifically designed to run after a panic, while this is not. Ideally netcons would be usable in either context, but I wouldn't consider that to be a gating feature.

Mar 10 2018, 8:57 AM
kibab abandoned D12625: Add an MMCCAM-enabled version of ARM GENERIC kernel.

This was added in r330674 by manu@

Mar 10 2018, 7:20 AM

Jan 19 2018

kibab accepted D13868: Use XPT_GET_ADVINFO for retrieving MMC params.

This change LGTM, I would like to know how this was discovered?

Jan 19 2018, 2:23 PM

Nov 14 2017

kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Address review comments

Nov 14 2017, 9:48 PM · ARM
kibab added inline comments to D12762: Implement initial MMC partitions support for MMCCAM.
Nov 14 2017, 9:48 PM · ARM

Nov 13 2017

kibab added a comment to D13063: Fix setting RCA for MMC cards.

RCA = 2 is just because I need to send _some_ RCA to the card. So I chose to send 2, could also choose any other number :-)

Nov 13 2017, 2:00 PM
kibab updated the diff for D13063: Fix setting RCA for MMC cards.

Address review comments

Nov 13 2017, 1:58 PM

Nov 12 2017

kibab created D13064: Netconsole implementation for FreeBSD.
Nov 12 2017, 8:06 PM
kibab created D13063: Fix setting RCA for MMC cards.
Nov 12 2017, 7:56 PM
kibab added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Hi Marius, thank you very much for such a verbose review!
I have addressed most of your comments. As for the remaining ones -- they require some more work which I'd like to do in the upcoming changes. As all my work should be reviewed by Warner before committing, I'd like to try to keep the diff sizes under certain limit.

Nov 12 2017, 7:52 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Address review comments

Nov 12 2017, 7:50 PM · ARM

Oct 28 2017

kibab added a comment to D12762: Implement initial MMC partitions support for MMCCAM.

Well, IMO committing the partition identification code only with all the glory details yet to be done is premature, even for head.
Generally: Please adhere to style(9).

Oct 28 2017, 12:44 PM · ARM
kibab updated the summary of D12762: Implement initial MMC partitions support for MMCCAM.
Oct 28 2017, 12:42 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

void function shouldn'r return a value, remove sdda_hook_into_geom()

Oct 28 2017, 12:32 PM · ARM
kibab updated the diff for D12762: Implement initial MMC partitions support for MMCCAM.

Actually implement partitions support

Oct 28 2017, 12:27 PM · ARM

Oct 22 2017

kibab created D12762: Implement initial MMC partitions support for MMCCAM.
Oct 22 2017, 9:48 PM · ARM

Oct 9 2017

kibab updated the diff for D12467: Add sdio(4) peripheral device.

Properly do attachment of child devices

Oct 9 2017, 6:44 PM

Oct 8 2017

kibab updated the diff for D12467: Add sdio(4) peripheral device.

newbus attach musings

Oct 8 2017, 10:35 PM
kibab created D12625: Add an MMCCAM-enabled version of ARM GENERIC kernel.
Oct 8 2017, 10:34 PM

Sep 24 2017

kibab committed rS323966: Rename sdhci_cam_start_slot() into sdhci_start_slot().
Rename sdhci_cam_start_slot() into sdhci_start_slot()
Sep 24 2017, 9:05 AM
kibab closed D12471: Rename sdhci_cam_start_slot() into sdhci_start_slot().
Sep 24 2017, 9:05 AM

Sep 23 2017

kibab abandoned D12465: Make MMCCAM work with sdhci_acpi.

Superceded by D12471 that provides more generic way of adding MMCCAM support to SDHCI drivers.

Sep 23 2017, 8:17 AM
kibab created D12471: Rename sdhci_cam_start_slot() into sdhci_start_slot().
Sep 23 2017, 8:12 AM

Sep 22 2017

kibab updated the summary of D12467: Add sdio(4) peripheral device.
Sep 22 2017, 3:51 PM
kibab created D12467: Add sdio(4) peripheral device.
Sep 22 2017, 3:47 PM
kibab created D12465: Make MMCCAM work with sdhci_acpi.
Sep 22 2017, 3:08 PM

Sep 18 2017

kibab closed D12386: Add kern.features flag for MMCCAM.
Sep 18 2017, 8:17 PM
kibab committed rS323721: Add kern.features flag for MMCCAM.
Add kern.features flag for MMCCAM
Sep 18 2017, 8:17 PM
kibab committed rS323717: Make basic Broadcom I/O space reading functions work.
Make basic Broadcom I/O space reading functions work
Sep 18 2017, 8:01 PM
kibab closed D12111: Make basic Broadcom I/O space reading functions work.
Sep 18 2017, 8:01 PM
kibab updated the diff for D12111: Make basic Broadcom I/O space reading functions work.

Added licenses for the code from Broadcom

Sep 18 2017, 8:03 AM
kibab updated the diff for D12111: Make basic Broadcom I/O space reading functions work.

Added files lost in the process of doing git rebase magic. PTAL

Sep 18 2017, 7:56 AM

Sep 15 2017

kibab created D12386: Add kern.features flag for MMCCAM.
Sep 15 2017, 8:05 PM
kibab committed rS323619: Miscellaneous fixes and improvements to MMCCAM stack.
Miscellaneous fixes and improvements to MMCCAM stack
Sep 15 2017, 7:48 PM
kibab closed D12109: Miscellaneous fixes and improvements to MMCCAM stack.
Sep 15 2017, 7:48 PM

Sep 13 2017

kibab committed rS323532: Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels.
Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels
Sep 13 2017, 10:56 AM
kibab closed D12110: Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels.
Sep 13 2017, 10:56 AM

Sep 11 2017

kibab committed rD50825: Update my PGP key.
Update my PGP key
Sep 11 2017, 8:46 PM
kibab committed rS323458: Add MMCCAM-enabled kernel config for arm64.
Add MMCCAM-enabled kernel config for arm64
Sep 11 2017, 7:07 PM
kibab closed D12114: Add MMCCAM-enabled kernel config for arm64.
Sep 11 2017, 7:07 PM · ARM, arm64

Sep 10 2017

kibab closed D12304: Add information about new src committer (kibab).
Sep 10 2017, 8:33 PM
kibab committed rS323398: Add information about new src committer (kibab).
Add information about new src committer (kibab)
Sep 10 2017, 8:33 PM
kibab committed rD50819: Introduce information about new commiter - kibab.
Introduce information about new commiter - kibab
Sep 10 2017, 8:32 PM
kibab closed D12303: Introduce information about new commiter - kibab.
Sep 10 2017, 8:32 PM
kibab updated the diff for D12304: Add information about new src committer (kibab).

Use tabs, not spaces, in calendar file

Sep 10 2017, 6:14 AM
kibab retitled D12304: Add information about new src committer (kibab) from Add information about me and imp@ as my mentor to Add information about new src committer (kibab).
Sep 10 2017, 6:12 AM
kibab updated the diff for D12304: Add information about new src committer (kibab).

Include caldndar.freebsd modifications here

Sep 10 2017, 6:10 AM
kibab created D12304: Add information about new src committer (kibab).
Sep 10 2017, 6:05 AM
kibab created D12303: Introduce information about new commiter - kibab.
Sep 10 2017, 5:56 AM

Aug 29 2017

kibab updated the diff for D12110: Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels.

Renamed kernel conf for amd64 and fixes whitespaces

Aug 29 2017, 7:04 PM
kibab updated the diff for D12110: Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels.

Removed device mmccam, added NO_UNIVERSE

Aug 29 2017, 6:59 PM