- User Since
- Sep 26 2014, 6:46 AM (243 w, 3 d)
Apr 10 2019
Addressed reviewer's comment about magic constant, added more comments.
- Move new fields to the end
Apr 7 2019
Updated to use MMC_DATA_BLOCK_SIZE.
- Implement CMD53 block mode support for SDHCI and AllWinner-based boards
- Use the new MMC_DATA_BLOCK_SIZE
- Put blank before colon when printing command args
Reupload the change.
Apr 5 2019
Updated; please take a look.
Killed CMD53-related changes, leaving only field changes.
Apr 1 2019
Added (hopefully) missing files.
Generally LGTM with a few nits.
Mar 22 2019
- Use SDHCI_MAKE_BLKSZ() for calculating block size
- Initialize new fields of mmc_data properly
- Make block mode work
Mar 21 2019
Mar 20 2019
Address comments from bz@
Mar 19 2019
addressed reviewer comments
- locking fix for D15955
Jun 21 2018
Jun 20 2018
Jun 19 2018
Jun 18 2018
Jun 5 2018
May 29 2018
May 25 2018
May 22 2018
May 18 2018
Mar 11 2018
thanks for your review.
I have created separate issues for each of the point you've mentioned: https://github.com/kibab/freebsd/projects/1
Seems none of those are directly related to the scope of this particular change. Do you think it's fine to commit this code so that partition functionality is in -HEAD?
Mar 10 2018
So, as I wrote in reply to the inline comment, supporting multiple MMC cards on the same bus is not something I would try to implement in the new stack, given that I have never seen any hardware with such setup and that the old stack AFAIK doesn't properly support this.
Apart from that, any comments?
This was added in r330674 by manu@
Jan 19 2018
This change LGTM, I would like to know how this was discovered?
Nov 14 2017
Address review comments