Page MenuHomeFreeBSD

kibab (Ilya Bakulin)
User

Projects

User Details

User Since
Sep 26 2014, 6:46 AM (316 w, 6 d)

Recent Activity

Sep 1 2020

kibab accepted D26153: SDHCI: Introduce a driver for NXP QorIQ LS10xx SoCs..

At the first glance I don't see anything weird wrt MMCCAM intergration; I agree that MMCCAM-related problems should be fixed in the follow-up commits and not here.
Regarding the partitions: it would be interesting to see the output of ls /dev/sdda* on MMCCAM kernel, probably the partitions got detected but not printed on boot.

Sep 1 2020, 12:15 PM

Aug 4 2020

kibab committed rS363870: Minor cleanups in mmc_xpt.c.
Minor cleanups in mmc_xpt.c
Aug 4 2020, 9:58 PM
kibab closed D25843: Minor cleanups in mmc_xpt.c.
Aug 4 2020, 9:58 PM
kibab updated the diff for D25843: Minor cleanups in mmc_xpt.c.
  • Remove excessive printf
Aug 4 2020, 7:58 PM
kibab accepted D25949: mmcam: Use a static length sbuf buffer.
Aug 4 2020, 7:51 PM
kibab accepted D25948: mmccam: mmc_xpt: We're only interested about losing the device.
Aug 4 2020, 7:50 PM
kibab updated the diff for D25843: Minor cleanups in mmc_xpt.c.
  • Fix style(9)
Aug 4 2020, 10:45 AM
kibab requested review of D25843: Minor cleanups in mmc_xpt.c.
Aug 4 2020, 10:32 AM

Jul 28 2020

kibab abandoned D15955: Discover cards on boot.

The support for this has been merged in -HEAD through other commits.
Some last bits are coming in https://reviews.freebsd.org/D25843.

Jul 28 2020, 7:51 AM
kibab requested review of D25843: Minor cleanups in mmc_xpt.c.
Jul 28 2020, 7:31 AM

Jul 24 2020

kibab committed rS363497: Make it possible to get/set MMC frequency from camcontrol.
Make it possible to get/set MMC frequency from camcontrol
Jul 24 2020, 9:15 PM
kibab closed D25795: Make it possible to get/set MMC frequency from camcontrol.
Jul 24 2020, 9:15 PM
kibab requested review of D25795: Make it possible to get/set MMC frequency from camcontrol.
Jul 24 2020, 9:49 AM

Nov 28 2019

kibab added inline comments to D15955: Discover cards on boot.
Nov 28 2019, 3:47 PM
kibab updated the diff for D15955: Discover cards on boot.

Updated to output an error message if various allocation functions failed. Also, revert to using alloc_ccb() from alloc_ccb_nowait() since it's pretty fine to wait in the contexts where start_discovery() is executed.

Nov 28 2019, 3:45 PM

Nov 26 2019

kibab updated the test plan for D15955: Discover cards on boot.
Nov 26 2019, 9:21 PM
kibab updated the diff for D15955: Discover cards on boot.
Nov 26 2019, 9:09 PM

Nov 1 2019

kibab created D22217: Fix iterating over BT LE responses.
Nov 1 2019, 9:45 PM

Oct 30 2019

kibab committed rS354206: Use the new cam_sim_alloc_dev function to properly initialize SIM.
Use the new cam_sim_alloc_dev function to properly initialize SIM
Oct 30 2019, 8:43 PM
kibab closed D22192: Use the new cam_sim_alloc_dev function to properly initialize SIM.
Oct 30 2019, 8:43 PM · arm64
kibab created D22192: Use the new cam_sim_alloc_dev function to properly initialize SIM.
Oct 30 2019, 2:12 PM · arm64

May 28 2019

kibab accepted D19749: Add a CAM-Newbus SDIO support module..

LGTM with a couple of tiny comments. Thanks!

May 28 2019, 5:42 PM

Apr 10 2019

kibab committed rS346100: Add some CMD53-related definitions.
Add some CMD53-related definitions
Apr 10 2019, 8:45 PM
kibab closed D19832: Add some CMD53-related definitions.
Apr 10 2019, 8:45 PM
kibab updated the diff for D19832: Add some CMD53-related definitions.

Addressed reviewer's comment about magic constant, added more comments.

Apr 10 2019, 8:35 PM
kibab committed rS346098: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.
Implement CMD53 block mode support for SDHCI and AllWinner-based boards
Apr 10 2019, 7:53 PM
kibab closed D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.
Apr 10 2019, 7:53 PM
kibab committed rS346097: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Add new fields to mmc_data in preparation to SDIO CMD53 block mode support
Apr 10 2019, 7:49 PM
kibab closed D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Apr 10 2019, 7:49 PM · ARM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
  • Move new fields to the end
Apr 10 2019, 7:41 PM · ARM
kibab added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Apr 10 2019, 7:41 PM · ARM

Apr 7 2019

kibab added a comment to D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.

Updated to use MMC_DATA_BLOCK_SIZE.

Apr 7 2019, 12:22 PM
kibab updated the diff for D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.
  • Implement CMD53 block mode support for SDHCI and AllWinner-based boards
  • Use the new MMC_DATA_BLOCK_SIZE
  • Put blank before colon when printing command args
Apr 7 2019, 12:21 PM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Try again

Apr 7 2019, 11:53 AM · ARM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Reupload the change.

Apr 7 2019, 11:47 AM · ARM

Apr 5 2019

kibab added a comment to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Updated; please take a look.

Apr 5 2019, 5:01 PM · ARM
kibab created D19832: Add some CMD53-related definitions.
Apr 5 2019, 4:57 PM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Killed CMD53-related changes, leaving only field changes.

Apr 5 2019, 4:53 PM · ARM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Addressed comments

Apr 5 2019, 4:48 PM · ARM

Apr 1 2019

kibab added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Apr 1 2019, 11:03 PM · ARM
kibab added a comment to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
In D19779#424273, @imp wrote:
In D19779#424220, @bz wrote:

This is missing files I think. The mmcreg.h structure changes are missing from this one. This won't compile.

Sorry, something has gone wrong with my tree. I will reupload.

IF you jhust added the block count and block size to the end, there's no need to rebuild camcontrol...

Apr 1 2019, 11:00 PM · ARM
kibab updated the diff for D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.

Added (hopefully) missing files.

Apr 1 2019, 10:56 PM · ARM
kibab added a comment to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
In D19779#424220, @bz wrote:

This is missing files I think. The mmcreg.h structure changes are missing from this one. This won't compile.

Apr 1 2019, 9:04 PM · ARM
kibab added inline comments to D19674: Implement CMD53 support for byte mode and block mode.
Apr 1 2019, 9:02 PM
kibab created D19783: Implement CMD53 block mode support for SDHCI and AllWinner-based boards.
Apr 1 2019, 8:20 PM
kibab retitled D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support from Add new fields to mmc_data in preparation to SDIO CMD53 block mode support SDIO command CMD53 (IO_RW_EXTENDED) allows data transfers using blocks of 1-2048 bytes, with a maximum of 511 blocks per request. Extend mmc_data structure to properly... to Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Apr 1 2019, 8:03 PM · ARM
kibab created D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
Apr 1 2019, 7:25 PM · ARM
kibab committed rS345776: Refactor error handling.
Refactor error handling
Apr 1 2019, 6:54 PM
kibab closed D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Apr 1 2019, 6:54 PM
kibab committed rS345775: Use information about max data size that the controller is able to operate.
Use information about max data size that the controller is able to operate
Apr 1 2019, 6:50 PM
kibab closed D15892: Use information about max data size that the controller is able to operate.
Apr 1 2019, 6:49 PM
kibab requested changes to D19749: Add a CAM-Newbus SDIO support module..

Generally LGTM with a few nits.

Apr 1 2019, 6:36 PM
kibab accepted D19747: Improve sdhci slot_printf() debug printing..
Apr 1 2019, 6:10 PM
kibab accepted D19748: Improve error/debug messages in sdhci.c.
Apr 1 2019, 6:08 PM

Mar 22 2019

kibab retitled D19674: Implement CMD53 support for byte mode and block mode from Implement CMD53 support for byte-mode only, block mode is WIP. to Implement CMD53 support for byte mode and block mode.
Mar 22 2019, 9:56 PM
kibab added a comment to D19674: Implement CMD53 support for byte mode and block mode.
In D19674#421509, @bz wrote:

I haven't convinced myself yet that these two extra fields are actually needed but meanwhile this is needed (independently). I'll put it into a proper review later tonight.

    Properly zero mmc_data structures in mmc_da.c
    With upcoming MMCCAM changes extra fields will otherwise contain garbage
    and yield unexpected or unhelpful results (hanging controllers and the like).

diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c
index a2dbf949b40..6ec73a46050 100644
--- a/sys/cam/mmc/mmc_da.c
+++ b/sys/cam/mmc/mmc_da.c
@@ -843,6 +843,7 @@ mmc_send_ext_csd(struct cam_periph *periph, union ccb *ccb,
        struct mmc_data d;

        KASSERT(buf_len == 512, ("Buffer for ext csd must be 512 bytes"));
+       memset(&d, 0, sizeof(d));
        d.data = rawextcsd;
        d.len = buf_len;
        d.flags = MMC_DATA_READ;
@@ -988,6 +989,7 @@ mmc_sd_switch(struct cam_periph *periph, union ccb *ccb,
        struct mmc_data mmc_d;
        uint32_t arg;

+       memset(&mmc_d, 0, sizeof(mmc_d));
        memset(res, 0, 64);
        mmc_d.len = 64;
        mmc_d.data = res;
'''
Mar 22 2019, 9:54 PM
kibab updated the diff for D19674: Implement CMD53 support for byte mode and block mode.
  • Use SDHCI_MAKE_BLKSZ() for calculating block size
  • Initialize new fields of mmc_data properly
  • Make block mode work
Mar 22 2019, 9:53 PM

Mar 21 2019

kibab created D19674: Implement CMD53 support for byte mode and block mode.
Mar 21 2019, 11:19 PM
kibab removed reviewers for D15955: Discover cards on boot: imp, manu.
Mar 21 2019, 9:54 AM
kibab added a comment to D15955: Discover cards on boot.
In D15955#421067, @bz wrote:
In D15955#420988, @manu wrote:
In D15955#357900, @manu wrote:

Quoting myself :

The correct solution is implementing proper card insertion detection. This is, however, out of scope for this change. I'm just replicating the way it's implemented for mmc(4) in this driver, for now.

Yes and that's what I don't like, this is not the correct solution for this problem.

Ok, stupid me, has two questions:

(a) what would be proper card insertion detection here for this one? (I am battling a similar issue elsewhere currently)

(b) if the API gets changed, so it works without the aw_mmc_softc, the function gets put into a central place outside this driver, and then gets called, is that what you are asking @manu ?

Mar 21 2019, 9:53 AM

Mar 20 2019

kibab updated the diff for D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.

Address comments from bz@

Mar 20 2019, 11:46 AM

Mar 19 2019

kibab updated the diff for D15955: Discover cards on boot.
  • Fix spacing
Mar 19 2019, 11:16 PM
kibab updated the diff for D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.

addressed reviewer comments

Mar 19 2019, 11:10 PM
kibab added inline comments to D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Mar 19 2019, 11:07 PM
kibab updated the diff for D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.

Sync Arcanist

Mar 19 2019, 10:52 PM
kibab updated the diff for D15892: Use information about max data size that the controller is able to operate.
  • Address comments in D15892 wrt max_data setting and MIN(MAX_PHYS,...)
  • MIN(MAXPHYS) for D15892
Mar 19 2019, 10:43 PM
kibab updated the diff for D15955: Discover cards on boot.
Mar 19 2019, 10:36 PM
kibab added a comment to D15955: Discover cards on boot.
In D15955#357900, @manu wrote:

Quoting myself :

20:51 < manu> I'm not sure this is the right solution
20:52 < manu
> it seems that it's cam only code
20:52 < manu__> so I don't understand why it's not in a generic function

Mar 19 2019, 10:23 PM

Jun 21 2018

kibab created D15955: Discover cards on boot.
Jun 21 2018, 6:05 PM
kibab committed rS335476: Add MMCCAM support to AllWinner MMC driver.
Add MMCCAM support to AllWinner MMC driver
Jun 21 2018, 11:49 AM
kibab closed D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 21 2018, 11:49 AM

Jun 20 2018

kibab added inline comments to D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 20 2018, 8:40 AM

Jun 19 2018

kibab updated the summary of D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 19 2018, 9:15 PM
kibab updated the test plan for D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 19 2018, 9:13 PM
kibab added a comment to D15891: Add MMCCAM support to AllWinner MMC driver.
In D15891#336175, @manu wrote:

This looks okay for me except one comment.
But due to the fact that I/We had a lot of problems with different revision of the hardware IP let me test on different SoC before commiting.
Also I won't set this review as accepted as I don't know anything about CAM.

Jun 19 2018, 9:09 PM
kibab created D15912: sys/cam/mmc/mmc_da.c: Refactor error handling.
Jun 19 2018, 8:43 PM
kibab committed rS335384: Fix setting RCA for MMC cards.
Fix setting RCA for MMC cards
Jun 19 2018, 8:02 PM
kibab closed D13063: Fix setting RCA for MMC cards.
Jun 19 2018, 8:02 PM
kibab added 1 blocking reviewer(s) for D15892: Use information about max data size that the controller is able to operate: imp.
Jun 19 2018, 11:29 AM
kibab committed rS335367: Don't try to turn power down MMC bus if it is already down.
Don't try to turn power down MMC bus if it is already down
Jun 19 2018, 11:29 AM
kibab closed D15890: Don't try to turn power down MMC bus if it is already down.
Jun 19 2018, 11:29 AM
kibab added inline comments to D15890: Don't try to turn power down MMC bus if it is already down.
Jun 19 2018, 11:26 AM
kibab committed rS335366: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Correctly define rawscr so initializing it doesn't result in overwriting memory.
Jun 19 2018, 11:26 AM
kibab closed D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Jun 19 2018, 11:26 AM
kibab committed rS335365: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Set MMC_DATA_MULTI flag when doing multi-block transfers
Jun 19 2018, 11:24 AM
kibab closed D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Jun 19 2018, 11:24 AM

Jun 18 2018

kibab created D15892: Use information about max data size that the controller is able to operate.
Jun 18 2018, 9:54 PM
kibab created D15891: Add MMCCAM support to AllWinner MMC driver.
Jun 18 2018, 9:20 PM
kibab created D15890: Don't try to turn power down MMC bus if it is already down.
Jun 18 2018, 9:14 PM
kibab created D15889: Correctly define rawscr so initializing it doesn't result in overwriting memory..
Jun 18 2018, 9:13 PM
kibab created D15888: Set MMC_DATA_MULTI flag when doing multi-block transfers.
Jun 18 2018, 9:11 PM

Jun 5 2018

kibab committed rS334651: Enable high-speed on the card before increasing frequency on the controller.
Enable high-speed on the card before increasing frequency on the controller
Jun 5 2018, 11:03 AM
kibab closed D15568: Enable high-speed on the card before increasing frequency on the controller.
Jun 5 2018, 11:03 AM · ARM, arm64

May 29 2018

kibab added inline comments to D14168: BCM2835 (Raspberry Pi 3) sdhost device driver.
May 29 2018, 9:07 AM

May 25 2018

kibab committed rS334218: Fix building GENERIC-MMCCAM on arm64.
Fix building GENERIC-MMCCAM on arm64
May 25 2018, 7:00 PM
kibab closed D15569: Fix building GENERIC-MMCCAM on arm64.
May 25 2018, 7:00 PM · arm64
kibab created D15569: Fix building GENERIC-MMCCAM on arm64.
May 25 2018, 10:12 AM · arm64
kibab created D15568: Enable high-speed on the card before increasing frequency on the controller.
May 25 2018, 9:46 AM · ARM, arm64

May 22 2018

kibab committed rS334065: Implement initial MMC partitions support for MMCCAM..
Implement initial MMC partitions support for MMCCAM.
May 22 2018, 10:17 PM
kibab closed D12762: Implement initial MMC partitions support for MMCCAM.
May 22 2018, 10:17 PM · ARM