HomeFreeBSD

Always return MMC errors from mmc_handle_reply()

Description

Always return MMC errors from mmc_handle_reply()

There are two ways to propagate the error in MMCCAM:

  • Using cmd.error which is set by the peripheral driver;
  • Using CCB status which is... also set by the driver.

The problem is that those two error conditions don't necessarily match.
This leads to the confusion when handling the MMC reply. So enforce the consistency
by panicking if request is marked as completed successfully but MMC-level error
is present (this hints to the programming error).

Reviewed by: manu
Approved by: imp (mentor)
Differential Revision: https://reviews.freebsd.org/D26925

Details

Provenance
kibabAuthored on
Reviewer
manu
Differential Revision
D26925: Always return MMC errors from mmc_handle_reply()
Parents
rS367305: MFC 358556,360167: Add support for the TFTP windowsize option.
Branches
Unknown
Tags
Unknown