Page MenuHomeFreeBSD
Differential D27087

Get initial VCCQ voltage from FDT if available
Needs ReviewPublic
Actions

Authored by kibab on Nov 4 2020, 12:27 PM.
Tags
None
Referenced Files
F174500863: D27087.diff
Sat, Oct 3, 6:14 PM
F174462989: D27087.id79169.diff
Sat, Oct 3, 11:05 AM
Unknown Object (File)
Fri, Oct 2, 4:13 PM
Unknown Object (File)
Thu, Oct 1, 8:15 PM
Unknown Object (File)
Wed, Sep 23, 2:36 AM
Unknown Object (File)
Sat, Sep 19, 4:35 AM
Unknown Object (File)
Sat, Sep 19, 2:15 AM
Unknown Object (File)
Aug 20 2026, 8:55 AM
View All Files
Subscribers
None

Details

Reviewers
manu
imp

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34621
Build 31710: arc lint + arc unit

Event Timeline

kibab requested review of this revision.Nov 4 2020, 12:27 PM
kibab created this revision.
Harbormaster completed remote builds in B34621: Diff 79169.Nov 4 2020, 12:27 PM
kibab added reviewers: manu, imp.Nov 4 2020, 12:29 PM
kibab set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a comment.Nov 4 2020, 12:59 PM

One minor comment but looks ok otherwise.

sys/dev/mmc/mmc_fdt_helpers.c
174

Maybe add a default: with a printf under bootverbose if we can't get the current voltage ?

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
17 lines

Diff 79169

View Options

sys/dev/mmc/mmc_fdt_helpers.c

Loading...