Page MenuHomeFreeBSD
Differential D25947

mmccam: We can't sleep during sdda_add_part so use M_NOWAIT
ClosedPublic
Actions

Authored by manu on Aug 4 2020, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 20, 9:32 AM
Unknown Object (File)
Mon, May 12, 8:15 AM
Unknown Object (File)
Sat, May 10, 12:33 PM
Unknown Object (File)
Fri, May 9, 5:28 AM
Unknown Object (File)
Apr 24 2025, 1:39 AM
Unknown Object (File)
Mar 26 2025, 4:48 AM
Unknown Object (File)
Feb 27 2025, 6:40 PM
Unknown Object (File)
Feb 27 2025, 6:38 PM
View All 76 Files
Subscribers
None

Details

Reviewers
imp
kibab
Group Reviewers
cam
Commits
rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Aug 4 2020, 5:30 PM
Herald added a reviewer: cam. · View Herald TranscriptAug 4 2020, 5:30 PM
manu requested review of this revision.Aug 4 2020, 5:30 PM
imp added inline comments.Aug 4 2020, 5:46 PM
sys/cam/mmc/mmc_da.c
1513 ↗(On Diff #75379)

If this fails, do you need to try again?

kibab accepted this revision.Oct 30 2020, 10:20 AM
kibab added inline comments.
sys/cam/mmc/mmc_da.c
1513 ↗(On Diff #75379)

What is the normal behaviour in this case? Do we ever retry on low memory? My take on this one would be "not retry", as system is probably under memory pressure.

This revision is now accepted and ready to land.Oct 30 2020, 10:20 AM
Closed by commit rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT (authored by manu). · Explain WhyNov 26 2020, 4:40 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT.

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
mmc/
21 lines

Diff 80025

View Options

head/sys/cam/mmc/mmc_da.c

Loading...