mmccam: We can't sleep during sdda_add_part so use M_NOWAIT
ClosedPublic
Actions

Authored by manu on Aug 4 2020, 5:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 7:13 PM

	Unknown Object (File)
	Tue, Apr 30, 7:17 AM

	Unknown Object (File)
	Tue, Apr 30, 7:17 AM

	Unknown Object (File)
	Tue, Apr 30, 7:17 AM

	Unknown Object (File)
	Tue, Apr 30, 12:58 AM

	Unknown Object (File)
	Fri, Apr 19, 12:45 AM

	Unknown Object (File)
	Thu, Apr 18, 12:06 AM

	Unknown Object (File)
	Apr 2 2024, 11:14 PM

View All 33 Files

Subscribers

None

Details

Reviewers

imp
kibab

Group Reviewers

cam

Commits

rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Aug 4 2020, 5:30 PM

Herald added a reviewer: cam. · View Herald TranscriptAug 4 2020, 5:30 PM

manu requested review of this revision.Aug 4 2020, 5:30 PM

imp added inline comments.Aug 4 2020, 5:46 PM

sys/cam/mmc/mmc_da.c
1513 ↗	(On Diff #75379)	If this fails, do you need to try again?

kibab accepted this revision.Oct 30 2020, 10:20 AM

kibab added inline comments.

sys/cam/mmc/mmc_da.c
1513 ↗	(On Diff #75379)	What is the normal behaviour in this case? Do we ever retry on low memory? My take on this one would be "not retry", as system is probably under memory pressure.

This revision is now accepted and ready to land.Oct 30 2020, 10:20 AM

Closed by commit rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT (authored by manu). · Explain WhyNov 26 2020, 4:40 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS368059: mmccam: We can't sleep during sdda_add_part so use M_NOWAIT.

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

mmc/

mmc_da.c

21 lines

Diff 80025

View Options

mmccam: We can't sleep during sdda_add_part so use M_NOWAITClosedPublicActions