Page MenuHomeFreeBSD
Differential D15779

sysutils/storcli: update to 7.5
ClosedPublic
Actions

Authored by fernape on Jun 12 2018, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 3:14 PM
Unknown Object (File)
May 22 2024, 3:05 PM
Unknown Object (File)
May 22 2024, 8:38 AM
Unknown Object (File)
May 8 2024, 9:51 PM
Unknown Object (File)
May 5 2024, 12:47 PM
Unknown Object (File)
May 5 2024, 12:47 PM
Unknown Object (File)
May 5 2024, 12:47 PM
Unknown Object (File)
May 5 2024, 12:46 PM
View All 92 Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP473045: sysutils/storcli: Update to 7.5
Summary

Sent by maintainer via PR 228777

This version needs to be downloaded manually after accepting the license agreement.

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.1 OK (light as I don't have a RAID config)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Jun 12 2018, 5:22 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 12 2018, 5:22 PM
Harbormaster completed remote builds in B17203: Diff 43659.Jun 12 2018, 5:22 PM
tcberner added inline comments.Jun 12 2018, 5:41 PM
sysutils/storcli/Makefile
4 ↗(On Diff #43659)

oO

fernape updated this revision to Diff 43660.Jun 12 2018, 6:18 PM

Using a sane number terminology.

Note that in the web site, the version is advertised as 7.5.
I would keep the .504 revision number in case there are future revisions.

Harbormaster completed remote builds in B17204: Diff 43660.Jun 12 2018, 6:18 PM
tcberner added a comment.Jun 15 2018, 6:45 PM

Your last change looks broken :)

fernape updated this revision to Diff 43841.Jun 15 2018, 6:57 PM

Trying to fix previuos arc diff update...

Harbormaster completed remote builds in B17312: Diff 43841.Jun 15 2018, 6:57 PM
fernape added a comment.Jun 15 2018, 7:00 PM

I thought I uploaded only the DISTVERSION changes, but I didn't. The new changes are all there (the check for the distfile and so...). I had to expand the whole file to see it in the review.

How is this broken? I'm sure I'm missing something here... :S

fernape added a comment.Jun 15 2018, 7:10 PM
In D15779#334761, @fernape wrote:

I thought I uploaded only the DISTVERSION changes, but I didn't. The new changes are all there (the check for the distfile and so...). I had to expand the whole file to see it in the review.

How is this broken? I'm sure I'm missing something here... :S

Arrrghhh... never mind. I saw the problem.

fernape updated this revision to Diff 43852.Jun 15 2018, 9:32 PM

Unbreak the port by setting the proper DISTNAME

Harbormaster completed remote builds in B17318: Diff 43852.Jun 15 2018, 9:32 PM
tcberner added inline comments.Jun 16 2018, 12:39 PM
sysutils/storcli/Makefile
33 ↗(On Diff #43852)

^ it would probably make sense to reuse ${DISTNAME} or ${DISTFILES} here as to not retype the whole 16-digit crazyness .

fernape updated this revision to Diff 43904.Jun 16 2018, 4:07 PM

Use DISTNAME instead of repeating the same horrible version number.

Harbormaster completed remote builds in B17346: Diff 43904.Jun 16 2018, 4:07 PM
fernape marked an inline comment as done.Jun 16 2018, 4:08 PM
fernape added a comment.Jun 19 2018, 8:18 PM

Does the-horrible-version-number port update look good? :-)

tcberner added inline comments.Jun 20 2018, 4:29 AM
sysutils/storcli/Makefile
33 ↗(On Diff #43904)

^ ${EXTRACT_SUFX} instead of .zip?

33 ↗(On Diff #43904)

^ no <tab> after =

35 ↗(On Diff #43904)

^ missing <tab> after =

fernape updated this revision to Diff 44152.Jun 20 2018, 3:53 PM
  • Add missing tabs
  • Use ${EXTRACT_SUFX} where appropriate
Harbormaster completed remote builds in B17482: Diff 44152.Jun 20 2018, 3:53 PM
fernape marked 3 inline comments as done.Jun 20 2018, 3:55 PM
tcberner requested changes to this revision.Jun 21 2018, 5:44 PM
tcberner added inline comments.
sysutils/storcli/Makefile
24 ↗(On Diff #44152)

'^ you seem to have lost a \n

This revision now requires changes to proceed.Jun 21 2018, 5:44 PM
fernape updated this revision to Diff 44246.Jun 21 2018, 5:56 PM

Add missing \n !! :S

Harbormaster completed remote builds in B17519: Diff 44246.Jun 21 2018, 5:56 PM
tcberner accepted this revision.Jun 21 2018, 6:29 PM

Looks good now. -- You can commit it, if the maintainer is fine with it too.

This revision is now accepted and ready to land.Jun 21 2018, 6:29 PM
Closed by commit rP473045: sysutils/storcli: Update to 7.5 (authored by fernape). · Explain WhyJun 22 2018, 3:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
storcli/
28 lines
6 lines

Diff 44305

View Options

head/sysutils/storcli/Makefile

Loading...
View Options

head/sysutils/storcli/distinfo

Loading...