Page MenuHomeFreeBSD

sysutils/storcli: update to 7.5
ClosedPublic

Authored by fernape on Jun 12 2018, 5:22 PM.
Tags
None
Referenced Files
F167067090: D15779.id43904.diff
Tue, Aug 18, 8:33 PM
F167065673: D15779.id43660.diff
Tue, Aug 18, 8:31 PM
F167063725: D15779.id44246.diff
Tue, Aug 18, 8:26 PM
F167063116: D15779.diff
Tue, Aug 18, 8:25 PM
F167062211: D15779.id43852.diff
Tue, Aug 18, 8:23 PM
F167054911: D15779.id44305.diff
Tue, Aug 18, 8:06 PM
F167054814: D15779.id44152.diff
Tue, Aug 18, 8:06 PM
Unknown Object (File)
Sat, Aug 8, 5:13 PM
Subscribers

Details

Summary

Sent by maintainer via PR 228777

This version needs to be downloaded manually after accepting the license agreement.

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.1 OK (light as I don't have a RAID config)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17519
Build 17342: arc lint + arc unit

Event Timeline

sysutils/storcli/Makefile
4

oO

Using a sane number terminology.

Note that in the web site, the version is advertised as 7.5.
I would keep the .504 revision number in case there are future revisions.

Your last change looks broken :)

Trying to fix previuos arc diff update...

I thought I uploaded only the DISTVERSION changes, but I didn't. The new changes are all there (the check for the distfile and so...). I had to expand the whole file to see it in the review.

How is this broken? I'm sure I'm missing something here... :S

I thought I uploaded only the DISTVERSION changes, but I didn't. The new changes are all there (the check for the distfile and so...). I had to expand the whole file to see it in the review.

How is this broken? I'm sure I'm missing something here... :S

Arrrghhh... never mind. I saw the problem.

Unbreak the port by setting the proper DISTNAME

sysutils/storcli/Makefile
33

^ it would probably make sense to reuse ${DISTNAME} or ${DISTFILES} here as to not retype the whole 16-digit crazyness .

Use DISTNAME instead of repeating the same horrible version number.

Does the-horrible-version-number port update look good? :-)

sysutils/storcli/Makefile
33

^ ${EXTRACT_SUFX} instead of .zip?

33

^ no <tab> after =

35

^ missing <tab> after =

  • Add missing tabs
  • Use ${EXTRACT_SUFX} where appropriate
tcberner added inline comments.
sysutils/storcli/Makefile
26

'^ you seem to have lost a \n

This revision now requires changes to proceed.Jun 21 2018, 5:44 PM

Looks good now. -- You can commit it, if the maintainer is fine with it too.

This revision is now accepted and ready to land.Jun 21 2018, 6:29 PM
This revision was automatically updated to reflect the committed changes.