Page MenuHomeFreeBSD
Differential D15785

Handle case when the PCAP file is not set in tcpdump
ClosedPublic
Actions

Authored by • hselasky on Jun 13 2018, 7:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 26 2024, 5:07 PM
Unknown Object (File)
Feb 15 2024, 12:27 AM
Unknown Object (File)
Jan 12 2024, 8:48 PM
Unknown Object (File)
Dec 20 2023, 3:19 AM
Unknown Object (File)
Dec 17 2023, 6:07 PM
Unknown Object (File)
Sep 10 2023, 2:09 AM
Unknown Object (File)
Jul 15 2023, 8:29 AM
Unknown Object (File)
Jul 1 2023, 4:53 AM
View All 15 Files
Subscribers
imp
menyy_mellanox.com
oshogbo

Details

Reviewers
slavash
emaste
oshogbo
Summary

Some libpcap backends don't set the PCAP file number.
Make sure we don't trigger a fault when this file number is not set when CASPER and CAPSICUM is enabled.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 17624

Event Timeline

• hselasky created this revision.Jun 13 2018, 7:52 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 13 2018, 7:52 AM
Harbormaster completed remote builds in B17226: Diff 43696.Jun 13 2018, 7:52 AM
• hselasky added a reviewer: emaste.Jun 13 2018, 11:22 AM
oshogbo added a subscriber: oshogbo.Jun 19 2018, 8:51 PM

Can you provide any test case for that?

contrib/tcpdump/tcpdump.c
2073

VFileName at this point must be equals to NULL.

• hselasky updated this revision to Diff 44142.Jun 20 2018, 9:11 AM

Update as per comment.

Harbormaster completed remote builds in B17477: Diff 44142.Jun 20 2018, 9:11 AM
• hselasky marked an inline comment as done.Jun 20 2018, 9:13 AM

Can you provide any test case for that?

tcpdump -i mlx5_0

Given you have a mlx5 compatible PCI device and mlx5en/mlx5ib loaded.

• hselasky added a comment.Jun 25 2018, 7:37 AM

Ping.

• hselasky added a reviewer: menyy_mellanox.com.Jun 25 2018, 7:39 AM
• hselasky updated this revision to Diff 44456.Jun 26 2018, 9:57 AM

Simplify patch.

Harbormaster completed remote builds in B17624: Diff 44456.Jun 26 2018, 9:57 AM
• hselasky removed a reviewer: menyy_mellanox.com.Jun 26 2018, 9:57 AM
• hselasky added a subscriber: menyy_mellanox.com.
oshogbo accepted this revision.Jun 26 2018, 8:06 PM
oshogbo added inline comments.
contrib/tcpdump/tcpdump.c
2073

I think I would just do that in first case. Because the other cansandbox depends on the HAVING CASPER or not.
Otherwise LGTM.

This revision is now accepted and ready to land.Jun 26 2018, 8:06 PM
emaste added a comment.Aug 1 2018, 1:17 PM

Ping

• hselasky added a comment.Aug 1 2018, 2:01 PM

@emaste : Stuck here for review:
https://github.com/the-tcpdump-group/tcpdump/pull/687

• hselasky closed this revision.Oct 23 2018, 10:43 AM

Change was submitted to -current a while ago:
https://svnweb.freebsd.org/changeset/base/338613

Revision Contents
Changeset List

PathSize
contrib/
tcpdump/
5 lines

Diff 44456

View Options

contrib/tcpdump/tcpdump.c

Loading...