Page MenuHomeFreeBSD

Correct link metadata created when installing with -DNO_ROOT.
ClosedPublic

Authored by brooks on Jun 15 2017, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 1:03 PM
Unknown Object (File)
Dec 22 2023, 11:24 PM
Unknown Object (File)
Dec 5 2023, 7:02 PM
Unknown Object (File)
Dec 4 2023, 5:53 AM
Unknown Object (File)
Nov 10 2023, 11:43 AM
Unknown Object (File)
Nov 9 2023, 6:38 AM
Unknown Object (File)
Nov 6 2023, 10:27 PM
Unknown Object (File)
Oct 30 2023, 4:39 AM
Subscribers

Details

Summary

Explicitly specify owner/group/mode metadata when creating links.

More consistently use INSTALL_SYMLINK to install symlinks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Add an INSTALL_MLINK to install manpage links.
  • Add an INSTALL_MLINK to install manpage links.

With this change, I've verified the result builds working images. Some more testing required on releases.

At least update bsd.README too please. Then +1 from me.

share/mk/bsd.own.mk
205–210 ↗(On Diff #29736)

Can you please add these to share/mk/bsd.README?

217 ↗(On Diff #29736)

Can you maybe add a comment above MLINK for it being MANPAGE-specific? Doesn't feel obvious like the MHRDLINK one is.

share/mk/bsd.prog.mk
285 ↗(On Diff #29736)

I feel like you should have LINK{OWN|GRP}= here too. It's a coincidence that they default to ${BIN*} today and may not tomorrow. I'm not strong on this opinion though.

This revision now requires changes to proceed.Jun 19 2017, 5:15 PM

I'll submit a revised version shortly. I think I've got a test plan for release tar balls so I'll be trying that as well.

share/mk/bsd.own.mk
205–210 ↗(On Diff #29736)

I've added them at the top of this file. I'll try to scatter these in the right places. It does feel like bsd.README's coverage of bsd.own.mk is lacking most of the contents.

217 ↗(On Diff #29736)

In the changes I'm about to push I've changed the M prefix to MAN which should reduce confusion. I'm also adding a similar INSTALL_LIBSYMLINK to deal with an issue in /sbin/geom

share/mk/bsd.prog.mk
285 ↗(On Diff #29736)

I debated this myself and I'll go with your suggestion here.

brooks edited edge metadata.
  • More cleanups of link permissions.
  • The geom classes build libraries, but install links to programs so
This revision is now accepted and ready to land.Jun 19 2018, 6:24 PM
This revision now requires review to proceed.Jun 28 2018, 10:43 PM
This revision is now accepted and ready to land.Jun 28 2018, 11:12 PM
This revision was automatically updated to reflect the committed changes.