Explicitly specify owner/group/mode metadata when creating links.
More consistently use INSTALL_SYMLINK to install symlinks
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10022 Build 10448: arc lint + arc unit
Event Timeline
Comment Actions
With this change, I've verified the result builds working images. Some more testing required on releases.
Comment Actions
At least update bsd.README too please. Then +1 from me.
| share/mk/bsd.own.mk | ||
|---|---|---|
| 217–228 | Can you please add these to share/mk/bsd.README? | |
| 230 | Can you maybe add a comment above MLINK for it being MANPAGE-specific? Doesn't feel obvious like the MHRDLINK one is. | |
| share/mk/bsd.prog.mk | ||
| 285 | I feel like you should have LINK{OWN|GRP}= here too. It's a coincidence that they default to ${BIN*} today and may not tomorrow. I'm not strong on this opinion though. | |
Comment Actions
I'll submit a revised version shortly. I think I've got a test plan for release tar balls so I'll be trying that as well.
| share/mk/bsd.own.mk | ||
|---|---|---|
| 217–228 | I've added them at the top of this file. I'll try to scatter these in the right places. It does feel like bsd.README's coverage of bsd.own.mk is lacking most of the contents. | |
| 230 | In the changes I'm about to push I've changed the M prefix to MAN which should reduce confusion. I'm also adding a similar INSTALL_LIBSYMLINK to deal with an issue in /sbin/geom | |
| share/mk/bsd.prog.mk | ||
| 285 | I debated this myself and I'll go with your suggestion here. | |
Comment Actions
- More cleanups of link permissions.
- The geom classes build libraries, but install links to programs so