By using bmake's multivariable for loops we can simplify a bit
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
etc/Makefile | ||
---|---|---|
367 โ | (On Diff #9442) | Adding DESTDIR in here early seems wrong. It looks like it will cause line 369 to go from older {DISTBASE}{_d} to newer {DISTBASE}{DESTDIR}{_d} rather than expected {DESTDIR}{DISTBASE}{_d} done later. It also messes with the sed line for the metalog and adds in {DESTDIR} where it wasn't before. |
etc/Makefile | ||
---|---|---|
367 โ | (On Diff #9442) | Good catch oups I'll fix |
I'm unclear on our position on bmake in head. The meta mode merge pretty much nailed fmake in the coffin, but imp seemed to think we could or should still support fmake in some situations. I forget what he said exactly.
I would prefer we only support bmake. I think given it is the default make in 10 there is not much reason to support fmake at this point.
I am not suggesting your change shouldn't go in, there's no reason it shouldn't IMO as we use the same .for X Y elsewhere now and bmakeisms all over.