Minor changes are necessary to make this processor-independent, but
moving the file out of x86 and into common is the first step (so others
don't add /more/ x86-isms).
Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>
Paths
| Differential D29042 Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:34 PM.
Details
Summary Minor changes are necessary to make this processor-independent, but Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>
Diff Detail
Event TimelineHerald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2021, 4:34 PM2021-03-03 16:34:41 (UTC+0) ehem_freebsd_m5p.com requested review of this revision.Mar 3 2021, 4:34 PM2021-03-03 16:34:41 (UTC+0) Harbormaster completed remote builds in B37542: Diff 85060.Mar 3 2021, 4:34 PM2021-03-03 16:34:46 (UTC+0) ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository. ehem_freebsd_m5p.com updated this revision to Diff 85149.Mar 4 2021, 5:25 PM2021-03-04 17:25:33 (UTC+0) Comment ActionsYeah, I've got no idea what-so-ever why one might feel xenpv.c should be Like so many comments, that one is pretty obvious when suggested. Harbormaster completed remote builds in B37579: Diff 85149.Mar 4 2021, 5:25 PM2021-03-04 17:25:50 (UTC+0) Comment Actions
I'm confused by the text above, do you agree it should be in a bus/ directory or not? There are Xen devices (xen timer, xenstore) that attach to the xenpv bus. Comment Actions
My actual view should be reflected in the diff update. I went ahead and moved as requested. Felt like a 20/20 hindsight comment, it does look like a bus since it has devices attached and as such the idea is entirely reasonable. ehem_freebsd_m5p.com retitled this revision from xen: move x86/xen/xenpv.c to dev/xen/xenpv.c to xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.Mar 4 2021, 9:48 PM2021-03-04 21:48:07 (UTC+0) ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository. This revision is now accepted and ready to land.Mar 25 2021, 4:02 PM2021-03-25 16:02:43 (UTC+0) ehem_freebsd_m5p.com added a subscriber: julien_xen.org.Mar 30 2021, 6:42 PM2021-03-30 18:42:37 (UTC+0) ehem_freebsd_m5p.com added a parent revision: D30228: x86/xen: remove PVHv1 code.Jul 6 2021, 2:10 AM2021-07-06 02:10:39 (UTC+0) ehem_freebsd_m5p.com added a parent revision: D29873: etc/ttys: add the xen console.Jul 15 2021, 5:12 AM2021-07-15 05:12:09 (UTC+0) Closed by commit rGa48f7ba444fd: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c (authored by julien_xen.org, committed by royger). · Explain WhyJul 28 2021, 3:28 PM2021-07-28 15:28:20 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 92865 sys/conf/files
sys/conf/files.x86
sys/dev/xen/bus/xenpv.c
sys/x86/xen/xenpv.c
|