Address panic with PRR due to missed initialization of recover_fs
ClosedPublic
Actions

Authored by rscheff on Jan 12 2021, 11:28 AM.

Details

Reviewers

rrs
kbowling
tuexen
jtl
gnn
jmg
manu

Group Reviewers

transport
manpages

Commits

rGbc7ee8e5bc55: Address panic with PRR due to missed initialization of recover_fs

Summary

When using the base stack in conjunction with RACK, it appears that
infrequently, ++tp->t_dupacks is instantly larger than tcprexmtthresh.

This leaves the recover flightsize (sackhint.recover_fs) uninitialized,
leading to a div/0 panic.

Address this by properly initializing the variable just prior to first
use, if it is not properly initialized.

In order to prevent stale information from a prior recovery to
negatively impact the PRR calculations in this event, also clear
recover_fs once loss recovery is finished.

Finally, improve the readability of the initialization of recover_fs
when t_dupacks == tcprexmtthresh by adjusting the indentation and
using the max(1, snd_nxt - snd_una) macro.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36197
Build 33086: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 12 2021, 11:28 AM

Herald added a reviewer: transport. · View Herald TranscriptJan 12 2021, 11:28 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jan 12 2021, 11:28 AM

Harbormaster completed remote builds in B36138: Diff 82148.Jan 12 2021, 11:29 AM

kbowling accepted this revision.Jan 12 2021, 6:52 PM

This revision is now accepted and ready to land.Jan 12 2021, 6:52 PM

rrs accepted this revision.Jan 14 2021, 2:17 PM

init recover_fs in tcp_default_fb_init() if switching stacks during fastrecovery

This revision now requires review to proceed.Jan 14 2021, 3:19 PM

Herald added a reviewer: gnn. · View Herald TranscriptJan 14 2021, 3:19 PM

Herald added a reviewer: jmg. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: manpages. · View Herald Transcript

Herald added subscribers: linuxkpi, bcran, bz and 5 others. · View Herald Transcript

Harbormaster completed remote builds in B36197: Diff 82264.Jan 14 2021, 3:19 PM

Looks like the wrong diff was uploaded

fixing Diff

Harbormaster completed remote builds in B36198: Diff 82265.Jan 14 2021, 3:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2021, 11:22 AM

Closed by commit rGbc7ee8e5bc55: Address panic with PRR due to missed initialization of recover_fs (authored by rscheff). · Explain Why

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rGbc7ee8e5bc55: Address panic with PRR due to missed initialization of recover_fs.

@gnn: Added initialization code for when TCP stacks get changed mid-stream, as per discussion in the @freebsd-transport call last thursday.

rscheff mentioned this in D28326: TCP PRR: Patch div/0 in tcp_prr_partialack.Jan 24 2021, 9:26 PM

rscheff mentioned this in rG6a376af0cd21: TCP PRR: Patch div/0 in tcp_prr_partialack.Jan 26 2021, 3:09 PM

rscheff mentioned this in rG76dd854f47f4: TCP PRR: Patch div/0 in tcp_prr_partialack.Jan 29 2021, 11:02 AM

Revision Contents
Changeset List

Path

Size

lib/

libcasper/

libcasper.h

25 lines

libthr/

thread/

thr_malloc.c

13 lines

share/

mk/

src.opts.mk

1 line

stand/

efi/

libefi/

Makefile

1 line

efi_console.c

73 lines

loader/

4 lines

33 lines

4 lines

50 lines

sys/

amd64/

sgx/

sgx_linux.c

3 lines

arm64/

include/

pcpu.h

17 lines

cddl/

contrib/

opensolaris/

uts/

common/

sys/

dtrace.h

13 lines

dev/

dtrace/

aarch64/

dtrace_subr.c

6 lines

fbt/

aarch64/

fbt_isa.c

31 lines

riscv/

fbt_isa.c

13 lines

compat/

freebsd32/

freebsd32_ioctl.c

2 lines

freebsd32_misc.c

2 lines

linux/

7 lines

2 lines

1 line

10 lines

linuxkpi/

common/

include/

linux/

pci.h

96 lines

src/

linux_pci.c

75 lines

linux_shrinker.c

125 lines

conf/

2 lines

2 lines

3 lines

3 lines

3 lines

2 lines

dev/

aac/

aac_linux.c

3 lines

aacraid/

aacraid_linux.c

2 lines

amr/

amr_linux.c

2 lines

cxgbe/

cxgbei/

icl_cxgbei.c

2 lines

dwwdt/

dwwdt.c

366 lines

filemon/

filemon_wrapper.c

2 lines

gpio/

gpioc.c

4 lines

if_wg/

module/

module.c

3 lines

ipmi/

ipmi_linux.c

3 lines

iscsi/

icl_soft.c

2 lines

iscsi_initiator/

iscsi.c

4 lines

mfi/

mfi_linux.c

2 lines

mlx4/

mlx4_core/

mlx4_main.c

2 lines

mlx5/

mlx5_core/

mlx5_main.c

6 lines

mrsas/

mrsas_linux.c

2 lines

pci/

pci.c

22 lines

pcivar.h

1 line

tdfx/

tdfx_linux.c

2 lines

usb/

net/

if_ure.c

49 lines

if_urereg.h

9 lines

fs/

fdescfs/

fdesc_vnops.c

2 lines

nfsclient/

nfs_clport.c

2 lines

nfsserver/

nfs_nfsdport.c

2 lines

i386/

linux/

imgact_linux.c

6 lines

kern/

2 lines

71 lines

3 lines

3 lines

2 lines

2 lines

3 lines

26 lines

2 lines

7 lines

12 lines

3 lines

36 lines

52 lines

7 lines

modules/

Makefile

2 lines

dwwdt/

Makefile

7 lines

linuxkpi/

Makefile

3 lines

net/

if_tuntap.c

32 lines

netinet/

sctp_syscalls.c

4 lines

tcp_input.c

20 lines

tcp_subr.c

10 lines

netinet6/

in6_ifattach.c

5 lines

riscv/

pmap.c

18 lines

rpc/

rpcsec_tls/

rpctls_impl.c

2 lines

security/

mac/

mac_syscalls.c

6 lines

mac_veriexec/

mac_veriexec.c

4 lines

sys/

filedesc.h

7 lines

namei.h

2 lines

param.h

2 lines

ufs/

ffs/

ffs_alloc.c

2 lines

vm/

vm_map.h

7 lines

vm_map.c

45 lines

vm_mmap.c

18 lines

x86/

busdma_bounce.c

2 lines

	sys/	compat/

	linuxkpi/

	common/	include/	asm/	fpu/
		stand/	efi/	loader/

	api.h
	framebuffer.h

58 lines

	common/	include/	linux/
	stand/	efi/	loader/

	shrinker.h
	framebuffer.h

36 lines

	linuxkpi/	common/	src/
	stand/	efi/	loader/

	linux_fpu.c
	framebuffer.h

40 lines

tools/

netmap/

pkt-gen.c

6 lines

usr.bin/

elfctl/

elfctl.1

6 lines

elfctl.c

13 lines

usr.sbin/

wpa/

Makefile.crypto

31 lines

hostapd/

Makefile

4 lines

wpa_supplicant/

Makefile

2 lines

Commit	Tree	Parents	Author	Summary	Date
bf8283b8bb02	6fdf649809b3	495cadc48f5c	Richard Scheffenegger	init recover_fs in tcp_default_fb_init() if switching stacks during fastrecovery	Jan 14 2021, 3:13 PM
495cadc48f5c	0bb53fe4b4db	6722bc5b939a 6b4d80e71e5a	Richard Scheffenegger	Merge branch 'master' into D28114_fix_prr	Jan 13 2021, 8:38 PM
6b4d80e71e5a	d8ca230c7afe	dcfcf03d9486 fdaf9cb942d9	Richard Scheffenegger	Merge remote-tracking branch 'freebsd/main'	Jan 13 2021, 6:36 PM
fdaf9cb942d9	d8ca230c7afe	6003bf9290cd	Toomas Soome	Revert "loader.efi: disable workaround for serial console on non-x86" (Show More…)	Jan 13 2021, 6:18 PM
6003bf9290cd	bbcacebe635d	0a05676b44ae	Emmanuel Vadot	dwwdt: Add PNP info for the driver	Jan 13 2021, 5:41 PM
0a05676b44ae	ad7c6a3993ad	98c15d4dc284	Emmanuel Vadot	Add driver for Synopsys Designware Watchdog timer. (Show More…)	Jan 13 2021, 5:23 PM
98c15d4dc284	9ad4ef144d71	63c858a04d56	Toomas Soome	loader.efi: initial terminal size should base on UEFI terminal size (Show More…)	Jan 13 2021, 5:05 PM
63c858a04d56	f0d1a3cbe3bd	594389d1de64	Andrew Turner	Switch the arm64 pcpu to a global register variable (Show More…)	Jan 11 2021, 3:43 PM
594389d1de64	ff90257f3ec5	f9d85a082181	Andrew Turner	Create a stack frame when needed in the arm64 kernel (Show More…)	Jan 12 2021, 2:18 PM
f9d85a082181	959c12346e5e	ef23df135468	Konstantin Belousov	Revert "x86 busdma_bounce: do not make assumptions about alignment of malloc(9)… (Show More…)	Jan 13 2021, 3:40 PM
ef23df135468	2d605b5e7f09	5753be8e432f	Mateusz Guzik	vfs: set NC_KEEPPOSENTRY alongside NOCACHE when creating a file (Show More…)	Jan 13 2021, 2:53 PM
5753be8e432f	3bf22a1a8eb6	8f54940f019c	Mateusz Guzik	fd: add refcount argument to falloc_noinstall (Show More…)	Jan 13 2021, 2:16 PM
8f54940f019c	7cabf2651b2a	895ad33784e0	Konstantin Belousov	x86 busdma_bounce: do not make assumptions about alignment of malloc(9) results. (Show More…)	Jan 11 2021, 11:42 PM
895ad33784e0	232e3d303f95	f2a7b434b30e	Konstantin Belousov	x86 budma_bounce: style. (Show More…)	Jan 11 2021, 11:42 PM
f2a7b434b30e	0cc42ca4c42e	ec2700e01532	Hans Petter Selasky	Variable declarations are since C99 and r363250 allowed inside for-loops. (Show More…)	Jan 13 2021, 11:27 AM
ec2700e01532	e8ba87b07809	a6b7689718d2	Edward Tomasz Napierala	linux: mute the "unsupported prctl option 23" warnings (Show More…)	Jan 12 2021, 2:47 PM
a6b7689718d2	98b6d0182860	e58c8da0683d	Alexander V. Chernikov	Remove redundant rtinit() calls from tuntap. (Show More…)	Jan 11 2021, 11:31 PM
e58c8da0683d	ab991e7cdaa6	a339b4223a4f	Alexander V. Chernikov	Map IPv6 link-local prefix to the link-local ifa. (Show More…)	Jan 12 2021, 11:14 PM
a339b4223a4f	ae4eb6484de0	bafb68265672	Edward Tomasz Napierala	linux: bump the default version from 3.10.0 to 3.17.0 (Show More…)	Jan 13 2021, 9:59 AM
bafb68265672	7b4fa0d4a26b	f6d95a01103a	Hans Petter Selasky	Fix for off-by-one in GPIO driver after r368585. While at it declare the… (Show More…)	Jan 12 2021, 5:46 PM
f6d95a01103a	c83991de4330	5171310e661d	Ed Maste	elftcl: add -i flag to ignore unknown flags (Show More…)	Jan 13 2021, 3:24 AM
5171310e661d	f88f48173270	530b699a62ad	Mateusz Guzik	vfs: use finstall_refed in openat (Show More…)	Jan 12 2021, 4:11 PM
530b699a62ad	584bb2024893	4faa375cdd4e	Mateusz Guzik	fd: add finstall_refed (Show More…)	Jan 12 2021, 4:05 PM
4faa375cdd4e	e35ba0188706	7c5a624afae4	Mateusz Guzik	fd: provide a dedicated closef variant for unix socket code (Show More…)	Jan 12 2021, 3:13 PM
7c5a624afae4	57f901081e63	0659df6faddf	Adrian Chadd	[wpa] Add support for hostapd/wpa_supplicant when WITHOUT_CRYPT=YES is enabled. (Show More…)	Jan 4 2021, 8:39 PM
0659df6faddf	c4f516ac9224	d89e1db5a331	Konstantin Belousov	vm_map_protect: allow to set prot and max_prot in one go. (Show More…)	Jan 12 2021, 12:43 PM
d89e1db5a331	eebe2c336a50	d7493759fbfb	Mitchell Horne	if_wg: fix modules load on !x86 (Show More…)	Jan 12 2021, 9:38 PM
d7493759fbfb	43dc95f14fa2	f6dc363f6dd2	Vincenzo Maffione	netmap: pkt-gen: fix offset hex formatting (Show More…)	Jan 12 2021, 10:02 PM
f6dc363f6dd2	3b9fa28e4df8	d2ceee38ca26	Rick Macklem	nfs-over-tls: handle res.gid.gid_val correctly for memory allocation (Show More…)	Jan 12 2021, 9:59 PM
d2ceee38ca26	76c855d177a9	6e5baec33c10	Mariusz Zaborski	casper: convert macros to inline functions (Show More…)	Jan 12 2021, 6:38 PM
6e5baec33c10	43256b412ed0	0628f6835702	Hans Petter Selasky	Fix for use-after-free in if_ure(4) driver. (Show More…)	Jan 12 2021, 1:13 PM
0628f6835702	2c5a457cbc3b	70ba77706dab	mhorne	riscv pmap: add some pv list assertions (Show More…)	Nov 4 2020, 5:51 PM
70ba77706dab	0ad11bc4be6f	cdb62ab74ee0	Mateusz Guzik	vfs: extend vfs:namei:lookup:return probe with nameidata	Jan 12 2021, 1:09 PM
cdb62ab74ee0	1f0850e494c2	6b3a9a0f3d2c	Mateusz Guzik	vfs: add NDFREE_NOTHING and convert several NDFREE_PNBUF callers (Show More…)	Jan 12 2021, 11:36 AM
6b3a9a0f3d2c	8a090da47623	c00ec4dab276	Mateusz Guzik	Convert remaining cap_rights_init users to cap_rights_init_one (Show More…)	Jan 12 2021, 12:11 PM
c00ec4dab276	f31ed86d5e42	d0df1a2d54dc	Andrew Turner	Handle using a sub instruction in the arm64 fbt (Show More…)	Jan 12 2021, 12:14 PM
d0df1a2d54dc	44226990dc22	35a39dc5b349	Andrew Turner	Only allow a store through sp in the arm64 fbt (Show More…)	Jan 12 2021, 11:37 AM
35a39dc5b349	32cfb5fee3b8	11d62b6f31ab	Emmanuel Vadot	Bump __FreeBSD_version after linuxkpi changes	Jan 12 2021, 11:07 AM
11d62b6f31ab	a365c3f0ec12	2c95fb753fb2	Emmanuel Vadot	linuxkpi: add kernel_fpu_begin/kernel_fpu_end (Show More…)	Jan 12 2021, 11:02 AM
2c95fb753fb2	3905baf593a9	105a37cac76b	Emmanuel Vadot	linuxkpi: Add shrinker support (Show More…)	Dec 22 2020, 6:15 PM
105a37cac76b	d93f05ded14b	8517a547a052	Emmanuel Vadot	linuxkpi: Add more pci functions needed by DRM (Show More…)	Dec 10 2020, 4:47 PM
8517a547a052	64572a07835c	8b1839548750	Emmanuel Vadot	pci: Add pci_find_class_from (Show More…)	Dec 10 2020, 5:38 PM
6722bc5b939a	aaf2efe671cc	dcfcf03d9486	Richard Scheffenegger	address panic with PRR due to missed initialization of recover_fs	Jan 12 2021, 11:15 AM
8b1839548750	07a1a66de4a4	50180d2b52cc	Toomas Soome	loader.efi: disable workaround for serial console on non-x86 (Show More…)	Jan 11 2021, 8:07 PM
50180d2b52cc	d8ec324718c7	85d028223bc2	Toomas Soome	loader.efi: reworked framebuffer setup (Show More…)	Jan 11 2021, 9:54 PM
85d028223bc2	72b748fcf5e4	57f22c828ec0	Konstantin Belousov	libthr malloc: support recursion on thr_malloc_umtx. (Show More…)	Jan 12 2021, 9:02 AM
57f22c828ec0	a338d0366a4b	513320c0f112	Konstantin Belousov	sigfastblock: do not skip cursig/postsig loop in ast() (Show More…)	Jan 11 2021, 1:22 AM
513320c0f112	f32ab752412f	f74397658390	Konstantin Belousov	sigfastblock_setpend(): do not set PEND user flag unless TDP_SIGFASTPENDING is… (Show More…)	Jan 11 2021, 5:07 PM
f74397658390	cf66764ce4e7	44121a0fbee0	Kristof Provost	dtrace: Blacklist riscv exception handlers for fbt (Show More…)	Jan 11 2021, 8:23 PM