We could be getting them for any number of reasons, it all depends on the slaves on the bus and how they behave. It's an optional signal though, so since we don't handle it we don't need to spam the kernel message buffer about it.

• Remove unwanted leading space in Version.map

This works in pfSense as expected, our pfsense and libbe PHP modules, when both loaded, do not hit errors due to symbols from one of libnv or libnvpair being aliased.

• Remove orphaned empty line in libnvpair makefile

• Remove libnvpair symbol versioning, obviated by libnv namespacing and versioning

I haven't yet done a full build against main with this patch, but versioning alone solved our linking issues so I don't expect adding differentiation to symbol names to interfere with that. I'll try to get that done today.

In D35144#796716, @kp wrote:

I've only looked at the function briefly, but it seems as if it's doing a recursive merge sort between [0, Len -1] and [len], so it should be possible to make that a lot faster, even with a naive bubble sort. I'd actually expect a bubble sort to work okay, because we're probably going to get the list sorted per interface already, so most sort work will be local. (Although this is mostly speculation, I've not dug very deep here.)

• Add whitespace between macros and surrounding ifdef lines

I think my biggest concern as of right now is whether I did the Right Thing with the msgio symbols. I deemed them to not be part of the interface and therefore made them local symbols without a namespace prefix.

• Correct year on copyright

Add namespacing to libnv, don't export msgio funcs

Remove default case from address family switch in pf_test_eth_rule dummynet handling entirely

Something is really wrong when I run the ether:anchor test, it immediately traps:

• pf: Protect timestamp assignment in critical section, fix null pointer dereference

• pf: Assign timestamp value unconditionally

• pf: Assign timestamp value unconditionally

• pf: Remove no longer needed include of timeconv.h from libpfctl.c

• pf: Make rule timestamps cpu local, update only on change

• pf: Make rule timestamps cpu local, update only on change

• pf: Add per-rule timestamps for rule and eth_rule
• pf: Switch timestamp to time_second and remove last_active from libpfctl structs
• pf: Make rule timestamps cpu local, update only on change