Watchers

  • This project does not have any watchers.

Recent Activity

Mar 15 2018

cjysqpb_hotmail.com added a comment to D7697: Add AER register reporting support via sysctl.
In D7697#197154, @imp wrote:

I'm reworking things to allow two types of usage. One by client devices that want to 'poll' their AER status and keep counts / records of what happened on that device. The second form is only on Root Complexes and Root Error Collection devices that collect records there (and maybe for root complexes walks the tree polling all the agents and endpoints involved to complete the record, if possible).

Mar 15 2018, 10:21 PM · Contributor Reviews (base), PCI

Dec 5 2017

imp added a comment to D7813: Rudimentary AER reading code for ddb(4).

Errr, my cleanup is runtime, not ddb time, sorry for the confusion. I've not grabbed this code.

Dec 5 2017, 10:16 PM · PCI
imp added a comment to D7813: Rudimentary AER reading code for ddb(4).

I've cleaned up this code somewhat, but not completely. I need to reconnect it to an interrupt and then test it in machines that generate these errors...

Dec 5 2017, 10:15 PM · PCI
emaste added a comment to D7813: Rudimentary AER reading code for ddb(4).

I like the idea of having this support in ddb, but will defer to @jhb and @imp.

Dec 5 2017, 9:46 PM · PCI

Jun 30 2017

lwhsu changed the visibility for PCI.
Jun 30 2017, 6:38 PM

Feb 11 2017

imp requested changes to D7697: Add AER register reporting support via sysctl.

Some more comments based on first trying to use this code, and then trying to rework it.
While the code is decently written, there's a number of fundamental assumptions it makes that aren't reflective of the AER in the PCIe spec that require changes.
I've not looked at all at the userland test suite, so have no opinion on that.

Feb 11 2017, 4:41 PM · Contributor Reviews (base), PCI

Feb 6 2017

imp added a comment to D7697: Add AER register reporting support via sysctl.

After talking with John, these two reports are self-consistent. The bridge see one kind of thing going on (timeout) while the card sees something else (bad header so ignored).

Feb 6 2017, 10:12 PM · Contributor Reviews (base), PCI
imp added a comment to D7697: Add AER register reporting support via sysctl.

For example:
pciconf -bBlaec pcib5
pcib5@pci0:0:2:2: class=0x060400 card=0x083315d9 chip=0x6f068086 rev=0x01 hdr=0x01

  bus range  = 4-4
  window[1c] = type I/O Port, range 16, addr 0xf000-0xfff, disabled
  window[20] = type Memory, range 32, addr 0xfb500000-0xfb5fffff, enabled
  window[24] = type Prefetchable Memory, range 64, addr 0xfff00000-0xfffff, disabled
  cap 0d[40] = PCI Bridge card=0x083315d9
  cap 05[60] = MSI supports 2 messages, vector masks 
  cap 10[90] = PCI-Express 2 root port max data 256(256) ARI disabled
               link x4(x4) speed 2.5(8.0)
               slot 0 power limit 25000 mW surprise
  cap 01[e0] = powerspec 3  supports D0 D3  current D0
  ecap 000b[100] = Vendor 1 ID 2
  ecap 000d[110] = ACS 1
  ecap 0001[148] = AER 1 0 fatal 1 non-fatal 2 corrected
  ecap 000b[1d0] = Vendor 1 ID 3
  ecap 0019[250] = PCIe Sec 1 lane errors 0
  ecap 000b[280] = Vendor 1 ID 5
  ecap 000b[300] = Vendor 1 ID 8
PCI-e errors = Correctable Error Detected
               Non-Fatal Error Detected
   Non-fatal = Completion Timeout
   Corrected = Replay Timer Timeout
               Advisory Non-Fatal Error
Feb 6 2017, 9:47 PM · Contributor Reviews (base), PCI
imp added inline comments to D7697: Add AER register reporting support via sysctl.
Feb 6 2017, 9:44 PM · Contributor Reviews (base), PCI
imp added a comment to D7697: Add AER register reporting support via sysctl.

For the commit, I'd suggest doing the injection tool (both userland and kernel) separate from the kernel changes to pcib.

Feb 6 2017, 9:19 PM · Contributor Reviews (base), PCI

Sep 7 2016

kib retitled D7813: Rudimentary AER reading code for ddb(4) from to Rudimentary AER reading code for ddb(4).
Sep 7 2016, 1:54 PM · PCI

Aug 29 2016

jhibbits retitled D7697: Add AER register reporting support via sysctl from to Add AER register reporting support via sysctl.
Aug 29 2016, 7:20 PM · Contributor Reviews (base), PCI

Jan 27 2016

rpaulo removed a member for PCI: rpaulo.
Jan 27 2016, 6:15 AM