bsdinstall: when installing UEFI, place the bootloader on all disks

[asomers]

Summary

Previously, bsdinstall would partition all disks used by the zroot
pool, but would only format and install the boot partition on one.

Reported by: Julien Cigar <[e-mail]> and many others
MFC after: 1 week
Sponsored by: Axcient

Test Plan

Running in production with mirrored zroot pools

[jrtc27]

usr.sbin/bsdinstall/scripts/bootconfig

182

UFS autopartitioning doesn't have a thing, so this glob will evaluate to a literal /dev/gpt/efiboot*. Encoding this ZFS specificity in here also seems a bit ugly.

[asomers]

usr.sbin/bsdinstall/scripts/bootconfig

182

UFS autopartitioning doesn't have a thing, so this glob will evaluate to a literal /dev/gpt/efiboot*. Encoding this ZFS specificity in here also seems a bit ugly.

Good point. We should check for a case like that. For that matter, is there anything to do here for UFS? Do we even support installing to gmirror+UFS ?

[jrtc27]

usr.sbin/bsdinstall/scripts/bootconfig

182

Only via manual partitioning as far as I know, at which point you'd need more infrastructure to mark any secondary ESPs which we just don't have an interface for.

[guest-jsollvander]

I see that bootconfig used to have code for adding ESPs to all ZFS/UFS boot disks, but it was removed in https://reviews.freebsd.org/D28897. @imp reviewed that one, maybe you could share your opinion here if we should bring parts of that code back? I think all disks that are configured as boot disks by the installer should a working ESP after installation. If the wrong boot disks die then you are left with a system without any ESPs at all.

[imp]

usr.sbin/bsdinstall/scripts/bootconfig

183

Where do we actually label things like this?
And isn't this super fragile?

190

This wins the award for the ugliest kludge to make this work.
I'd have been tempted to pass in mntpt at the very least and mount the alternatives on different mount points to avoid 'stacking' of the mount points which the cleanup routine wouldn't unwind.

[jrtc27]

usr.sbin/bsdinstall/scripts/bootconfig

183

See my comment above (zfsboot script)

[asomers]

• Add ESP to all ZFS boot disks, pretty edition

[asomers]

This latest version fixes the script with UFS, and makes the bootconfig script less ZFS-specific.

[asomers]

ping @jrtc27 does the latest version look better to you?

[linnemannr_gmail.com]

usr.sbin/bsdinstall/scripts/bootconfig

148–152

This seems unnecessary to me. We're not concerned with the actual number of devices (which can be gotten without a shell loop using wc maybe?), just that we have a plurality of them. This can be determined just by looking for whitespace in $ESPS.

[asomers]

• bsdinstall: all ESPs created by zfsboot should have a bootloader

[dvl]

To be clear: it wasn't me doing the following work, it was a colleague:

This problem bit us on a production server on this past Friday. The host had been recently updated from FreeBSD 14.0 to 14.1 - it had been rebooted multiple times since and during that update. On Friday morning, it did not come back from a reboot. Getting it back was troublesome. It was eventually discovered that one of the two boot drives was not 'intact'. While it had an EFI partition, that partition did not contain a filesystem. Once the filesystem was created and the files copied over (while booting from a live CD), we recovered the host and went on with our weekend.

[guest-jsollvander]

Sorry to bother people, but could we revive this review? I was recently talking to some people who noticed this the hard way and it would be great to get something merged that fixes it, even if it isn't perfect. I think this looks good enough and is definitely not "the ugliest kludge to make this work"