- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 21 2018
Remove unused declarations.
Move quirks form acpi part to common part.
Other than two notes I put inline, the patch looks fine to me.
- Add test for acct_success. Use sysctlbyname(3) to retrieve the accounting status
- Minor changes in auditctl_success test case cleanup
Merge the two parts of set child as traced
Looks good to me.
Sorry my miss operation.
- fix typo by arc
- repare from master file
Looks good to me.
Thanks -- will that be written down somewhere in the man page ? Who is selling EXL cards, because I've never found that ? And: What is LOM ?
Hmmm, I was more wondering if acpi_print_gas() simply needed updating in general for newer GAS parsing in newer ACPI revisions. If instead this is a specific hack just for this table then I don't think acpi_print_gas() needs adjusting. It might be nice to recognize the special case and print it as "MSR=" or some such if that isn't a pain to do. However, if that involves a lot of mess and manual GAS parsing code then the current approach is probably fine.
In D15927#337295, @pi wrote:Can you tell if the boards now accept foreign/unsupported SFP+ modules ? Is there a flag now for this
or does it still insist to only accept intel-branded SFP+ modules ?
Actually my one complaint is that you've added all of these other backends that we don't really support already right? That seems like maintenance burden for no benefit?
Jun 20 2018
Add patch to complex.h that was missing.
Can you tell if the boards now accept foreign/unsupported SFP+ modules ? Is there a flag now for this
or does it still insist to only accept intel-branded SFP+ modules ?
Any additional information that should be added to the man page? Some stats descriptions? iflib sysctls? More VF usage information?
Update to do several things:
Address feedback
I tested my change in a ports tree that had not been updated in a few hours then copied to the ports tree I use for committer work; I lost the race with r472884. I'll try to be more careful moving forward.
Update diff to not step on r472884 PY_FLAVOR change.
In D15937#337221, @kbowling wrote:I've deployed a variant of this widely at LLNW on the default stack as well. I think you can garbage collect sbsndptr() from the tree.