Page MenuHomeFreeBSD
Feed All Stories

Jun 20 2018

jpaetzel added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

For the local host name, it seems that truncating to 15-bytes is the right thing. For the server name, it's probably a bug if we are given a server name larger than 16 bytes and we should fail.

Jun 20 2018, 9:25 PM
kib added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..

You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.

Jun 20 2018, 9:25 PM
oshogbo created D15939: Simplify sandbox in ISCSI-ish tools..
Jun 20 2018, 9:22 PM
yuri committed rP472939: misc/cldr-emoji-annotation: Update 33.0.0.1 -> 33.0.0.2.
misc/cldr-emoji-annotation: Update 33.0.0.1 -> 33.0.0.2
Jun 20 2018, 9:15 PM
cem added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337247, @avg wrote:

Additionally, anything "interrupt thread" is completely irrelevant to interrupt filters that can also share an interrupt.

Jun 20 2018, 9:14 PM
cem added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337246, @avg wrote:
In D15905#337244, @cem wrote:

Maybe we could allocate independent ithreads for each handler on a shared interrupt source. I'm not sure what the ramifications of that are or if there is a good reason we do not already do that. It may just be that shared interrupts mostly date to the UP days.

This was implemented in the code that you recently removed (INTR_FILTER).

Jun 20 2018, 9:13 PM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337244, @cem wrote:
Jun 20 2018, 9:09 PM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337244, @cem wrote:
Jun 20 2018, 9:08 PM
avg added inline comments to D15905: safer wait-free iteration of shared interrupt handlers.
Jun 20 2018, 9:06 PM
cem added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337213, @avg wrote:

I am not sure what exactly you mean by this.
What kind of contention?

Jun 20 2018, 9:06 PM
brooks added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

Jun 20 2018, 9:03 PM
oshogbo created D15938: Introduce cap_signal..
Jun 20 2018, 9:01 PM
brooks updated the diff for D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
  • Per discussion in the PR, truncate the host name to 15 bytes.
Jun 20 2018, 8:59 PM
bdrewery accepted D11077: Add support for selectively enabling/disabling LLVM targets.

I'm sure it's quite stale now but I'm fine with it...

Jun 20 2018, 8:59 PM
matthew requested changes to D15930: textproc/py-qrcode: Update to 6.0.

What mat said. Always use PY_FLAVOR for python dependencies.

Jun 20 2018, 8:52 PM
kbowling accepted D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine.

I've deployed a variant of this widely at LLNW on the default stack as well. I think you can garbage collect sbsndptr() from the tree.

Jun 20 2018, 8:50 PM
jpaetzel added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

Jun 20 2018, 8:47 PM
ian accepted D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 20 2018, 8:44 PM
jhb added a comment to D15931: Add LPIT parsing to acpidump.

I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?

Once you have a commit bit the NFIT fix could just be committed directly to svn. Until then the pedantic approach would be to create two separate reviews, but as the NFIT part is trivial including it here's fine.

Jun 20 2018, 8:42 PM
jhb added a comment to D15931: Add LPIT parsing to acpidump.
In D15931#337135, @ben.widawsky_intel.com wrote:
In D15931#337133, @jhb wrote:

I am far from an expert on ACPI...

If the LPI residency counter is a Model Specific Register (MSR), it cannot be natively
described in an ACPI Generic Address Structure (GAS). Therefore it must be
described as Fixed Functional Hardware (FFH) with the GAS field requirements:

My understanding is that the FFH addresses have specific parsing based on the hardware and so the existing acpidump code doesn't bother trying to translate it. I looked into fixing that, but I wasn't sure it made sense. I can manually parse this one if you prefer.

Jun 20 2018, 8:41 PM
avg added a comment to D15905: safer wait-free iteration of shared interrupt handlers.
In D15905#337073, @cem wrote:

Sure, but they will already ping-pong the linked list walk between cores if there is contention there; might as well ping pong the real lock instead.

Jun 20 2018, 8:41 PM
gallatin accepted D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine.

I added Hans since it is mostly his code we are factoring out.

Jun 20 2018, 8:40 PM
gallatin added a reviewer for D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine: hselasky.
Jun 20 2018, 8:39 PM
rrs created D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine.
Jun 20 2018, 8:29 PM
brooks created D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 20 2018, 8:29 PM
brooks created D15935: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 20 2018, 8:25 PM
mat accepted D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 8:22 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add the version of the compat stubs I ment to add.
Jun 20 2018, 8:14 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add compat symbols returning ENOSYS.
Jun 20 2018, 8:13 PM
pi committed rP472938: databases/Makefile: re-add p5-Search-InvertedIndex.
databases/Makefile: re-add p5-Search-InvertedIndex
Jun 20 2018, 8:13 PM
thierry committed rP472937: Update CLDR to 33.1..
Update CLDR to 33.1.
Jun 20 2018, 8:05 PM
jbeich updated the diff for D15565: mail/thunderbird: update to 60.0.
  • Update to Beta 8 (including -i18n)
Jun 20 2018, 8:05 PM
hselasky committed rS335461: Permit the kernel environment to set an array of numeric values for a single.
Permit the kernel environment to set an array of numeric values for a single
Jun 20 2018, 8:04 PM
hselasky closed D15802: Permit the kernel environment to set an array of numeric values for a single sysctl(9) node..
Jun 20 2018, 8:04 PM
emaste added a comment to D15931: Add LPIT parsing to acpidump.

I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?

Jun 20 2018, 8:00 PM
erj updated the summary of D15927: Update ixl(4) and ixlv(4) man pages.
Jun 20 2018, 7:47 PM
bdrewery committed rS335460: Only look for NOTES as needed..
Only look for NOTES as needed.
Jun 20 2018, 7:45 PM
emaste added a comment to D15931: Add LPIT parsing to acpidump.

I took care of the NFIT man page addition in rS335459 - it was my fault :)

Jun 20 2018, 7:41 PM
emaste committed rS335459: acpidump.8: include NFIT in the man page list of tables.
acpidump.8: include NFIT in the man page list of tables
Jun 20 2018, 7:41 PM
imp added inline comments to D15917: uefi stand: Guess the console better.
Jun 20 2018, 7:41 PM
sunpoet committed rP472936: Document GraphicsMagick vulnerability.
Document GraphicsMagick vulnerability
Jun 20 2018, 7:38 PM
sunpoet committed rP472935: Add NO_ARCH.
Add NO_ARCH
Jun 20 2018, 7:38 PM
sunpoet committed rP472934: Add NO_ARCH.
Add NO_ARCH
Jun 20 2018, 7:38 PM
jadawin committed rP472932: - Update to 2.30.
- Update to 2.30
Jun 20 2018, 7:38 PM
sunpoet committed rP472933: Add NO_ARCH.
Add NO_ARCH
Jun 20 2018, 7:38 PM
sunpoet committed rP472931: Add NO_ARCH.
Add NO_ARCH
Jun 20 2018, 7:37 PM
sunpoet committed rP472930: Add SOCKS option.
Add SOCKS option
Jun 20 2018, 7:37 PM
sunpoet committed rP472929: Fix and update WWW.
Fix and update WWW
Jun 20 2018, 7:37 PM
sunpoet committed rP472928: Update WWW.
Update WWW
Jun 20 2018, 7:37 PM
sunpoet committed rP472927: Fix *_DEPENDS.
Fix *_DEPENDS
Jun 20 2018, 7:37 PM
sunpoet committed rP472926: Add LICENSE.
Add LICENSE
Jun 20 2018, 7:37 PM
sunpoet committed rP472925: Fix TEST_DEPENDS.
Fix TEST_DEPENDS
Jun 20 2018, 7:37 PM
sunpoet committed rP472923: Update to 20180612.
Update to 20180612
Jun 20 2018, 7:37 PM
sunpoet committed rP472921: Take maintainership.
Take maintainership
Jun 20 2018, 7:37 PM
sunpoet committed rP472922: Update to 2018.06.17.
Update to 2018.06.17
Jun 20 2018, 7:37 PM
sunpoet committed rP472924: Update to 2018.06.17.
Update to 2018.06.17
Jun 20 2018, 7:37 PM
sunpoet committed rP472920: Fix version requirement of RUN_DEPENDS.
Fix version requirement of RUN_DEPENDS
Jun 20 2018, 7:36 PM
sunpoet committed rP472919: Update to 0.2.3.
Update to 0.2.3
Jun 20 2018, 7:36 PM
sunpoet committed rP472917: Update to 0.22.
Update to 0.22
Jun 20 2018, 7:36 PM
sunpoet committed rP472916: Update to 20110724.005.
Update to 20110724.005
Jun 20 2018, 7:36 PM
sunpoet committed rP472918: Update to 0.20.
Update to 0.20
Jun 20 2018, 7:36 PM
sunpoet committed rP472913: Update to 1.045.
Update to 1.045
Jun 20 2018, 7:36 PM
sunpoet committed rP472914: Update to 1.04.
Update to 1.04
Jun 20 2018, 7:36 PM
sunpoet committed rP472915: Update to 0.010.
Update to 0.010
Jun 20 2018, 7:36 PM
sunpoet committed rP472912: Update to 0.58.
Update to 0.58
Jun 20 2018, 7:36 PM
sunpoet committed rP472911: Update to 3.60.
Update to 3.60
Jun 20 2018, 7:36 PM
sunpoet committed rP472910: Update to 1.6.4.
Update to 1.6.4
Jun 20 2018, 7:36 PM
sunpoet committed rP472907: Take maintainership.
Take maintainership
Jun 20 2018, 7:35 PM
sunpoet committed rP472909: Update to 0.27.
Update to 0.27
Jun 20 2018, 7:35 PM
sunpoet committed rP472908: Enable CA_BUNDLE option by default.
Enable CA_BUNDLE option by default
Jun 20 2018, 7:35 PM
sunpoet committed rP472906: Take maintainership.
Take maintainership
Jun 20 2018, 7:35 PM
sunpoet committed rP472905: Take maintainership.
Take maintainership
Jun 20 2018, 7:35 PM
sunpoet committed rP472904: Take maintainership.
Take maintainership
Jun 20 2018, 7:35 PM
pi committed rP472903: New port: databases/p5-Scope-Container-DBI.
New port: databases/p5-Scope-Container-DBI
Jun 20 2018, 7:30 PM
cy committed rP472902: Correct neon config..
Correct neon config.
Jun 20 2018, 7:26 PM
kevans committed rS335458: Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT.
Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT
Jun 20 2018, 7:24 PM
mmacy updated the summary of D15933: Back pcpu zone with domain correct pages.
Jun 20 2018, 7:23 PM
jhb committed rS335457: Correct path to removed asf(8) binary..
Correct path to removed asf(8) binary.
Jun 20 2018, 7:22 PM
jadawin committed rP472901: - Update to 0.19.
- Update to 0.19
Jun 20 2018, 7:21 PM
dteske created D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 7:17 PM
trasz committed rS335456: Improve wording..
Improve wording.
Jun 20 2018, 7:17 PM
trasz committed rD51889: Update the features list to something that better fits the current century..
Update the features list to something that better fits the current century.
Jun 20 2018, 7:15 PM
trasz closed D15868: Update features list..
Jun 20 2018, 7:15 PM
mat committed rP472900: Add a PKGNAMESUFFIX for the non default flavor..
Add a PKGNAMESUFFIX for the non default flavor.
Jun 20 2018, 7:14 PM
mmacy created D15933: Back pcpu zone with domain correct pages.
Jun 20 2018, 7:13 PM
jhibbits created D15932: Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems.
Jun 20 2018, 7:08 PM
jadawin committed rP472899: - Update to 0.69.
- Update to 0.69
Jun 20 2018, 7:05 PM
emaste updated subscribers of D15931: Add LPIT parsing to acpidump.
Jun 20 2018, 6:59 PM
bwidawsk added a comment to D15931: Add LPIT parsing to acpidump.
In D15931#337134, @jhb wrote:

In general this looks fine. I would probably do the NFIT fixup as a separate commit first. Also, changes to manpages generally require updating Dd to the commit date, though it's ok to leave it out of the review and just change that prior to committing.

Jun 20 2018, 6:58 PM
bwidawsk added a comment to D15931: Add LPIT parsing to acpidump.
In D15931#337133, @jhb wrote:

I am far from an expert on ACPI...

Jun 20 2018, 6:57 PM
jhb added a comment to D15931: Add LPIT parsing to acpidump.

In general this looks fine. I would probably do the NFIT fixup as a separate commit first. Also, changes to manpages generally require updating Dd to the commit date, though it's ok to leave it out of the review and just change that prior to committing.

Jun 20 2018, 6:56 PM
jhb added a comment to D15931: Add LPIT parsing to acpidump.

Are the question marks after the GAS output an issue with acpi_print_gas() needing to understand newer GAS types?

Jun 20 2018, 6:53 PM
kib committed rS335455: MFC r335072, r335089, r335131, r335132:.
MFC r335072, r335089, r335131, r335132:
Jun 20 2018, 6:51 PM
yuri committed rP472898: Add CONFLICTS_INSTALL to py-CommonMark/Makefile and cmark/Makefile.
Add CONFLICTS_INSTALL to py-CommonMark/Makefile and cmark/Makefile
Jun 20 2018, 6:51 PM
jkim committed rP472897: - Update MASTER_SITES and DISTNAME. The previous URLs do not work any more..
- Update MASTER_SITES and DISTNAME. The previous URLs do not work any more.
Jun 20 2018, 6:50 PM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Add sysutils/Makefile modification

Jun 20 2018, 6:46 PM
emaste committed rS335454: usr.bin/ar: use standard 2-Clause FreeBSD license.
usr.bin/ar: use standard 2-Clause FreeBSD license
Jun 20 2018, 6:43 PM
zeising accepted D15717: Mk/Uses/blaslapack.mk: Add a flame selector.

From a mentor perspective, this looks OK, however, it probably warrants a exprun, or at least a discussion with portmgr.

Jun 20 2018, 6:42 PM
dteske committed rP472896: [New Port] sysutils/ssd_report.
[New Port] sysutils/ssd_report
Jun 20 2018, 6:32 PM
dteske closed D15876: [New Port] sysutils/ssd_report.
Jun 20 2018, 6:32 PM