In D15936#337243, @brooks wrote:In D15936#337219, @jpaetzel wrote:I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.
For the local host name, it seems that truncating to 15-bytes is the right thing. For the server name, it's probably a bug if we are given a server name larger than 16 bytes and we should fail.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 20 2018
Jun 20 2018
You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.
misc/cldr-emoji-annotation: Update 33.0.0.1 -> 33.0.0.2
In D15905#337247, @avg wrote:Additionally, anything "interrupt thread" is completely irrelevant to interrupt filters that can also share an interrupt.
In D15905#337246, @avg wrote:In D15905#337244, @cem wrote:Maybe we could allocate independent ithreads for each handler on a shared interrupt source. I'm not sure what the ramifications of that are or if there is a good reason we do not already do that. It may just be that shared interrupts mostly date to the UP days.
This was implemented in the code that you recently removed (INTR_FILTER).
In D15905#337244, @cem wrote:
In D15905#337244, @cem wrote:
In D15905#337213, @avg wrote:I am not sure what exactly you mean by this.
What kind of contention?
In D15936#337219, @jpaetzel wrote:I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.
- Per discussion in the PR, truncate the host name to 15 bytes.
I'm sure it's quite stale now but I'm fine with it...
What mat said. Always use PY_FLAVOR for python dependencies.
I've deployed a variant of this widely at LLNW on the default stack as well. I think you can garbage collect sbsndptr() from the tree.
I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.
In D15931#337176, @emaste wrote:I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?
Once you have a commit bit the NFIT fix could just be committed directly to svn. Until then the pedantic approach would be to create two separate reviews, but as the NFIT part is trivial including it here's fine.
In D15931#337135, @ben.widawsky_intel.com wrote:In D15931#337133, @jhb wrote:I am far from an expert on ACPI...
If the LPI residency counter is a Model Specific Register (MSR), it cannot be natively
described in an ACPI Generic Address Structure (GAS). Therefore it must be
described as Fixed Functional Hardware (FFH) with the GAS field requirements:My understanding is that the FFH addresses have specific parsing based on the hardware and so the existing acpidump code doesn't bother trying to translate it. I looked into fixing that, but I wasn't sure it made sense. I can manually parse this one if you prefer.
In D15905#337073, @cem wrote:Sure, but they will already ping-pong the linked list walk between cores if there is contention there; might as well ping pong the real lock instead.
I added Hans since it is mostly his code we are factoring out.
gallatin added a reviewer for D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine: • hselasky.
- Add the version of the compat stubs I ment to add.
- Add compat symbols returning ENOSYS.
databases/Makefile: re-add p5-Search-InvertedIndex
- Update to Beta 8 (including -i18n)
• hselasky committed rS335461: Permit the kernel environment to set an array of numeric values for a single.
Permit the kernel environment to set an array of numeric values for a single
I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?
Only look for NOTES as needed.
I took care of the NFIT man page addition in rS335459 - it was my fault :)
acpidump.8: include NFIT in the man page list of tables
Document GraphicsMagick vulnerability
Fix version requirement of RUN_DEPENDS
Enable CA_BUNDLE option by default
New port: databases/p5-Scope-Container-DBI
Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT
Correct path to removed asf(8) binary.
trasz committed rD51889: Update the features list to something that better fits the current century..
Update the features list to something that better fits the current century.
Add a PKGNAMESUFFIX for the non default flavor.
In D15931#337134, @jhb wrote:In general this looks fine. I would probably do the NFIT fixup as a separate commit first. Also, changes to manpages generally require updating Dd to the commit date, though it's ok to leave it out of the review and just change that prior to committing.
In D15931#337133, @jhb wrote:
I am far from an expert on ACPI...
In general this looks fine. I would probably do the NFIT fixup as a separate commit first. Also, changes to manpages generally require updating Dd to the commit date, though it's ok to leave it out of the review and just change that prior to committing.
Are the question marks after the GAS output an issue with acpi_print_gas() needing to understand newer GAS types?
MFC r335072, r335089, r335131, r335132:
Add CONFLICTS_INSTALL to py-CommonMark/Makefile and cmark/Makefile
jkim committed rP472897: - Update MASTER_SITES and DISTNAME. The previous URLs do not work any more..
- Update MASTER_SITES and DISTNAME. The previous URLs do not work any more.
Add sysutils/Makefile modification
usr.bin/ar: use standard 2-Clause FreeBSD license
From a mentor perspective, this looks OK, however, it probably warrants a exprun, or at least a discussion with portmgr.
[New Port] sysutils/ssd_report