Page MenuHomeFreeBSD

pdk_semihalf.com (Patryk Duda)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2017, 1:35 PM (123 w, 4 d)

Recent Activity

Fri, Nov 22

pdk_semihalf.com added a comment to D22370: Trigger soft lifetime expiration on sequence number.

Added checking if pointer to reply structure is not NULL

Fri, Nov 22, 8:31 AM
pdk_semihalf.com updated the diff for D22370: Trigger soft lifetime expiration on sequence number.
Fri, Nov 22, 8:28 AM

Mon, Nov 18

pdk_semihalf.com added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.

It is considered as an algorithm to avoid ESN implementation in every driver (I have implemented ESN in cryptosoft and aesni only).
It would be perfect if OCF was prepared for ESN support or at least was organized in way that makes ESN implementation simpler than in current OCF.

Mon, Nov 18, 9:06 AM

Fri, Nov 15

pdk_semihalf.com added a comment to D22363: Increase number of algorithms that can be initialized in cryptosoft.

First of all, @cem, @jhb, @mw thanks for your comments.

Fri, Nov 15, 9:36 AM

Nov 14 2019

pdk_semihalf.com added a reviewer for D22370: Trigger soft lifetime expiration on sequence number: jmg.
Nov 14 2019, 12:36 PM
pdk_semihalf.com added a reviewer for D22369: Pass information about ESN to crypto layer: jmg.
Nov 14 2019, 12:36 PM
pdk_semihalf.com added a reviewer for D22368: Improve sequence number overflow detection in AH protocol: jmg.
Nov 14 2019, 12:35 PM
pdk_semihalf.com added a reviewer for D22367: Implement anti-replay algorithm with ESN support: jmg.
Nov 14 2019, 12:35 PM
pdk_semihalf.com added a reviewer for D22366: Add SADB_SAFLAGS_ESN flag: jmg.
Nov 14 2019, 12:34 PM
pdk_semihalf.com created D22370: Trigger soft lifetime expiration on sequence number.
Nov 14 2019, 12:33 PM
pdk_semihalf.com created D22369: Pass information about ESN to crypto layer.
Nov 14 2019, 12:31 PM
pdk_semihalf.com created D22368: Improve sequence number overflow detection in AH protocol.
Nov 14 2019, 12:29 PM
pdk_semihalf.com created D22367: Implement anti-replay algorithm with ESN support.
Nov 14 2019, 12:27 PM
pdk_semihalf.com created D22366: Add SADB_SAFLAGS_ESN flag.
Nov 14 2019, 12:26 PM
pdk_semihalf.com created D22365: Add support for including ESN in AES-NI crypto driver.
Nov 14 2019, 12:24 PM
pdk_semihalf.com created D22364: Implement support for ESN in cryptosoft.
Nov 14 2019, 12:23 PM
pdk_semihalf.com created D22363: Increase number of algorithms that can be initialized in cryptosoft.
Nov 14 2019, 12:21 PM
pdk_semihalf.com created D22362: Add CRYPTO_ESN, CRD_F_ESN flags and appropriate fields in cryptodev.
Nov 14 2019, 12:19 PM
pdk_semihalf.com abandoned D14538: PowerPC: Implement new memcpy using vectors.
Nov 14 2019, 12:05 PM

Jul 9 2018

pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Removed unnecessary changes

Jul 9 2018, 8:10 AM

Jun 26 2018

pdk_semihalf.com added a comment to D15141: Add support for ThunderX2 PCIe.

Do you have still objections to this patch?

Jun 26 2018, 10:37 AM
pdk_semihalf.com added a comment to D15929: Add quirk mechanism to pci_host_generic_acpi.

Do you have still objections to this patch?

Jun 26 2018, 10:36 AM

Jun 22 2018

pdk_semihalf.com updated the diff for D15929: Add quirk mechanism to pci_host_generic_acpi.

Remove redundant ecam quirk.

Jun 22 2018, 2:52 PM
pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Added obtaining ecam and bus number from ACPI. This allows us to remove ThunderX2 quirk connected with ecam.

Jun 22 2018, 2:47 PM
pdk_semihalf.com added inline comments to D15141: Add support for ThunderX2 PCIe.
Jun 22 2018, 1:32 PM
pdk_semihalf.com added inline comments to D15929: Add quirk mechanism to pci_host_generic_acpi.
Jun 22 2018, 1:07 PM
pdk_semihalf.com added inline comments to D15929: Add quirk mechanism to pci_host_generic_acpi.
Jun 22 2018, 8:44 AM

Jun 21 2018

pdk_semihalf.com added inline comments to D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
Jun 21 2018, 10:03 AM
pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Remove unused declarations.

Jun 21 2018, 9:38 AM
pdk_semihalf.com updated the diff for D15929: Add quirk mechanism to pci_host_generic_acpi.

Move quirks form acpi part to common part.

Jun 21 2018, 9:36 AM

Jun 20 2018

pdk_semihalf.com added a comment to D15141: Add support for ThunderX2 PCIe.

Links to patches emerged
Macros: https://reviews.freebsd.org/D15928
Quirks: https://reviews.freebsd.org/D15929

Jun 20 2018, 4:41 PM
pdk_semihalf.com created D15929: Add quirk mechanism to pci_host_generic_acpi.
Jun 20 2018, 4:38 PM
pdk_semihalf.com created D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
Jun 20 2018, 4:33 PM
pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

No functional changes. This is the previous patch with quirks and macros moved, as andrew suggested

Jun 20 2018, 4:30 PM

Jun 12 2018

pdk_semihalf.com added inline comments to D15141: Add support for ThunderX2 PCIe.
Jun 12 2018, 8:40 AM
pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Restore previous statement about Foundation sponsorship

Jun 12 2018, 8:26 AM

May 21 2018

pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Remove unused functions and declarations.

May 21 2018, 10:08 AM

May 18 2018

Herald added a reviewer for D15141: Add support for ThunderX2 PCIe: manu.

Do you have any objections to this patch?

May 18 2018, 11:26 AM

Apr 26 2018

pdk_semihalf.com updated the diff for D14756: Update mv_gpio driver to new FreeBSD API.

Fixed all issues pointed by manu

Apr 26 2018, 5:11 PM · ARM
pdk_semihalf.com commandeered D14756: Update mv_gpio driver to new FreeBSD API.
Apr 26 2018, 5:09 PM · ARM

Apr 25 2018

pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

Changed approach we add resources to rman. Clean unnecessary changes.

Apr 25 2018, 11:40 AM
pdk_semihalf.com added inline comments to D15141: Add support for ThunderX2 PCIe.
Apr 25 2018, 11:31 AM
pdk_semihalf.com added inline comments to D15141: Add support for ThunderX2 PCIe.
Apr 25 2018, 10:15 AM

Apr 24 2018

pdk_semihalf.com updated the diff for D15141: Add support for ThunderX2 PCIe.

This is not final version!

Apr 24 2018, 5:46 PM
pdk_semihalf.com added a comment to D15141: Add support for ThunderX2 PCIe.

It is good idea to provide support using quirks, however pci_host_generic_acpi still needs some resource allocation changes. I have limited ability to check if it doesn't break another devices, so from my point of view it is safe to provide separate driver.
Of course I will follow your advices, but I'm depending on you to perform review very carefully.

Apr 24 2018, 9:06 AM

Apr 20 2018

pdk_semihalf.com created D15141: Add support for ThunderX2 PCIe.
Apr 20 2018, 9:29 AM

Mar 1 2018

pdk_semihalf.com added a comment to D14538: PowerPC: Implement new memcpy using vectors.

I have a question about your 1st worry. Is this a scenario in which we are doing memcpy in eg. interrupt filter code? If not, could you explain what are you worry about?

Suppose we have an altivec- (or VSX-)using userland program. Vector registers on PPC, like all other architectures, are not saved and restored by interrupt handler code. Instead, they are only saved/restored by cpu_switch() and only if PCB_VEC is set. If a userland thread makes a syscall or otherwise ends up in the kernel, I do not see how this avoids clobbering the vector register state of the userland process. Is there something I am missing?

Mar 1 2018, 4:46 PM
pdk_semihalf.com added a comment to D14538: PowerPC: Implement new memcpy using vectors.

I have a question about your 1st worry. Is this a scenario in which we are doing memcpy in eg. interrupt filter code? If not, could you explain what are you worry about?

Mar 1 2018, 10:54 AM

Feb 27 2018

pdk_semihalf.com created D14538: PowerPC: Implement new memcpy using vectors.
Feb 27 2018, 7:38 PM

Feb 21 2018

pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 21 2018, 2:17 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 21 2018, 1:50 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.

Added some checks, which detects situation when SRR1 is set to inappropriate value (eg. QEMU)

Feb 21 2018, 12:48 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 21 2018, 9:40 AM · PowerPC
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

I wanted this file to be cpu.c equivalent but in assembler, that's why it was named cpu.S
I'd rather keep it cpu_subr64.S because in the near future I want to put highly optimized memcpy into it.

Feb 21 2018, 8:54 AM · PowerPC

Feb 20 2018

pdk_semihalf.com accepted D14452: CXGBE: implement prefetch on non-Intel architectures.
Feb 20 2018, 6:42 PM
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 20 2018, 6:38 PM · PowerPC
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 20 2018, 6:26 PM · PowerPC
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 20 2018, 6:12 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.

Updated diff. I think it will be the last one

Feb 20 2018, 5:48 PM · PowerPC

Feb 19 2018

pdk_semihalf.com updated the diff for D14433: PowerPC: Switch to more accurate unit to avoid division rounding.

Changed type of ps_per_tick to uint64_t

Feb 19 2018, 5:45 PM
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

Could you tell me more about scenario in which we branch to rstcode from software? I was looking for it but I found nothing.

Line 99 of locore64.S.

Feb 19 2018, 5:29 PM · PowerPC
pdk_semihalf.com accepted D14437: Send SIGILL on HEA illegal instruction exception.
Feb 19 2018, 4:11 PM
pdk_semihalf.com created D14433: PowerPC: Switch to more accurate unit to avoid division rounding.
Feb 19 2018, 12:29 PM
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

Could you tell me more about scenario in which we branch to rstcode from software? I was looking for it but I found nothing.

Feb 19 2018, 12:23 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 19 2018, 12:18 PM · PowerPC
pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 19 2018, 8:27 AM · PowerPC

Feb 16 2018

pdk_semihalf.com added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 16 2018, 10:04 AM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 16 2018, 10:03 AM · PowerPC

Feb 15 2018

pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

Thanks for your response.

Feb 15 2018, 6:38 PM · PowerPC
pdk_semihalf.com updated the diff for D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 15 2018, 6:27 PM · PowerPC
pdk_semihalf.com added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

Do you have any objections to this patch?

Feb 15 2018, 11:38 AM · PowerPC

Feb 12 2018

pdk_semihalf.com created D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 12 2018, 4:42 PM · PowerPC

Jan 24 2018

pdk_semihalf.com updated the diff for D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.

Completely changed patch. It uses hint provided by andrew.

Jan 24 2018, 9:17 AM

Jan 23 2018

pdk_semihalf.com added a comment to D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.

My first approach was simply avoid fallback when 64 bit and 32 bit ioctl are equal. But it was terrible idea.
If you thought more about this issue, you would realize that problem is in calculating ioctl number and recognizing 32 bit ioctl using sizeof.
Sooner or later breaking ioctl ABI will be necessary.

Jan 23 2018, 4:11 PM
pdk_semihalf.com added a comment to D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.

Almost all 32 bit ioctl work. In BPF there is BIOCSRTIMEOUT (takes timeval as argument) and BIOCSRTIMEOUT32 (takes timeval32 as argument) which are equal on non intel arch.
That ioctl works only on amd64 because timeval32 has size of 8 bytes. But on other arch, timeval32 has size of 12 bytes (16 bytes with padding)

Jan 23 2018, 2:52 PM
pdk_semihalf.com updated the summary of D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Jan 23 2018, 1:53 PM
pdk_semihalf.com created D14023: BPF: Switch to 32 bit compatible mode only when thread is 32 bit.
Jan 23 2018, 1:49 PM

Sep 11 2017

pdk_semihalf.com added inline comments to D12250: Introduce UART driver module for Armada 3700.
Sep 11 2017, 7:32 AM · arm64

Sep 7 2017

pdk_semihalf.com added inline comments to D12250: Introduce UART driver module for Armada 3700.
Sep 7 2017, 10:34 AM · arm64
pdk_semihalf.com added inline comments to D12250: Introduce UART driver module for Armada 3700.
Sep 7 2017, 8:12 AM · arm64

Sep 4 2017

pdk_semihalf.com added inline comments to D12194: Fix loader bug causing too many pages allocation when bootloader is U-Boot.
Sep 4 2017, 8:28 AM · arm64