(My first impression was, "What is this .export sorcery?!?!")

zinc 295 # pwd
/usr/ports/devel/avr-gcc
zinc 296 # git status .
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
zinc 298 # fetch -o /tmp/p https://reviews.freebsd.org/D30022/diff
fetch: https://reviews.freebsd.org/D30022/diff: size of remote file is not known
/tmp/p 84 kB 609 kBps 00s
zinc 299 # patch < /tmp/p
Hmm... Looks like a unified diff to me...

The text leading up to this was:

Index: devel/avr-gcc/Makefile

===================================================================

--- devel/avr-gcc/Makefile

+++ devel/avr-gcc/Makefile

---

Patching file Makefile using Plan A...
Hunk #1 succeeded at 1.
Hunk #2 succeeded at 33.
Hunk #3 succeeded at 72.
Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

Index: devel/avr-gcc/distinfo

===================================================================

--- devel/avr-gcc/distinfo

+++ devel/avr-gcc/distinfo

---

Patching file distinfo using Plan A...
Hunk #1 succeeded at 1.
Hmm... The next patch looks like a unified diff to me...

The text leading up to this was:

Index: devel/avr-gcc/pkg-plist

===================================================================

--- devel/avr-gcc/pkg-plist

+++ devel/avr-gcc/pkg-plist

---

Patching file pkg-plist using Plan A...
Hunk #1 succeeded at 2.
done

I also uploaded a copy of Makefile.orig

In D30022#676443, @0mp wrote:

Hmmm, I don't know why you experience this behavior. I've tested this patch many times both in poudriere and by building the port manually and running qa targets manually. Perhaps I missed something..

Yeah, the raw diff doesn't apply cleanly for me either. Looking it I think it is against a different version of Makefile than what is currently in the ports tree. The current Makefile:

In D30022#675433, @joerg wrote:

Are there any comments about the patches that don't work straight out of the box for me?
Do you want me to commit it including my modifications?

Remove preamble from BUGS section as suggested by @markj

Remove the "-e flags containing quotes" test, it only fails because
of the multiple -e flag issue. Add references to gzip(1) and zstd(1)
to the man page and also document the two known problems.

The thought occurs that this is an opportunity to make minimal changes to the modest man page; @matthew remarked that it doesn't reference zstd(1) and I see gzip(1) is also missing. In addition it would probably make sense to add a BUGS section and document the known problems (regressions).

Change atf_skip to atf_expect_fail as suggested by @kevans.

In D25613#567335, @kevans wrote:

atf_expect_fail is better here, then if it succeeds it fails and we know it's safe to remove it.