jpaetzel (Josh Paetzel)
User

Projects

User Details

User Since
Jun 20 2014, 7:31 PM (209 w, 2 d)

Recent Activity

Wed, Jun 20

jpaetzel accepted D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Wed, Jun 20, 9:26 PM
jpaetzel added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

For the local host name, it seems that truncating to 15-bytes is the right thing. For the server name, it's probably a bug if we are given a server name larger than 16 bytes and we should fail.

Wed, Jun 20, 9:25 PM
jpaetzel added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

Wed, Jun 20, 8:47 PM

Mon, Jun 4

jpaetzel committed rP471543: Free misha from mentorship, he's ready to fly solo..
Free misha from mentorship, he's ready to fly solo.
Mon, Jun 4, 1:13 PM

Mon, May 28

jpaetzel committed rP471014: Update to version 10.2.5.
Update to version 10.2.5
Mon, May 28, 2:04 AM

May 23 2018

jpaetzel committed rP470726: Unbreak after src r333813.
Unbreak after src r333813
May 23 2018, 10:37 PM

May 5 2018

jpaetzel added reviewers for D15307: Add Highpoint driver for 3740A/840A cards: imp, mav, scottl.
May 5 2018, 3:18 PM
jpaetzel updated the diff for D15307: Add Highpoint driver for 3740A/840A cards.

Fix typo

May 5 2018, 6:33 AM
jpaetzel updated the diff for D15307: Add Highpoint driver for 3740A/840A cards.

Remove invalid UTF-8 from README

May 5 2018, 6:15 AM
jpaetzel created D15307: Add Highpoint driver for 3740A/840A cards.
May 5 2018, 6:06 AM

May 1 2018

jpaetzel committed rS333146: Add ability to perform a firmware reset during driver initialization..
Add ability to perform a firmware reset during driver initialization.
May 1 2018, 5:39 PM

Mar 23 2018

jpaetzel added a comment to D14810: Add a workaround to the hypervisor detection for older versions of KVM..

Confirmed the new patch works.

Mar 23 2018, 9:45 PM
jpaetzel added a comment to D14810: Add a workaround to the hypervisor detection for older versions of KVM..

avg@ went so far as to verify the stock CentOS kernel included that commit you are referencing, and it does.

Mar 23 2018, 9:36 PM
jpaetzel added a comment to D14810: Add a workaround to the hypervisor detection for older versions of KVM..

For what it's worth the system where I saw this is running the latest version of CentOS 7.4, which has an old kernel, but not that old. But just to be sure I updated it's kernel to 4.15.12 and the problem persisted. I'll test the patch though.

Mar 23 2018, 9:33 PM

Mar 13 2018

jpaetzel committed rP464378: Reintegrate accidentally removed patch.
Reintegrate accidentally removed patch
Mar 13 2018, 2:20 PM

Mar 10 2018

jpaetzel committed rP464095: Fix bug that causes crashes when running commands from the host.
Fix bug that causes crashes when running commands from the host
Mar 10 2018, 10:57 PM

Feb 25 2018

jpaetzel committed rP462960: Backport a fix from upstream that broke UFS.
Backport a fix from upstream that broke UFS
Feb 25 2018, 3:35 PM

Feb 23 2018

jpaetzel added a comment to D14463: libifconfig: multiple feature additions.

For that to happen the original author will need a commit bit, which I'll be more than happy to mentor.

Feb 23 2018, 9:35 PM

Feb 19 2018

jpaetzel committed rP462356: Update to 3.12.
Update to 3.12
Feb 19 2018, 11:43 PM

Jan 22 2018

jpaetzel committed rP459695: MFH: r457864.
MFH: r457864
Jan 22 2018, 8:27 PM

Jan 9 2018

jpaetzel committed rP458572: Update to 1.4.1.
Update to 1.4.1
Jan 9 2018, 8:59 PM

Jan 2 2018

jpaetzel committed rP457864: Fix build with clang 6.0.0.
Fix build with clang 6.0.0
Jan 2 2018, 2:45 PM

Jan 1 2018

jpaetzel committed rP457784: Fix USES and cleanup backports namespace.
Fix USES and cleanup backports namespace
Jan 1 2018, 4:46 PM

Dec 28 2017

jpaetzel committed rP457485: Don't remove a config file the port doesn't install..
Don't remove a config file the port doesn't install.
Dec 28 2017, 10:46 PM

Dec 23 2017

jpaetzel committed rP457023: Update to 10.2.0.
Update to 10.2.0
Dec 23 2017, 5:20 AM

Dec 7 2017

jpaetzel committed rP455751: Remove unused dependancies..
Remove unused dependancies.
Dec 7 2017, 7:52 PM

Oct 5 2017

jpaetzel committed rP451314: MFH: r451100.
MFH: r451100
Oct 5 2017, 2:44 PM

Oct 2 2017

jpaetzel committed rP451100: Remove external ICU dependancy.
Remove external ICU dependancy
Oct 2 2017, 8:04 PM

Sep 19 2017

jpaetzel committed rS323778: Fix indentation for r323068.
Fix indentation for r323068
Sep 19 2017, 8:40 PM
jpaetzel committed rS323770: MFC: 323068.
MFC: 323068
Sep 19 2017, 4:52 PM

Sep 1 2017

jpaetzel reopened D11806: Enable IPSEC_SUPPORT..

I reverted this commit. We need more consensus before continuing.

Sep 1 2017, 5:07 PM
jpaetzel committed rS323103: Revert r323087.
Revert r323087
Sep 1 2017, 5:04 PM
jpaetzel closed D11806: Enable IPSEC_SUPPORT. by committing rS323087: Take options IPSEC out of GENERIC.
Sep 1 2017, 3:55 PM
jpaetzel committed rS323087: Take options IPSEC out of GENERIC.
Take options IPSEC out of GENERIC
Sep 1 2017, 3:55 PM

Aug 31 2017

jpaetzel committed rS323068: Allow kldload tcpmd5.
Allow kldload tcpmd5
Aug 31 2017, 8:16 PM

Aug 29 2017

jpaetzel committed rP448929: Update to 10.1.10.
Update to 10.1.10
Aug 29 2017, 4:44 PM

Aug 17 2017

jpaetzel committed rP448160: Take maintainership.
Take maintainership
Aug 17 2017, 6:00 PM
jpaetzel accepted D12038: Don't leak lock from os_kmem_alloc()..

LGTM

Aug 17 2017, 4:48 PM

Aug 15 2017

jpaetzel added a comment to D12038: Don't leak lock from os_kmem_alloc()..

The path for the file to be patched is wrong, the original is correct in this case. The code change does fix the kernel panic when the module is loaded.

Aug 15 2017, 11:40 PM

Aug 2 2017

jpaetzel committed rP447126: Update to version 2.2.4.
Update to version 2.2.4
Aug 2 2017, 5:41 PM

Jul 26 2017

jpaetzel added a comment to D11445: Update to Subsonic 6 and drop maintainer ship..

Oh, I missed the link to the bug which has the full diff and poudriere logs.

Jul 26 2017, 7:58 PM
jpaetzel added a comment to D11445: Update to Subsonic 6 and drop maintainer ship..

As long as this passes poudriere testport and portlint it looks good to me.

Jul 26 2017, 7:56 PM

Jul 12 2017

jpaetzel committed rP445585: Add LICENSE.
Add LICENSE
Jul 12 2017, 2:42 PM

Jun 27 2017

jpaetzel committed rP444524: Update to 2.2.3.
Update to 2.2.3
Jun 27 2017, 11:35 PM
jpaetzel committed rS320394: ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value.
ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value
Jun 27 2017, 3:57 AM
jpaetzel committed rS320393: driver incorrectly handles the setting of frame rates.
driver incorrectly handles the setting of frame rates
Jun 27 2017, 3:45 AM

Jun 23 2017

jpaetzel committed rP444183: MFH: r444072.
MFH: r444072
Jun 23 2017, 4:39 PM
jpaetzel committed rP444182: MFH: r440983.
MFH: r440983
Jun 23 2017, 4:37 PM

Jun 21 2017

jpaetzel committed rP444072: Update to latest version.
Update to latest version
Jun 21 2017, 7:19 PM

Jun 15 2017

jpaetzel committed rS319992: MFC 319670.
MFC 319670
Jun 15 2017, 11:14 PM
jpaetzel committed rS319980: MFC 319670.
MFC 319670
Jun 15 2017, 4:12 PM

Jun 14 2017

jpaetzel committed rP443568: Update translate-toolkit to version 2.1.0.
Update translate-toolkit to version 2.1.0
Jun 14 2017, 1:55 PM

Jun 12 2017

jpaetzel committed rP443463: Update port to work after removal of groff from the base system..
Update port to work after removal of groff from the base system.
Jun 12 2017, 7:55 PM

Jun 8 2017

jpaetzel committed rS319670: Fix SMBFS when saved passwords are greater than 18 characters.
Fix SMBFS when saved passwords are greater than 18 characters
Jun 8 2017, 12:48 AM

May 30 2017

jpaetzel committed rP442100: Chase a few more changes that were fallout of an upstream distfile reroll..
Chase a few more changes that were fallout of an upstream distfile reroll.
May 30 2017, 4:25 PM

May 24 2017

jpaetzel committed rP441620: Chase rerolled distfile.
Chase rerolled distfile
May 24 2017, 9:30 PM
jpaetzel committed rS318806: MFC 318401.
MFC 318401
May 24 2017, 8:14 PM
jpaetzel committed rS318805: MFC 318401.
MFC 318401
May 24 2017, 8:10 PM

May 17 2017

jpaetzel committed rS318401: Increase the number of LUNs this hardware can support..
Increase the number of LUNs this hardware can support.
May 17 2017, 1:22 PM

May 1 2017

jpaetzel committed rS317648: Fix misport of compressed ZFS send/recv from 317414.
Fix misport of compressed ZFS send/recv from 317414
May 1 2017, 12:56 PM

Apr 28 2017

jpaetzel committed rS317541: MFV 316905.
MFV 316905
Apr 28 2017, 2:11 AM

Apr 27 2017

jpaetzel committed rS317533: MFV 316900.
MFV 316900
Apr 27 2017, 11:31 PM
jpaetzel committed rS317527: MFV 316898.
MFV 316898
Apr 27 2017, 10:00 PM
jpaetzel committed rS317522: MFV 316897.
MFV 316897
Apr 27 2017, 9:12 PM
jpaetzel committed rS317511: MFV 316896.
MFV 316896
Apr 27 2017, 4:38 PM
jpaetzel committed rS317507: MFV 316895.
MFV 316895
Apr 27 2017, 3:11 PM

Apr 25 2017

jpaetzel committed rS317414: MFV 316894.
MFV 316894
Apr 25 2017, 5:58 PM

Apr 21 2017

jpaetzel committed rS317267: MFV 316891.
MFV 316891
Apr 21 2017, 7:54 PM
jpaetzel committed rS317238: MFV 316871.
MFV 316871
Apr 21 2017, 12:25 AM
jpaetzel committed rS317237: MFV 316870.
MFV 316870
Apr 21 2017, 12:18 AM
jpaetzel committed rS317235: MFV 316868.
MFV 316868
Apr 21 2017, 12:13 AM

Apr 13 2017

jpaetzel committed rS316752: 5409 Remove shareiscsi description and example from zfs(1M).
5409 Remove shareiscsi description and example from zfs(1M)
Apr 13 2017, 5:56 AM
jpaetzel committed rS316751: 5661 ZFS: "compression = on" should use lz4 if feature is enabled.
5661 ZFS: "compression = on" should use lz4 if feature is enabled
Apr 13 2017, 5:48 AM

Mar 27 2017

jpaetzel committed rS316037: MFV: 315989.
MFV: 315989
Mar 27 2017, 5:28 PM

Mar 26 2017

jpaetzel committed rS315989: 7603 xuio_stat_wbuf_* should be declared (void).
7603 xuio_stat_wbuf_* should be declared (void)
Mar 26 2017, 4:49 PM

Mar 21 2017

jpaetzel committed rP436618: Delete npm012 port..
Delete npm012 port.
Mar 21 2017, 4:49 PM

Mar 15 2017

jpaetzel committed rS315291: 7303 dynamic metaslab selection.
7303 dynamic metaslab selection
Mar 15 2017, 4:18 AM
jpaetzel committed rS315290: 7303 dynamic metaslab selection.
7303 dynamic metaslab selection
Mar 15 2017, 4:16 AM

Mar 7 2017

jpaetzel committed rS314874: MFC 313879.
MFC 313879
Mar 7 2017, 6:31 PM
jpaetzel committed rS314873: MFC 313879.
MFC 313879
Mar 7 2017, 6:27 PM
jpaetzel accepted D9829: Add a summary line of the ZFS Compressed ARC to top(1).
Mar 7 2017, 4:45 PM

Feb 28 2017

jpaetzel accepted D9829: Add a summary line of the ZFS Compressed ARC to top(1).
Feb 28 2017, 2:33 PM
jpaetzel added a comment to D9829: Add a summary line of the ZFS Compressed ARC to top(1).

LGTM

Feb 28 2017, 2:32 PM

Feb 25 2017

jpaetzel committed rS314280: MFV 314276.
MFV 314276
Feb 25 2017, 8:01 PM
jpaetzel committed rS314276: 7570 tunable to allow zvol SCSI unmap to return on commit of txn to ZIL.
7570 tunable to allow zvol SCSI unmap to return on commit of txn to ZIL
Feb 25 2017, 7:16 PM
jpaetzel committed rS314267: MFV 314243.
MFV 314243
Feb 25 2017, 2:46 PM
jpaetzel committed rS314243: 6676 Race between unique_insert() and unique_remove() causes ZFS fsid change.
6676 Race between unique_insert() and unique_remove() causes ZFS fsid change
Feb 25 2017, 3:34 AM

Feb 17 2017

jpaetzel committed rS313879: MVF: 313876.
MVF: 313876
Feb 17 2017, 5:52 PM
jpaetzel committed rS313876: 7504 kmem_reap hangs spa_sync and administrative tasks.
7504 kmem_reap hangs spa_sync and administrative tasks
Feb 17 2017, 3:00 PM

Feb 16 2017

jpaetzel committed rS313813: MFV 313786.
MFV 313786
Feb 16 2017, 7:00 PM
jpaetzel committed rS313786: 7500 Simplify dbuf_free_range by removing dn_unlisted_l0_blkid.
7500 Simplify dbuf_free_range by removing dn_unlisted_l0_blkid
Feb 16 2017, 1:45 AM

Jan 20 2017

jpaetzel committed rS312535: MFV 312436.
MFV 312436
Jan 20 2017, 3:01 PM
jpaetzel closed D9008: Add delete throttle functionality from upstream openzfs by committing rS312535: MFV 312436.
Jan 20 2017, 3:01 PM
jpaetzel committed rS312445: Revert MFC of 310847 and 310864.
Revert MFC of 310847 and 310864
Jan 20 2017, 12:18 AM
jpaetzel committed rS312444: Revert MFC of 310847 and 310864.
Revert MFC of 310847 and 310864
Jan 20 2017, 12:15 AM

Jan 19 2017

jpaetzel committed rS312440: MFC 310847 310864.
MFC 310847 310864
Jan 19 2017, 11:42 PM
jpaetzel committed rS312439: MFC 310847 310864.
MFC 310847 310864
Jan 19 2017, 11:38 PM
jpaetzel added a comment to D9008: Add delete throttle functionality from upstream openzfs.

I've done the vendor import but keep getting tree conflicts when trying to merge it to HEAD

Jan 19 2017, 9:22 PM
jpaetzel committed rS312436: 6569 large file delete can starve out write ops.
6569 large file delete can starve out write ops
Jan 19 2017, 8:44 PM
jpaetzel committed rS312421: MFC 311122.
MFC 311122
Jan 19 2017, 5:58 PM