Page MenuHomeFreeBSD
Differential D25120

Avoid trying to toggle TSO twice
ClosedPublic
Actions

Authored by freqlabs on Jun 3 2020, 4:21 PM.
Tags
None
Referenced Files
F132271325: D25120.id72620.diff
Wed, Oct 15, 9:26 AM
F132271322: D25120.id73138.diff
Wed, Oct 15, 9:26 AM
F132271317: D25120.id.diff
Wed, Oct 15, 9:26 AM
F132252134: D25120.id72620.diff
Wed, Oct 15, 5:14 AM
F132222864: D25120.diff
Tue, Oct 14, 10:48 PM
Unknown Object (File)
Thu, Oct 2, 2:49 PM
Unknown Object (File)
Wed, Oct 1, 10:45 PM
Unknown Object (File)
Wed, Oct 1, 6:45 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
mav
• hselasky
np
gallatin
jpaetzel
Commits
rS362511: MFC r362201:
rS362201: Avoid trying to toggle TSO twice
Summary

Remove TSO from the toggle mask when automatically disabled by TXCKSUM* in various NIC drivers.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freqlabs created this revision.Jun 3 2020, 4:21 PM
Herald added subscribers: ae, imp. · View Herald TranscriptJun 3 2020, 4:21 PM
freqlabs requested review of this revision.Jun 3 2020, 4:21 PM
mav accepted this revision.Jun 3 2020, 4:32 PM

It makes sense to me on a brief look, but please request review from the driver maintainers.

This revision is now accepted and ready to land.Jun 3 2020, 4:32 PM
freqlabs added reviewers: • hselasky, np, gallatin, jpaetzel.Jun 3 2020, 4:37 PM
• hselasky accepted this revision.Jun 3 2020, 5:16 PM

Looks good.

jpaetzel accepted this revision.Jun 3 2020, 7:36 PM

I'm the defacto if_oce maintainer. I approve the change to oce_if.c

gallatin accepted this revision.Jun 3 2020, 7:54 PM
np accepted this revision.Jun 15 2020, 4:02 PM
Closed by commit rS362201: Avoid trying to toggle TSO twice (authored by freqlabs). · Explain WhyJun 15 2020, 4:35 PM
This revision was automatically updated to reflect the committed changes.
freqlabs added a commit: rS362201: Avoid trying to toggle TSO twice.
freqlabs added a commit: rS362511: MFC r362201:.Oct 18 2020, 5:43 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
cxgb/
2 lines
cxgbe/
2 lines
mlx4/
mlx4_en/
2 lines
mlx5/
mlx5_en/
2 lines
mxge/
8 lines
oce/
1 line

Diff 73138

View Options

head/sys/dev/cxgb/cxgb_main.c

Loading...
View Options

head/sys/dev/cxgbe/t4_main.c

Loading...
View Options

head/sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

Loading...
View Options

head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Loading...
View Options

head/sys/dev/mxge/if_mxge.c

Loading...
View Options

head/sys/dev/oce/oce_if.c

Loading...