Page MenuHomeFreeBSD

vbhakta_vmware.com (Vishal Bhakta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2018, 8:13 PM (41 w, 9 h)

Recent Activity

Jun 20 2019

vbhakta_vmware.com added a comment to D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.

Thanks for taking a look!

Overall this looks very good, but error handoff in pvscsi_process_completion() is not correct. Generally if you're going to return a status that isn't CAM_REQ_CMP, you need to do the following before calling xpt_done():

if (mprsas_get_ccbstatus(ccb) != CAM_REQ_CMP) {
         ccb->ccb_h.status |= CAM_DEV_QFRZN;
         xpt_freeze_devq(ccb->ccb_h.path, /*count*/ 1);
 }

I'm also not sure what's going on here:

	if (sc->frozen) {
		ccb->ccb_h.status |= CAM_RELEASE_SIMQ;
		sc->frozen = 0;
	}
Jun 20 2019, 11:27 PM

Apr 30 2019

vbhakta_vmware.com added a comment to D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.

And updates on this review?

Apr 30 2019, 10:20 PM

Apr 15 2019

vbhakta_vmware.com updated the diff for D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.

Updated the man page license header to use or instead of and. No changes to the code.

Apr 15 2019, 8:13 PM

Dec 24 2018

vbhakta_vmware.com changed the visibility for D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Dec 24 2018, 10:42 PM

Dec 20 2018

vbhakta_vmware.com changed the edit policy for D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Dec 20 2018, 6:42 AM
vbhakta_vmware.com changed the visibility for D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Dec 20 2018, 6:42 AM
vbhakta_vmware.com created D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Dec 20 2018, 12:26 AM