Page MenuHomeFreeBSD

bwidawsk (Ben Widawsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2018, 8:32 PM (332 w, 6 d)

Recent Activity

Mar 19 2019

bwidawsk added inline comments to D18028: Add support for Intel Speed Shift.
Mar 19 2019, 9:22 PM
bwidawsk updated the diff for D18028: Add support for Intel Speed Shift.

intel hwpstate v2

Mar 19 2019, 9:21 PM

Mar 15 2019

bwidawsk added inline comments to D19565: linuxkpi v5.0 updates.
Mar 15 2019, 11:10 PM

Mar 1 2019

bwidawsk committed rS344680: MFC r344474-r344476.
MFC r344474-r344476
Mar 1 2019, 2:16 AM

Feb 22 2019

bwidawsk closed D17619: nvdimm: Simple namespace support.
Feb 22 2019, 8:04 PM
bwidawsk accepted D17619: nvdimm: Simple namespace support.
Feb 22 2019, 8:04 PM
bwidawsk committed rS344476: nvdimm: Simple namespace support.
nvdimm: Simple namespace support
Feb 22 2019, 7:54 PM
bwidawsk committed rS344475: nvdimm: Read NVDIMM namespace labels.
nvdimm: Read NVDIMM namespace labels
Feb 22 2019, 7:54 PM
bwidawsk closed D18735: nvdimm: Read NVDIMM namespace labels.
Feb 22 2019, 7:54 PM
bwidawsk committed rS344474: nvdimm: split spa dev into a separate entity.
nvdimm: split spa dev into a separate entity
Feb 22 2019, 7:54 PM
bwidawsk closed D18736: nvdimm: split spa dev into a separate entity.
Feb 22 2019, 7:54 PM

Feb 19 2019

bwidawsk committed rS344270: MFC r344043:.
MFC r344043:
Feb 19 2019, 2:27 AM

Feb 16 2019

bwidawsk added inline comments to D18028: Add support for Intel Speed Shift.
Feb 16 2019, 12:18 AM

Feb 13 2019

bwidawsk committed rS344111: MFC r339577:.
MFC r339577:
Feb 13 2019, 7:00 PM
bwidawsk committed rS344110: MFC r340000:.
MFC r340000:
Feb 13 2019, 6:55 PM

Feb 12 2019

bwidawsk committed rS344043: termcap: Add an entry for kitty.
termcap: Add an entry for kitty
Feb 12 2019, 5:15 AM
bwidawsk closed D19060: Add a termcap entry for kitty.
Feb 12 2019, 5:15 AM
bwidawsk retitled D18028: Add support for Intel Speed Shift from Summary: RFC: Add support for Intel Speed Shift to Summary: Add support for Intel Speed Shift.
Feb 12 2019, 12:29 AM
bwidawsk added a reviewer for D18028: Add support for Intel Speed Shift: manu.
Feb 12 2019, 12:27 AM
bwidawsk updated the diff for D18028: Add support for Intel Speed Shift.

Add support for Intel Speed Shift

Feb 12 2019, 12:26 AM

Feb 3 2019

bwidawsk added a comment to D19060: Add a termcap entry for kitty.

Should add an MFC to this...

Feb 3 2019, 12:54 AM

Feb 2 2019

bwidawsk updated subscribers of D19060: Add a termcap entry for kitty.
Feb 2 2019, 5:31 AM
bwidawsk created D19060: Add a termcap entry for kitty.
Feb 2 2019, 5:24 AM

Jan 31 2019

bwidawsk accepted D18736: nvdimm: split spa dev into a separate entity.
Jan 31 2019, 8:44 PM

Nov 26 2018

bwidawsk committed rS340993: acpi/ec: Fix regression caused by r340644.
acpi/ec: Fix regression caused by r340644
Nov 26 2018, 7:44 PM
bwidawsk closed D18311: Summary: acpi/ec: Fix regression caused by r340644.
Nov 26 2018, 7:44 PM

Nov 25 2018

bwidawsk added a comment to D17675: Suspend to idle support.

I think so. I think there are definitely some robustifications needed, but generally it'd be good to know if I need any major overhauls. Also, at this point in the series, it's entirely opt-in, and any regressions should be fixable.

Nov 25 2018, 6:07 AM

Nov 24 2018

bwidawsk added a reviewer for D18311: Summary: acpi/ec: Fix regression caused by r340644: jkim.
Nov 24 2018, 4:53 PM

Nov 23 2018

bwidawsk created D18311: Summary: acpi/ec: Fix regression caused by r340644.
Nov 23 2018, 6:01 PM

Nov 22 2018

bwidawsk added inline comments to D18041: LKPI updates for drm-v4.18.
Nov 22 2018, 12:40 AM

Nov 21 2018

bwidawsk committed rS340720: linuxkpi: Use pageproc instead of vmproc.
linuxkpi: Use pageproc instead of vmproc
Nov 21 2018, 4:34 AM
bwidawsk closed D18061: linuxkpi: Use pageproc instead of vmproc.
Nov 21 2018, 4:34 AM
bwidawsk created D18061: linuxkpi: Use pageproc instead of vmproc.
Nov 21 2018, 3:52 AM
bwidawsk committed rS340716: Add definitions for Intel Speed Shift.
Add definitions for Intel Speed Shift
Nov 21 2018, 12:22 AM
bwidawsk closed D18050: Summary:Add definitions for Intel Speed Shift.
Nov 21 2018, 12:22 AM
bwidawsk added inline comments to D18050: Summary:Add definitions for Intel Speed Shift.
Nov 21 2018, 12:09 AM

Nov 20 2018

bwidawsk committed rD52501: Steps for new commits 1-4.
Steps for new commits 1-4
Nov 20 2018, 11:49 PM
bwidawsk committed rS340712: git-svn-init: Add docs to the choice of repos.
git-svn-init: Add docs to the choice of repos
Nov 20 2018, 11:27 PM
bwidawsk committed rS340710: linuxkpi: Remove duplicated text.
linuxkpi: Remove duplicated text
Nov 20 2018, 11:05 PM
bwidawsk committed rS340709: linuxkpi: Add some basic swap functions.
linuxkpi: Add some basic swap functions
Nov 20 2018, 10:49 PM
bwidawsk closed D18052: Summary: linuxkpi: Add some basic swap functions These are used by kms-drm to determine various heuristics related to low memory conditions..
Nov 20 2018, 10:49 PM
bwidawsk updated the diff for D18028: Add support for Intel Speed Shift.

Forgot to add the amd part in the last update

Nov 20 2018, 12:47 AM
bwidawsk updated the diff for D18028: Add support for Intel Speed Shift.

Moved bit definitions to another differential. Took all of kib@ feedback. Will continue to add to this.

Nov 20 2018, 12:47 AM
bwidawsk added a comment to D18028: Add support for Intel Speed Shift.

Some of this has been moved into D18050

Nov 20 2018, 12:46 AM

Nov 19 2018

bwidawsk created D18052: Summary: linuxkpi: Add some basic swap functions These are used by kms-drm to determine various heuristics related to low memory conditions..
Nov 19 2018, 11:53 PM
bwidawsk edited P238 Masterwork From Distant Lands.
Nov 19 2018, 7:57 PM
bwidawsk retitled D18050: Summary:Add definitions for Intel Speed Shift from Summary: Add definitions for Intel Speed Shift to Summary:Add definitions for Intel Speed Shift.
Nov 19 2018, 7:43 PM
bwidawsk created D18050: Summary:Add definitions for Intel Speed Shift.
Nov 19 2018, 7:43 PM
bwidawsk committed rS340644: acpi: fix acpi_ec_probe to only check EC devices.
acpi: fix acpi_ec_probe to only check EC devices
Nov 19 2018, 6:29 PM
bwidawsk closed D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Nov 19 2018, 6:29 PM

Nov 18 2018

bwidawsk updated subscribers of D18028: Add support for Intel Speed Shift.
Nov 18 2018, 1:14 AM
bwidawsk created D18028: Add support for Intel Speed Shift.
Nov 18 2018, 1:09 AM

Nov 16 2018

bwidawsk added a comment to D18006: Align IA32_ARCH_CAP MSR definitions and use with SDM rev. 068..

Talked with Kostik offline. Patch should say bit 3 instead of 4 for VM entry. Patch itself is correct.

Nov 16 2018, 8:13 PM
bwidawsk accepted D18006: Align IA32_ARCH_CAP MSR definitions and use with SDM rev. 068..

Can you please identify where the docs say

Nov 16 2018, 7:54 PM
bwidawsk added a comment to D18006: Align IA32_ARCH_CAP MSR definitions and use with SDM rev. 068..

I asked for clarification and hopefully, I will have some by the end of the day. My understanding is that RDCL_NO still determines whether or not you need to mitigate L1TF type vulnerabilities.

Nov 16 2018, 4:36 PM

Nov 1 2018

bwidawsk committed rS340000: linuxkpi: Add GFP flags needed for ttm drivers.
linuxkpi: Add GFP flags needed for ttm drivers
Nov 1 2018, 3:30 PM

Oct 31 2018

bwidawsk added a comment to D16767: Add a tools/build/make.py script that bootstraps bmake and then runs the build.

I've tested the latest in github today on Arch Linux and was able to build world and kernel - however at this moment, I haven't been able to test what has been built anywhere.

Oct 31 2018, 9:54 PM

Oct 30 2018

bwidawsk abandoned D16231: [new port] misc/ix: port for the ix command line client.
Oct 30 2018, 10:35 PM
bwidawsk accepted D16719: Add pci_early function for Intel stolen memory (and possibly more).
Oct 30 2018, 8:30 PM
bwidawsk added a comment to D17764: Optional prevention of console suspend.

I have two subsequent ideas which I may or may not get around to:

Oct 30 2018, 7:39 PM
bwidawsk updated subscribers of D17764: Optional prevention of console suspend.
Oct 30 2018, 7:38 PM
bwidawsk edited reviewers for D17764: Optional prevention of console suspend, added: jhb; removed: imp.
Oct 30 2018, 7:37 PM
bwidawsk retitled D17764: Optional prevention of console suspend from Summary: Provide a way to stop suspending of console on x86 platforms. Similar mechanisms could be done for ARM and PPC devices. to Optional prevention of console suspend.
Oct 30 2018, 7:37 PM
bwidawsk created D17764: Optional prevention of console suspend.
Oct 30 2018, 7:36 PM

Oct 25 2018

bwidawsk updated the diff for D17676: Emulated S3 with s0ix (not currently working).

Small fix for systems which don't have a pm device

Oct 25 2018, 11:38 PM

Oct 23 2018

bwidawsk added a comment to D17676: Emulated S3 with s0ix (not currently working).

The hunks for the idle suspend stuff were some WIP that I hadn't finished. They can be ignored.

Oct 23 2018, 10:22 PM
bwidawsk created D17676: Emulated S3 with s0ix (not currently working).
Oct 23 2018, 10:20 PM
bwidawsk created D17675: Suspend to idle support.
Oct 23 2018, 10:17 PM

Oct 22 2018

bwidawsk edited P231 Masterwork From Distant Lands.
Oct 22 2018, 11:40 PM
bwidawsk committed rS339577: acpi: Add an interface to obtain DSM information.
acpi: Add an interface to obtain DSM information
Oct 22 2018, 3:30 AM
bwidawsk closed D17121: Summary: acpi: Add an interface to obtain DSM information.
Oct 22 2018, 3:30 AM

Oct 19 2018

bwidawsk added inline comments to D17619: nvdimm: Simple namespace support.
Oct 19 2018, 8:47 PM

Oct 16 2018

bwidawsk accepted D17536: Flush L1 data cache on syscall return with an error..
Oct 16 2018, 5:32 PM

Oct 4 2018

bwidawsk edited P226 Masterwork From Distant Lands.
Oct 4 2018, 8:33 PM

Oct 3 2018

bwidawsk updated the diff for D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.

commit 5e5bf62ac3ec965fd2809b8c393d7b088b125cab (HEAD)
Author: Ben Widawsky <ben.widawsky@intel.com>
Date: Tue Aug 7 18:40:37 2018 -0700

Oct 3 2018, 6:15 PM

Sep 26 2018

bwidawsk added a comment to D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Sep 26 2018, 5:36 PM

Sep 14 2018

bwidawsk edited P221 Masterwork From Distant Lands.
Sep 14 2018, 6:01 PM
bwidawsk planned changes to D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Sep 14 2018, 5:35 PM

Sep 13 2018

bwidawsk added inline comments to D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Sep 13 2018, 7:08 PM
bwidawsk updated the diff for D17121: Summary: acpi: Add an interface to obtain DSM information.

Addressed kib's comments.

Sep 13 2018, 6:40 PM
bwidawsk planned changes to D17121: Summary: acpi: Add an interface to obtain DSM information.
Sep 13 2018, 6:38 PM
bwidawsk closed D16042: tools: Add a git-svn bootstrap script.
Sep 13 2018, 6:01 PM
bwidawsk accepted D16042: tools: Add a git-svn bootstrap script.
Sep 13 2018, 6:00 PM

Sep 12 2018

bwidawsk archived P220 Masterwork From Distant Lands.
Sep 12 2018, 7:15 PM
bwidawsk edited P220 Masterwork From Distant Lands.
Sep 12 2018, 6:43 PM

Sep 11 2018

bwidawsk added a comment to D17121: Summary: acpi: Add an interface to obtain DSM information.

Here is some sample usage from the SPMC driver which will later be up for review:

Sep 11 2018, 6:35 PM
bwidawsk created D17121: Summary: acpi: Add an interface to obtain DSM information.
Sep 11 2018, 6:22 PM
bwidawsk abandoned D17120: Summary: acpi/spmc: Add support for the SPMC.

This was the wrong commit.

Sep 11 2018, 6:18 PM
bwidawsk created D17120: Summary: acpi/spmc: Add support for the SPMC.
Sep 11 2018, 6:17 PM
bwidawsk archived P217 deadlock_ps.
Sep 11 2018, 5:14 PM
bwidawsk edited P218 Masterwork From Distant Lands.
Sep 11 2018, 5:11 PM
bwidawsk created P217 deadlock_ps.
Sep 11 2018, 4:32 PM

Sep 6 2018

bwidawsk closed D17052: Summary: Add device_attach and device_detach events to man page..
Sep 6 2018, 6:45 PM
bwidawsk committed rS338504: Add device_attach and device_detach events to man page..
Add device_attach and device_detach events to man page.
Sep 6 2018, 6:45 PM
bwidawsk updated the diff for D17052: Summary: Add device_attach and device_detach events to man page..

Modified .Dd

Sep 6 2018, 5:20 PM
bwidawsk created D17052: Summary: Add device_attach and device_detach events to man page..
Sep 6 2018, 12:24 PM
bwidawsk added a comment to D17052: Summary: Add device_attach and device_detach events to man page..

See Differential Revision: https://reviews.freebsd.org/D12557

Sep 6 2018, 12:24 PM

Sep 1 2018

bwidawsk updated the test plan for D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.
Sep 1 2018, 1:13 AM
bwidawsk updated the diff for D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.

Update the revision to hopefully work properly. The patch this time attempts to
separate sharing acpi_ec_probe, and only use acpi_ec_probe for the Device() as
opposed to the fixed ECDT enumerated one.

Sep 1 2018, 1:08 AM

Aug 31 2018

bwidawsk accepted D16962: ddb: Enable 'thread <address>'.

I think man page does need to be updated as markj said.

Aug 31 2018, 5:45 PM