Page MenuHomeFreeBSD

nvdimm: Simple namespace support
ClosedPublic

Authored by scottph on Oct 19 2018, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 11:10 AM
Unknown Object (File)
Wed, Nov 27, 7:18 PM
Unknown Object (File)
Mon, Nov 25, 7:17 AM
Unknown Object (File)
Mon, Nov 25, 3:54 AM
Unknown Object (File)
Sun, Nov 24, 12:25 AM
Unknown Object (File)
Sat, Nov 23, 11:16 PM
Unknown Object (File)
Sat, Nov 23, 12:31 PM
Unknown Object (File)
Fri, Nov 22, 8:35 AM
Subscribers

Details

Reviewers
bwidawsk
kib
Summary

Add support for simple NVDIMM v1.2 namespaces from the UEFI
version 2.7 specification. The combination of NVDIMM regions and
labels can lead to a wide variety of namespace layouts. Here we
support a simple subset of namespaces where each NVDIMM SPA range
is composed of a single region per member dimm.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/dev/nvdimm/nvdimm.c
290

I think you need to free the buffer on each loop, not just at the end. You could potentially statically allocate the buffer, but I've never actually tried to do this myself.

One note from https://wiki.freebsd.org/Phabricator - for next upload please include full context e.g. from git show -U999999 <commit-hash> > change.diff

scottph retitled this revision from [RFC] squash of the work-in-progress series for NVDIMM Namespace support to nvdimm: Simple namespace support.
scottph edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 22 2019, 8:04 PM