Page MenuHomeFreeBSD

linuxkpi: Use pageproc instead of vmproc
ClosedPublic

Authored by bwidawsk on Nov 21 2018, 3:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 5:27 PM
Unknown Object (File)
Oct 24 2024, 9:52 AM
Unknown Object (File)
Oct 5 2024, 2:20 PM
Unknown Object (File)
Oct 5 2024, 2:20 PM
Unknown Object (File)
Oct 5 2024, 2:20 PM
Unknown Object (File)
Oct 5 2024, 1:47 PM
Unknown Object (File)
Oct 2 2024, 5:41 AM
Unknown Object (File)
Sep 18 2024, 2:32 AM
Subscribers

Details

Summary

According to markj@:
pageproc contains the page daemon and laundry threads, which are
responsible for managing the LRU page queues and writing back dirty
pages. vmproc's main task is to swap out kernel stacks when the system
is under memory pressure, and swap them back in when necessary. It's a
somewhat legacy component of the system and isn't required. You can
build a kernel without it by specifying "options NO_SWAPPING" (which is
a somewhat misleading name), in which vm_swapout_dummy.c is compiled
instead of vm_swapout.c.

Based on this, we want pageproc to emulate kswapd, not vmproc.

Test Plan

N/A

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks ok to me. In general I'd suggest considering having the definition in a .c file so that we're not forced to pollute the namespace with FreeBSD definitions. It's probably not going to be an issue here, but it's something that does come up from time to time.

sys/compat/linuxkpi/common/include/linux/swap.h
49 ↗(On Diff #50651)

style(9) puts parens around return values.

This revision is now accepted and ready to land.Nov 21 2018, 4:06 AM
This revision was automatically updated to reflect the committed changes.