Page MenuHomeFreeBSD

textproc/py-qrcode: Update to 6.0
ClosedPublic

Authored by leres on Jun 20 2018, 5:53 PM.

Details

Summary

Proposed commit message:

Update to 6.0:

 - Fix optimize length being ignored in QRCode.add_data.

 - Better calculation of the best mask pattern and related
   optimizations.

Reviewed by: ? (mentor)
Approved by: ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leres created this revision.Jun 20 2018, 5:53 PM
mat added inline comments.Jun 20 2018, 6:28 PM
textproc/py-qrcode/Makefile
15–16 ↗(On Diff #44168)

Why change PY_FLAVOR to FLAVOR?

matthew requested changes to this revision.Jun 20 2018, 8:52 PM

What mat said. Always use PY_FLAVOR for python dependencies.

Although mat did just update the original py-qrcode port amongst many others in r472884
to enforce the rule about always using PY_FLAVOR only about 50 minutes before you posted this review.
I guess you hadn't noticed that update while working on this port?

Anyhow, given the addition of the PY_FLAVOR fix, this looks fine.

This revision now requires changes to proceed.Jun 20 2018, 8:52 PM
leres updated this revision to Diff 44189.Jun 20 2018, 9:30 PM

Update diff to not step on r472884 PY_FLAVOR change.

leres added a comment.Jun 20 2018, 9:33 PM

I tested my change in a ports tree that had not been updated in a few hours then copied to the ports tree I use for committer work; I lost the race with r472884. I'll try to be more careful moving forward.

This revision is now accepted and ready to land.Jun 20 2018, 9:51 PM
This revision was automatically updated to reflect the committed changes.