This will make future extensions of the API much easier.
The intent is to remove support for DIOCADDRULE in FreeBSD 14.
MFC after: 4 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38295 Build 35184: arc lint + arc unit
Event Timeline
Comment Actions
Seems ok to me for what it's worth. My comments are mostly nits.
| sys/netpfil/pf/pf_ioctl.c | ||
|---|---|---|
| 1631 | They're equivalent, but it looks like the last parameter should be sizeof(*paddr). | |
| 1729 | I think there's nothing checking that the supplied array has exactly two elements. Should the checking be more strict, so that an array of length 1 is rejected? There are a few examples of this. | |
| sys/netpfil/pf/pf_nv.c | ||
| 36 | Same thing here with respect to the include path. | |
Comment Actions
- Require the number of array elements to be exactly the maximum number
- Explicitly check the nvlist error state
| sys/netpfil/pf/pf.h | ||
|---|---|---|
| 193 | Component "size" is unused. I do not see any use case for it. Can it be dropped? | |
| sys/netpfil/pf/pf.h | ||
|---|---|---|
| 193 | It's not used here, but it is required for get operations (e.g. D29559). For those userspace must supply a larger buffer than required for just the request, so that the kernel can put the reply in the data buffer. In that case len will be the length of the request data, but we will have provided size bytes of space for the kernel to put the response into. | |