Paths

Table of Contentst

Differential D56113

pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes
ClosedPublic
Actions

Authored by glebius on Mar 27 2026, 7:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 28, 1:01 AM

	Unknown Object (File)
	Mon, Apr 27, 4:01 PM

	Unknown Object (File)
	Fri, Apr 24, 1:06 AM

	Unknown Object (File)
	Sun, Apr 19, 12:20 AM

	Unknown Object (File)
	Sat, Apr 18, 9:55 PM

	Unknown Object (File)
	Sat, Apr 18, 9:51 PM

	Unknown Object (File)
	Tue, Apr 14, 12:24 PM

	Unknown Object (File)
	Mon, Apr 13, 2:52 PM

View All 27 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Group Reviewers

Commits

rGcd5ff4e841fb: pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 27 2026, 7:21 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi, imp. · View Herald TranscriptMar 27 2026, 7:21 PM

glebius requested review of this revision.Mar 27 2026, 7:21 PM

Harbormaster completed remote builds in B71746: Diff 174389.Mar 27 2026, 7:21 PM

glebius added a parent revision: D55904: hash(9): introduce hashalloc()/hashfree() KPI.Mar 27 2026, 7:21 PM

glebius mentioned this in D55904: hash(9): introduce hashalloc()/hashfree() KPI.Mar 27 2026, 7:25 PM

glebius added inline comments.

sys/netpfil/pf/pf.c
1434	`.head = HASH_HEAD_LIST` is not needed, but I decided to be more explicit.

glebius retitled this revision from pf: use hashalloc(9) for key and id hashes to pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes.Mar 28 2026, 6:59 PM

Extend to src-nodes and udp-endpoints hashes.

Herald added a subscriber: ae. · View Herald TranscriptMar 28 2026, 7:00 PM

Harbormaster completed remote builds in B71774: Diff 174450.Mar 28 2026, 7:00 PM

glebius added inline comments.Mar 28 2026, 7:01 PM

sys/netpfil/pf/pf.c
1435–1436	Initialization of `.type` and `.head` to the default values. May be omitted.

I'm seeing panics with this patch ("panic: lock "pf_keyhash" 0xfffffe00e8dffff8 already initialized").
I believe the problem is that hashalloc() allocates unzero'd memory, and which leads to incorrect assertions on the lock, if LO_INITIALIZED happens to be set in lo_flags.

In D56113#1284599, @kp wrote:

I'm seeing panics with this patch ("panic: lock "pf_keyhash" 0xfffffe00e8dffff8 already initialized").
I believe the problem is that hashalloc() allocates unzero'd memory, and which leads to incorrect assertions on the lock, if LO_INITIALIZED happens to be set in lo_flags.

That's because you have it on top of older version of D55904. In the updated version MTX_NEW is passed. For me this revision passes all pf tests.

Ah, yes, thanks!

This revision is now accepted and ready to land.Mar 30 2026, 8:03 PM

Closed by commit rGcd5ff4e841fb: pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes (authored by glebius). · Explain WhySun, Apr 12, 5:40 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGcd5ff4e841fb: pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes.

Revision Contents
Changeset List

Path

Size

sys/

net/

3 lines

netpfil/

pf/

146 lines

Diff 175359

sys/net/pfvar.h

Loading...

sys/netpfil/pf/pf.c

Loading...