Page MenuHomeFreeBSD

libpfctl: Switch to pfctl_rule
ClosedPublic

Authored by kp on Apr 8 2021, 12:36 PM.

Details

Summary

Stop using the kernel's struct pf_rule, switch to libpfctl's pfctl_rule.
Now that we use nvlists to communicate with the kernel these structures
can be fully decoupled.

MFC after: 4 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Apr 8 2021, 12:36 PM
glebius added a subscriber: glebius.
glebius added inline comments.
usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
1517

Do you plan to eventually hide struct pfioc_rule into libpfctl?

This revision is now accepted and ready to land.Apr 8 2021, 7:40 PM
usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
1517

I'm hoping to eventually delete it entirely.
One of the things I want to add to libpfctl is a convenience function to get the ticket, at which point I'll try to work out if I want to have a new struct to keep ticket, pool_ticket, anchor and anchor_call in.

This revision was automatically updated to reflect the committed changes.