libpfctl: Switch to pfctl_rule
ClosedPublic
Actions

Authored by kp on Apr 8 2021, 12:36 PM.

Details

Reviewers

Group Reviewers

Commits

rG6fd48efd8d6d: libpfctl: Switch to pfctl_rule
rGe055cd8e7a2c: libpfctl: Switch to pfctl_rule
rGe9eb09414a8d: libpfctl: Switch to pfctl_rule

Summary

Stop using the kernel's struct pf_rule, switch to libpfctl's pfctl_rule.
Now that we use nvlists to communicate with the kernel these structures
can be fully decoupled.

MFC after: 4 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Apr 8 2021, 12:36 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2021, 12:36 PM

Harbormaster completed remote builds in B38411: Diff 87031.Apr 8 2021, 12:36 PM

kp requested review of this revision.Apr 8 2021, 12:36 PM

kp added a parent revision: D29643: pf: Move prototypes for userspace functions to userspace header.Apr 8 2021, 12:36 PM

kp added a child revision: D29645: libpfctl: Fix u_* counters.

kp mentioned this in D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.Apr 8 2021, 12:39 PM

takahiro.kurosawa_gmail.com added a subscriber: takahiro.kurosawa_gmail.com.Apr 8 2021, 1:42 PM

glebius accepted this revision.Apr 8 2021, 7:40 PM

glebius added a subscriber: glebius.

glebius added inline comments.

usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
1518	Do you plan to eventually hide struct pfioc_rule into libpfctl?

This revision is now accepted and ready to land.Apr 8 2021, 7:40 PM

kp added inline comments.Apr 8 2021, 7:43 PM

usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c
1518	I'm hoping to eventually delete it entirely. One of the things I want to add to libpfctl is a convenience function to get the ticket, at which point I'll try to work out if I want to have a new struct to keep ticket, pool_ticket, anchor and anchor_call in.