libnv: Allow use in non-sleepable contexts
ClosedPublic
Actions

Authored by kp on Apr 2 2021, 6:54 PM.

Details

Reviewers

melifaro
oshogbo

Group Reviewers

network

Commits

rGe1d7503d6cf7: libnv: Allow use in non-sleepable contexts
rG4f784d330d3f: libnv: Allow use in non-sleepable contexts
rGab8d25880ebc: libnv: Allow use in non-sleepable contexts

Summary

44c125c4cebc2fd87c6260b90eddae11201f5232 switched the nvlist allocations
to be M_WAITOK, but this precludes the use in non-sleepable contexts.
(E.g. with a nonsleepable lock held).

All callers for these allocation functions already cope with memory
alloation failures, so there's no reason to allow sleeping during
allocations.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Apr 2 2021, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2021, 6:54 PM

kp requested review of this revision.Apr 2 2021, 6:54 PM

Harbormaster completed remote builds in B38278: Diff 86758.Apr 2 2021, 6:54 PM

kp added a child revision: D29557: pf: Introduce nvlist variant of DIOCADDRULE.Apr 2 2021, 6:54 PM

kp mentioned this in D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.Apr 2 2021, 6:59 PM

melifaro accepted this revision as: melifaro.Apr 4 2021, 2:55 PM

This revision is now accepted and ready to land.Apr 4 2021, 2:55 PM

kp added a reviewer: oshogbo.Apr 5 2021, 11:53 AM

oshogbo accepted this revision.Apr 6 2021, 8:12 AM

Closed by commit rGab8d25880ebc: libnv: Allow use in non-sleepable contexts (authored by kp). · Explain WhyApr 7 2021, 3:04 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGab8d25880ebc: libnv: Allow use in non-sleepable contexts.

kp added a commit: rG4f784d330d3f: libnv: Allow use in non-sleepable contexts.Apr 14 2021, 1:09 PM

kp added a commit: rGe1d7503d6cf7: libnv: Allow use in non-sleepable contexts.

Revision Contents
Changeset List

Path

Size

sys/

contrib/

libnv/

nv_impl.h

8 lines

Diff 86963

View Options

sys/contrib/libnv/nv_impl.h

libnv: Allow use in non-sleepable contextsClosedPublicActions