Differential D28738

smbios: Move smbios driver out from x86 machdep code
ClosedPublic
Actions

Authored by allanjude on Feb 17 2021, 9:34 PM.

Tags

None

Referenced Files

	F103527806: D28738.diff
	Tue, Nov 26, 3:22 AM

	Unknown Object (File)
	Fri, Nov 22, 11:33 PM

	Unknown Object (File)
	Tue, Nov 12, 3:31 AM

	Unknown Object (File)
	Tue, Nov 5, 10:42 AM

	Unknown Object (File)
	Fri, Nov 1, 4:50 AM

	Unknown Object (File)
	Oct 3 2024, 1:57 AM

	Unknown Object (File)
	Oct 2 2024, 9:21 AM

	Unknown Object (File)
	Sep 30 2024, 3:56 PM

View All 78 Files

Subscribers

Details

Reviewers

emaste
scottph
mhorne
rpokala

Commits

rG7abbfbda1ea7: smbios: Move smbios driver out from x86 machdep code
rGd0673fe160b0: smbios: Move smbios driver out from x86 machdep code

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

allanjude created this revision.Feb 17 2021, 9:34 PM

Herald added subscribers: rpokala, imp. · View Herald TranscriptFeb 17 2021, 9:34 PM

allanjude requested review of this revision.Feb 17 2021, 9:34 PM

allanjude added a parent revision: D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

allanjude added a child revision: D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Harbormaster completed remote builds in B37113: Diff 84133.Feb 17 2021, 9:35 PM

allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM

allanjude added reviewers: emaste, scottph, mhorne.Feb 17 2021, 9:41 PM

Should https://reviews.freebsd.org/D28745 be squashed into this review?

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

IMO it's reasonable to do the moving/refactoring first to facilitate additional testing/experimentation, and add it to GENERIC kern confs later (when we're quite confident it is going to be completed, as here).

manu added a subscriber: manu.Feb 17 2021, 10:10 PM

manu added inline comments.

sys/conf/files.x86
296	So, it seems that smbios wasn't part of GENERIC as it was optional smbios here but now it is. That should be reflected in the commit.

In D28738#643660, @rpokala wrote:

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

That is done here: https://reviews.freebsd.org/D28744

In D28738#644234, @allanjude wrote:

In D28738#643660, @rpokala wrote:

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

That is done here: https://reviews.freebsd.org/D28744

Thanks!

LGTM, FWIW.

This revision is now accepted and ready to land.Feb 18 2021, 6:54 PM

Closed by commit rGd0673fe160b0: smbios: Move smbios driver out from x86 machdep code (authored by allanjude). · Explain WhyFeb 23 2021, 9:20 PM

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rGd0673fe160b0: smbios: Move smbios driver out from x86 machdep code.

vangyzen added a commit: rG7abbfbda1ea7: smbios: Move smbios driver out from x86 machdep code.Mar 3 2022, 2:21 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

1 line

include/

pc/

32 lines

conf/

1 line

1 line

dev/

ipmi/

3 lines

	dev/	smbios/	smbios.h/
	amd64/	include/	pc/


	bios.h

65 lines

	dev/	smbios/
	x86/	bios/

22 lines

i386/

conf/

1 line

1 line

include/

pc/

32 lines

modules/

bios/

smbios/

2 lines

x86/

bios/

Diff 84586

sys/amd64/conf/GENERIC

Loading...

sys/amd64/conf/MINIMAL

Loading...

sys/amd64/include/pc/bios.h

Loading...

sys/conf/files

Loading...

sys/conf/files.x86

Loading...

sys/dev/ipmi/ipmi_smbios.c

Loading...

sys/dev/smbios/smbios.h

Loading...

sys/dev/smbios/smbios.c

Loading...

sys/i386/conf/GENERIC

Loading...

sys/i386/conf/MINIMAL

Loading...

sys/i386/include/pc/bios.h

Loading...

sys/modules/bios/smbios/Makefile

Loading...

sys/x86/bios/smbios.c

Loading...