Fix indentation.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 26 2020
Using AcpiOsGetRootPointer() instead of FADT or SPCR
In D27306#611573, @dan.kotowski_a9development.com wrote:You're right, that's much easier to read and makes more sense long term. And I just retested and it works fine in all combinations of serial and video.
Should I update this diff or reject and recreate?
Add a comment about locking.
I'm not particularly familiar with this code, but the patch does look correct to me.
In D26473#608811, @ngie wrote:Non-blocking thought: can this use sem_post/sem_(timed)?wait instead of spinning in busy-loops waiting for threads to start?
(Tinderboxed.)
(Tinderboxed.)
(Tinderboxed.)
It seems like GCC needs a valid goto *addrof_label in order to take the address of a label inside the function rather that at the start. Not sure if that really matters though:
In D27376#611538, @cem wrote:Sure, someone could make a separate kld for exFAT, but I'm not sure it makes much sense. There is a good amount of shared logic. The MSDOS_EXFAT option does not break classic FAT support, FWIW. If enabled, msdosfs(5) supports both kind of filesystem; they are easy to distinguish at mount.
- This should address all comments so far.
Overcome by events - the port was updated to 1.9.0 in FreeBSD ports commit r542002
http://svnweb.freebsd.org/changeset/ports/542002
Thanks for doing this John. A couple of typo comments are inline.
Have you thought about how to configure this at boot time?
(I emailed you a little rc.d script. The nfs-over-tls daemons start
via rc.d scripts and need it configured.
You're right, that's much easier to read and makes more sense long term. And I just retested and it works fine in all combinations of serial and video.
Nov 25 2020
Looks ok to me. I should be able to test this
someday soon by making the NFS VFS_STATFS()
fail.
Others know a lot more about the VFS side and
have already clicked reviewed, so I've left that to them.
This generally looks fine.
Merge in comments for the KERNLOAD into one blob.