Page MenuHomeFreeBSD

Check that the frame pointer is within the current stack.
ClosedPublic

Authored by jhb on Nov 24 2020, 9:49 PM.

Details

Summary

This same check is used on other architectures. Previously this would
permit a stack frame to unwind into any arbitrary kernel address
(including unmapped addresses).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Nov 24 2020, 9:49 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
91 ↗(On Diff #79958)

This was changed in rS333570 as unwind_frame could be probed by the FBT provider. It might be enough to exclude it from being probed in fbt_provide_module_function

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
91 ↗(On Diff #79958)

I think that would be fine. Alternately, perhaps unwind_frame() could move to stack.h?

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
91 ↗(On Diff #79958)

Hmm, risc-v would need the same approach as I have made it also use unwind_frame. Do you have a preference Mark on how to fix it?

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
91 ↗(On Diff #79958)

I think I prefer to explicitly exclude unwind_frame() from FBT by modifying fbt_provide_module_function() for the relevant arches. All of the solutions (keep the code as-is, make unwind_frame() inlinable, exclude unwind_frame() from FBT) are kind of fragile, but modifying FBT at least makes it easy to identify these problematic functions.

  • Add unwind_frame to fbt_excluded.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 8 2020, 6:01 PM
This revision was automatically updated to reflect the committed changes.