Add a kstack_contains() helper function.
ClosedPublic
Actions

Authored by jhb on Nov 24 2020, 9:48 PM.

Details

Reviewers

kib
markj
gnn

Commits

rS368240: Add a kstack_contains() helper function.

Summary

This is useful for stack unwinders which need to avoid out-of-bounds
reads of a kernel stack which can trigger kernel faults.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 24 2020, 9:48 PM

jhb created this revision.

Harbormaster completed remote builds in B35009: Diff 79952.Nov 24 2020, 9:48 PM

jhb added a child revision: D27357: Stack unwinding robustness fixes for RISC-V..Nov 24 2020, 9:49 PM

jhb added a child revision: D27358: Make stack_save*() more robust on MIPS..

jhb added a child revision: D27362: Check that the frame pointer is within the current stack..Nov 24 2020, 9:52 PM

jhb added reviewers: kib, markj.

kib accepted this revision.Nov 25 2020, 8:01 AM

This revision is now accepted and ready to land.Nov 25 2020, 8:01 AM

markj accepted this revision.Nov 25 2020, 3:26 PM

Closed by commit rS368240: Add a kstack_contains() helper function. (authored by jhb). · Explain WhyDec 1 2020, 5:05 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS368240: Add a kstack_contains() helper function..

Herald added a reviewer: gnn. · View Herald TranscriptDec 1 2020, 5:05 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

dev/

dtrace/

amd64/

dtrace_isa.c

17 lines

i386/

dtrace_isa.c

15 lines

ddb/

db_ps.c

3 lines

riscv/

stack_machdep.c

5 lines

sys/

proc.h

7 lines

x86/

stack_machdep.c

4 lines

Diff 80194

View Options

head/sys/cddl/dev/dtrace/amd64/dtrace_isa.c

View Options

head/sys/cddl/dev/dtrace/i386/dtrace_isa.c

View Options

head/sys/ddb/db_ps.c

View Options

head/sys/riscv/riscv/stack_machdep.c

View Options

head/sys/sys/proc.h

View Options

head/sys/x86/x86/stack_machdep.c

Add a kstack_contains() helper function.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 80194

head/sys/cddl/dev/dtrace/amd64/dtrace_isa.c

head/sys/cddl/dev/dtrace/i386/dtrace_isa.c

head/sys/ddb/db_ps.c

head/sys/riscv/riscv/stack_machdep.c

head/sys/sys/proc.h

head/sys/x86/x86/stack_machdep.c

Add a kstack_contains() helper function.
ClosedPublic
Actions

Revision Contents
Changeset List