Page MenuHomeFreeBSD

kaktus (Paweł Biernacki)
User

Projects

User Details

User Since
Mar 24 2015, 9:11 PM (287 w, 4 d)

Recent Activity

Aug 12 2020

kaktus committed rS364150: MFC userland part of r351729.
MFC userland part of r351729
Aug 12 2020, 10:03 AM

Aug 4 2020

kaktus committed rS363833: regen.
regen
Aug 4 2020, 12:45 PM
kaktus committed rS363832: MFC kernel part of r351729.
MFC kernel part of r351729
Aug 4 2020, 12:43 PM

Jul 19 2020

kaktus committed rS363326: MFC r362947.
MFC r362947
Jul 19 2020, 3:17 PM

Jul 9 2020

kaktus committed rS363059: MFC r362612.
MFC r362612
Jul 9 2020, 8:55 PM
kaktus committed rS363058: MFC r362612.
MFC r362612
Jul 9 2020, 8:54 PM

Jul 6 2020

kaktus committed rS362969: kern.tty_info_kstacks: set compact format as default.
kern.tty_info_kstacks: set compact format as default
Jul 6 2020, 4:34 PM
kaktus committed rS362967: kern.tty_info_kstacks: add a compact format.
kern.tty_info_kstacks: add a compact format
Jul 6 2020, 4:33 PM
kaktus closed D25487: kern.tty_info_kstacks: add a compact format.
Jul 6 2020, 4:33 PM

Jul 5 2020

kaktus committed rS362947: truss: print more information about traced sysctls.
truss: print more information about traced sysctls
Jul 5 2020, 7:54 PM

Jul 4 2020

kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

__assert_unreachable in correct place

Jul 4 2020, 7:26 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use __assert_unreachable().
Shorten the code by two LOC.

Jul 4 2020, 7:11 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 6:56 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 6:48 PM
kaktus committed rS362932: dev.ixl.<N>.debug: mark as MPSAFE.
dev.ixl.<N>.debug: mark as MPSAFE
Jul 4 2020, 2:20 PM
kaktus closed D25408: dev.ixl.<N>.debug: mark as MPSAFE.
Jul 4 2020, 2:20 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use atomic_load

Jul 4 2020, 11:05 AM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use correct diff this time…

Jul 4 2020, 10:39 AM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 10:37 AM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Address /some/ comments.

Jul 4 2020, 10:35 AM

Jul 3 2020

kaktus committed rS362912: MFC r362611.
MFC r362611
Jul 3 2020, 11:46 AM
kaktus committed rS362911: MFC r362611.
MFC r362611
Jul 3 2020, 11:44 AM

Jun 27 2020

kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 5:20 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 4:50 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 4:23 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Address comments.

Jun 27 2020, 4:19 PM
kaktus added a reviewer for D25408: dev.ixl.<N>.debug: mark as MPSAFE: mjg.
Jun 27 2020, 4:11 PM
kaktus added a comment to D25408: dev.ixl.<N>.debug: mark as MPSAFE.

Not really, no. This one was found with a power of grep while searching for NEEDGIANT nodes.

Jun 27 2020, 4:11 PM
kaktus requested review of D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 2:01 PM

Jun 25 2020

kaktus closed D25414: bhyve: allow for automatic destruction on power-off.
Jun 25 2020, 12:35 PM
kaktus committed rS362612: bhyve: allow for automatic destruction on power-off.
bhyve: allow for automatic destruction on power-off
Jun 25 2020, 12:35 PM
kaktus closed D25169: man page of select(2) should mention pselect(2).
Jun 25 2020, 12:31 PM
kaktus committed rS362611: man page of select(2) should mention pselect(2).
man page of select(2) should mention pselect(2)
Jun 25 2020, 12:31 PM

Jun 24 2020

kaktus added a comment to D25414: bhyve: allow for automatic destruction on power-off.

As mentioned on irc, I believe we're bound by the already defined exit codes, as describes in section EXIT STATUS of bhyve(8).

Jun 24 2020, 7:35 PM

Jun 23 2020

kaktus updated the diff for D25414: bhyve: allow for automatic destruction on power-off.

Update man page.

Jun 23 2020, 10:05 PM
kaktus requested review of D25414: bhyve: allow for automatic destruction on power-off.
Jun 23 2020, 5:58 PM
kaktus requested review of D25408: dev.ixl.<N>.debug: mark as MPSAFE.
Jun 23 2020, 10:03 AM
kaktus requested review of D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
Jun 23 2020, 3:27 AM
kaktus closed D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
Jun 23 2020, 3:22 AM
kaktus requested review of D25169: man page of select(2) should mention pselect(2).
Jun 23 2020, 3:21 AM

Jun 21 2020

kaktus committed rS362468: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
net.link.generic.ifdata.<ifindex>.linkspecific: rework handler
Jun 21 2020, 6:40 PM
kaktus accepted D23942: Document that gettimeofday() is obsolescent.
Jun 21 2020, 9:36 AM

Jun 20 2020

kaktus added a comment to D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.

I was thinking about that too as there is no in-tree driver that support that call anyway, but bsnmpd have an option to query it if the driver supports it, so it'd have to be removed too. Anyway, it's probably task for another patch.

Jun 20 2020, 7:36 PM

Jun 18 2020

kaktus accepted D25351: Document that umount -A does not unmount /dev.
Jun 18 2020, 11:07 PM
kaktus added inline comments to D25351: Document that umount -A does not unmount /dev.
Jun 18 2020, 10:38 PM
kaktus closed D25321: hw.bus.info: rework handler.
Jun 18 2020, 9:43 PM
kaktus committed rS362343: hw.bus.info: rework handler.
hw.bus.info: rework handler
Jun 18 2020, 9:43 PM
kaktus requested review of D25321: hw.bus.info: rework handler.
Jun 18 2020, 9:18 AM

May 29 2020

kaktus added a comment to D25041: Add jail_attach2 syscall.

ACK. Wasn't sure about the JAIL_ATTACH namespace anyway.

May 29 2020, 9:19 AM
kaktus added a comment to D25041: Add jail_attach2 syscall.
In D25041#551522, @mjg wrote:

Disabling ptrace should not be an option, it should be mandatory no matter what.

May 29 2020, 9:19 AM

May 28 2020

kaktus requested review of D25041: Add jail_attach2 syscall.
May 28 2020, 9:33 PM

May 16 2020

kaktus committed rS361113: sysctl: fix setting net.isr.dispatch during early boot.
sysctl: fix setting net.isr.dispatch during early boot
May 16 2020, 5:06 PM
kaktus closed D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 5:06 PM
kaktus updated the summary of D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 10:09 AM
kaktus requested review of D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 10:00 AM

May 1 2020

kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.

Guys, thanks for the constructive comments.

May 1 2020, 4:47 PM · network

Apr 26 2020

kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.

I was told 2.5 years ago that jail_attach(2) is insecure and I shouldn't use it. Apparently it's no longer the case - see for example rS360356. Can I please have it accepted now?

Apr 26 2020, 10:46 PM · network
kaktus retitled D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0 from Enable VNET operations for ifconfig and route to ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.
Apr 26 2020, 10:46 PM · network

Apr 15 2020

kaktus committed rS359976: sysctl_handle_string: Put logical or in parentheses..
sysctl_handle_string: Put logical or in parentheses.
Apr 15 2020, 4:55 PM
kaktus closed D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 4:34 PM
kaktus committed rS359975: sysctl(9): fix handling string tunables..
sysctl(9): fix handling string tunables.
Apr 15 2020, 4:34 PM
kaktus updated the summary of D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 10:49 AM
kaktus updated the summary of D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 10:23 AM
kaktus created D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 10:22 AM

Apr 14 2020

kaktus accepted D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.

Nice one. LGTM.

Apr 14 2020, 9:46 AM

Apr 1 2020

kaktus closed D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Apr 1 2020, 12:14 AM

Mar 3 2020

kaktus added a reviewer for D23935: New port: security/py-angr: multi-architecture binary analysis toolkit: kaktus.
Mar 3 2020, 1:16 AM
kaktus added inline comments to D23935: New port: security/py-angr: multi-architecture binary analysis toolkit.
Mar 3 2020, 1:16 AM

Mar 2 2020

kaktus committed rS358548: sys/: Document few more sysctls..
sys/: Document few more sysctls.
Mar 2 2020, 3:31 PM
kaktus closed D23759: Add many sysctl descriptions in kern.
Mar 2 2020, 3:31 PM
kaktus accepted D23759: Add many sysctl descriptions in kern.
Mar 2 2020, 3:28 PM
kaktus added a reviewer for D23759: Add many sysctl descriptions in kern: kaktus.
Mar 2 2020, 2:34 PM

Feb 27 2020

kaktus committed rS358379: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many)
Feb 27 2020, 1:12 PM
kaktus closed D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 27 2020, 1:12 PM
kaktus added a comment to D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

OK, I'll mark them as mpsafe in a commit.

Feb 27 2020, 1:04 PM

Feb 26 2020

kaktus updated the diff for D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Use full context diff.

Feb 26 2020, 3:19 PM
kaktus created D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 26 2020, 3:17 PM
kaktus committed rS358334: Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be.
Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be
Feb 26 2020, 3:12 PM
kaktus added a comment to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Commited as rS358333

Feb 26 2020, 2:51 PM
kaktus committed rS358333: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)
Feb 26 2020, 2:28 PM
kaktus updated the diff for D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Sync with rS358330 and split sys/dev/random bits to a separate review for so@ approval.

Feb 26 2020, 1:59 PM

Feb 25 2020

kaktus added a comment to D23839: Make ipf sysctl mpsafe.

That it'll not be run more than one at a time (from userspace).

Feb 25 2020, 9:48 PM
kaktus accepted D23839: Make ipf sysctl mpsafe.
Feb 25 2020, 9:05 PM
kaktus added a comment to D23839: Make ipf sysctl mpsafe.

No, because the sysctl handler was running under Giant implicitly (as it wasn't marked as MPSAFE).

Feb 25 2020, 9:05 PM
kaktus committed rS358318: SYSCTL_ROOT_NODE should use the SYSCTL_ENFORCE_FLAGS macro too..
SYSCTL_ROOT_NODE should use the SYSCTL_ENFORCE_FLAGS macro too.
Feb 25 2020, 7:13 PM
kaktus committed rS358316: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (16 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (16 of many)
Feb 25 2020, 7:04 PM
kaktus closed D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 25 2020, 7:04 PM

Feb 24 2020

kaktus closed D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:56 AM
kaktus accepted D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:56 AM
kaktus added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Committed as rS358286.

Feb 24 2020, 10:54 AM
kaktus committed rS358286: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (15 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (15 of many)
Feb 24 2020, 10:51 AM
kaktus committed rS358285: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (14 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (14 of many)
Feb 24 2020, 10:47 AM
kaktus closed D23639: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:47 AM
kaktus committed rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many)
Feb 24 2020, 10:45 AM
kaktus closed D23635: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:45 AM
kaktus committed rS358283: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (12 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (12 of many)
Feb 24 2020, 10:43 AM
kaktus closed D23637: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:43 AM
kaktus committed rS358280: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many)
Feb 24 2020, 10:41 AM
kaktus closed D23636: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:41 AM
kaktus committed rS358277: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (10 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (10 of many)
Feb 24 2020, 10:38 AM