User Details
- User Since
- Mar 24 2015, 9:11 PM (303 w, 5 d)
Nov 26 2020
Nov 25 2020
Nov 24 2020
.Good catch, tanks.
Oct 8 2020
Aug 12 2020
Aug 4 2020
Jul 19 2020
Jul 9 2020
Jul 6 2020
Jul 5 2020
Jul 4 2020
__assert_unreachable in correct place
Use __assert_unreachable().
Shorten the code by two LOC.
Use atomic_load
Use correct diff this time…
Address /some/ comments.
Jul 3 2020
Jun 27 2020
Address comments.
Not really, no. This one was found with a power of grep while searching for NEEDGIANT nodes.
Jun 25 2020
Jun 24 2020
As mentioned on irc, I believe we're bound by the already defined exit codes, as describes in section EXIT STATUS of bhyve(8).
Jun 23 2020
Update man page.
Jun 21 2020
Jun 20 2020
I was thinking about that too as there is no in-tree driver that support that call anyway, but bsnmpd have an option to query it if the driver supports it, so it'd have to be removed too. Anyway, it's probably task for another patch.
Jun 18 2020
May 29 2020
ACK. Wasn't sure about the JAIL_ATTACH namespace anyway.
May 28 2020
May 16 2020
May 1 2020
Guys, thanks for the constructive comments.
Apr 26 2020
I was told 2.5 years ago that jail_attach(2) is insecure and I shouldn't use it. Apparently it's no longer the case - see for example rS360356. Can I please have it accepted now?
Apr 15 2020
Apr 14 2020
Nice one. LGTM.
Apr 1 2020
Mar 3 2020
Mar 2 2020
Feb 27 2020
OK, I'll mark them as mpsafe in a commit.
Feb 26 2020
Use full context diff.
Commited as rS358333
Sync with rS358330 and split sys/dev/random bits to a separate review for so@ approval.
Feb 25 2020
That it'll not be run more than one at a time (from userspace).
No, because the sysctl handler was running under Giant implicitly (as it wasn't marked as MPSAFE).
Feb 24 2020
Committed as rS358286.