Page MenuHomeFreeBSD

kaktus (Paweł Biernacki)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2015, 9:11 PM (252 w, 1 d)

Recent Activity

Fri, Jan 17

kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

OK, I'll cut it into smaller batches.

Fri, Jan 17, 5:02 PM
kaktus added inline comments to D23110: Introduce CTLFLAG_NEEDGIANT.
Fri, Jan 17, 10:14 AM

Thu, Jan 16

kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Oops! Include proper diff.

Thu, Jan 16, 5:10 PM
kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Mark few more nodes.

Thu, Jan 16, 5:08 PM
kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Don't mark sysctl's that are already MPSAFE as NEEDGIANT.

Thu, Jan 16, 2:19 PM
kaktus added a reviewer for D23110: Introduce CTLFLAG_NEEDGIANT: manpages.
Thu, Jan 16, 2:02 PM
kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Create macro to add MPSAFE flag for SYSCTL_NODEs that are not marked as NEEDGIANT instead of correcting every single entry.

Thu, Jan 16, 2:02 PM

Wed, Jan 15

kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

Because the write path in sysctl_handle_string() and sysctl_handle_opaque() isn't locked yet?

Wed, Jan 15, 1:03 PM
kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Mark everything that was left since the last revision.

Wed, Jan 15, 11:16 AM
kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

If it is only annotating something for a group of deverlopers, I'd suggest an inline comment in all the files.

Wed, Jan 15, 11:10 AM

Sun, Jan 12

kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Mark all SYSCTL_NODEs using custom handler and not already marked as MPSAFE as CTLFLAG_NEEDGIANT.
Mark all SYSCTL_NODEs with NULL handler as MPSAFE.

Sun, Jan 12, 5:43 PM
kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

A question because I should update my tools.
If a node has not the CLT_MFSAFE flags then it has to have the CTL_NEEDGIANT, is it right?

Sun, Jan 12, 5:33 PM

Fri, Jan 10

kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

Yes, many of the sysctls can be trivially be made / already are but aren't marked as MPSAFE but this was mostly sed + vim macros + a bit of manual fixes to add the flag where MPSAFE isn't set (yet).
The question is: should fixing this be done in this (already huge) diff or as a separate work later.

Fri, Jan 10, 10:37 AM

Thu, Jan 9

kaktus added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

I'm not going to die for a name, but! we still have D_NEEDGIANT and the name still describe what is being done in this case.

Thu, Jan 9, 9:46 PM
kaktus updated the diff for D23110: Introduce CTLFLAG_NEEDGIANT.

Fix few typos and be more consistent on style(9).

Thu, Jan 9, 9:40 PM
kaktus created D23110: Introduce CTLFLAG_NEEDGIANT.
Thu, Jan 9, 7:04 PM

Wed, Jan 8

kaktus added a comment to D23095: malloc_domain(): return the allocation size to the caller..

lgtm, at least from the vmstat -m perspective

Wed, Jan 8, 9:43 PM

Mon, Jan 6

kaktus closed D23056: kern_sysctl: make sysctl.debug work as intended.
Mon, Jan 6, 7:48 PM
kaktus committed rS356425: kern_sysctl: make sysctl.debug work as intended.
kern_sysctl: make sysctl.debug work as intended
Mon, Jan 6, 7:48 PM
kaktus retitled D23056: kern_sysctl: make sysctl.debug work as intended from kern_sysctl: make SYSTCL_DEBUG work again to kern_sysctl: make sysctl.debug work as intended.
Mon, Jan 6, 6:52 PM
kaktus added a reviewer for D23056: kern_sysctl: make sysctl.debug work as intended: emaste.
Mon, Jan 6, 6:30 PM
kaktus created D23056: kern_sysctl: make sysctl.debug work as intended.
Mon, Jan 6, 6:28 PM
kaktus closed D23039: sysctl: mark more nodes as MPSAFE.
Mon, Jan 6, 10:52 AM
kaktus committed rS356413: sysctl: mark more nodes as MPSAFE.
sysctl: mark more nodes as MPSAFE
Mon, Jan 6, 10:52 AM

Sun, Jan 5

kaktus created D23039: sysctl: mark more nodes as MPSAFE.
Sun, Jan 5, 10:28 AM

Thu, Jan 2

kaktus committed rS356262: sysctl: hide 2.x era compat node.
sysctl: hide 2.x era compat node
Thu, Jan 2, 1:24 AM
kaktus closed D22982: sysctl: hide 2.x era compat node.
Thu, Jan 2, 1:24 AM

Wed, Jan 1

kaktus updated the diff for D22982: sysctl: hide 2.x era compat node.

Update diff to use CTLFLAG_SKIP instead of completely removing KERN_DUMMY.

Wed, Jan 1, 2:37 PM

Tue, Dec 31

kaktus added a comment to D22982: sysctl: hide 2.x era compat node.

No problems, no. I understand that it was introduced as a combat for 3rd party binaries that hardcoded 1.31 as the oid, but the value 0 isn't helpful either.
How about CTLFLAG_SKIP so it wouldn't show up in sysctl(8) list?

Tue, Dec 31, 9:45 PM
kaktus updated the diff for D22982: sysctl: hide 2.x era compat node.

update diff

Tue, Dec 31, 12:35 PM
kaktus created D22982: sysctl: hide 2.x era compat node.
Tue, Dec 31, 12:29 PM

Mon, Dec 30

kaktus closed D22959: linux(4): implement copy_file_range(2).
Mon, Dec 30, 6:11 PM
kaktus committed rS356206: linux(4): implement copy_file_range(2).
linux(4): implement copy_file_range(2)
Mon, Dec 30, 6:11 PM
kaktus updated the diff for D22959: linux(4): implement copy_file_range(2).

Make the comment style(9) friendly.

Mon, Dec 30, 1:15 AM
kaktus updated the summary of D22959: linux(4): implement copy_file_range(2).
Mon, Dec 30, 12:48 AM
kaktus updated the diff for D22959: linux(4): implement copy_file_range(2).

Check if the flags provided are supported, otherwise return EINVAL.

Mon, Dec 30, 12:46 AM

Sun, Dec 29

kaktus added a comment to D22959: linux(4): implement copy_file_range(2).

There are no flags defined for now and kern_copy_file_range explicitly checks for flags != 0.
But if it's a problem, I can add a local flag variable and set it to 0 because this is what we support for now anyway.

Sun, Dec 29, 11:29 PM
kaktus created D22959: linux(4): implement copy_file_range(2).
Sun, Dec 29, 6:17 PM
kaktus committed rS356179: sysctlbyname(2): Remove temporary compatibility layer.
sysctlbyname(2): Remove temporary compatibility layer
Sun, Dec 29, 5:20 PM
kaktus closed D22958: sysctlbyname(2): Remove temporary compatibility layer.
Sun, Dec 29, 5:20 PM
kaktus added a comment to D22958: sysctlbyname(2): Remove temporary compatibility layer.
% file 12.1/bin/df
12.1/bin/df: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.1, FreeBSD-style, stripped
Sun, Dec 29, 4:00 PM
kaktus updated the diff for D22958: sysctlbyname(2): Remove temporary compatibility layer.

Remove the now unneeded include of libc_private.h too.

Sun, Dec 29, 3:21 PM
kaktus created D22958: sysctlbyname(2): Remove temporary compatibility layer.
Sun, Dec 29, 3:05 PM

Oct 1 2019

kaktus added a comment to D21724: Move simple_httpd out of picobsd, add HTTPD option.

But there is also dma, sendmail and parts of kerberos… :-)

Oct 1 2019, 5:03 PM
kaktus added a comment to D21724: Move simple_httpd out of picobsd, add HTTPD option.

Wouldn't /usr/libexec be a better place for it, like for many other such daemons (like fingerd etc…)?

Oct 1 2019, 4:43 PM

Sep 30 2019

kaktus committed rS352914: linux_renameat2: don't add extra \n on error..
linux_renameat2: don't add extra \n on error.
Sep 30 2019, 7:05 PM
kaktus closed D21852: linux_renameat2: don't add extra \n on error.
Sep 30 2019, 7:05 PM
kaktus closed D21706: libsysdecode: decode PROT_MAX allocations.
Sep 30 2019, 7:03 PM
kaktus committed rS352913: libsysdecode: decode PROT_MAX flags.
libsysdecode: decode PROT_MAX flags
Sep 30 2019, 7:03 PM
kaktus created D21852: linux_renameat2: don't add extra \n on error.
Sep 30 2019, 3:39 PM

Sep 27 2019

kaktus closed D21811: Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:19 AM
kaktus committed rS352791: Add myself (kaktus) as a src commiter..
Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:19 AM
kaktus committed rD53439: Add myself (kaktus) as a src commiter.
Add myself (kaktus) as a src commiter
Sep 27 2019, 10:17 AM
kaktus closed D21810: Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:17 AM

Sep 26 2019

kaktus updated the summary of D21706: libsysdecode: decode PROT_MAX allocations.
Sep 26 2019, 8:38 PM
kaktus retitled D21706: libsysdecode: decode PROT_MAX allocations from truss and ktrace should decode PROT_MAX allocations to libsysdecode: decode PROT_MAX allocations.
Sep 26 2019, 8:33 PM
kaktus updated the diff for D21811: Add myself (kaktus) as a src commiter.

sort it alphabetically, actually

Sep 26 2019, 8:22 PM
kaktus retitled D21811: Add myself (kaktus) as a src commiter from add myself to src/ to Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:12 PM
kaktus retitled D21810: Add myself (kaktus) as a src commiter from add myself to doc/ to Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:12 PM
kaktus created D21811: Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:02 PM
kaktus created D21810: Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:00 PM
lwhsu renamed kaktus from pawel.biernacki-gmail.com to kaktus.
Sep 26 2019, 6:39 PM

Sep 19 2019

kaktus created D21715: libntp: build with closefrom.
Sep 19 2019, 2:01 PM
kaktus updated the diff for D21706: libsysdecode: decode PROT_MAX allocations.

rewrite the return path

Sep 19 2019, 10:25 AM

Sep 18 2019

kaktus updated the summary of D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 9:43 PM
kaktus added inline comments to D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 9:40 PM
kaktus updated the diff for D21706: libsysdecode: decode PROT_MAX allocations.

don't return too early

Sep 18 2019, 9:39 PM
kaktus created D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 7:12 PM
kaktus updated the diff for D21688: make truss decode sysctl names.

Style and s/Int/Sizet/ where appropriate.

Sep 18 2019, 11:25 AM
kaktus updated the diff for D21688: make truss decode sysctl names.

Address @kib comments.

Sep 18 2019, 8:34 AM
kaktus updated the diff for D21693: sysctl: use names instead of magic numbers.

Add space after comma.

Sep 18 2019, 8:30 AM

Sep 17 2019

kaktus added inline comments to D21688: make truss decode sysctl names.
Sep 17 2019, 11:00 PM
kaktus updated the summary of D21688: make truss decode sysctl names.
Sep 17 2019, 11:00 PM
kaktus updated the diff for D21688: make truss decode sysctl names.

Use constants defined in D21693.

Sep 17 2019, 10:57 PM
kaktus created D21693: sysctl: use names instead of magic numbers.
Sep 17 2019, 10:55 PM
kaktus created D21688: make truss decode sysctl names.
Sep 17 2019, 1:56 PM

Sep 2 2019

kaktus updated the diff for D17282: new syscall: __sysctlbyname.

add a missing file

Sep 2 2019, 1:52 PM

Aug 27 2019

kaktus created D21445: library should not modify global process state by calling sigaction(2).
Aug 27 2019, 10:32 PM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Aug 27 2019, 6:39 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Address @kib's comments.

Aug 27 2019, 6:39 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Update to r351542 and bump __FreeBSD_version again.

Aug 27 2019, 9:04 AM

Aug 26 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Add a lightweight compat layer in libc.

Aug 26 2019, 11:17 AM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Aug 26 2019, 9:06 AM

Aug 25 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Check for ENOSYS.

Aug 25 2019, 11:19 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Split the function for one that do the actual work and teach sys___sysctlbyname and freebsd32___sysctlbyname to call it properly.

Aug 25 2019, 11:08 PM

Aug 21 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Update diff to r351302 and address some comments.

Aug 21 2019, 8:42 PM

Mar 17 2019

kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.

I confirm that it works.

Mar 17 2019, 1:10 AM

Mar 16 2019

kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.
% cat /etc/rc.conf
clear_tmp_enable="YES"
syslogd_flags="-ss"
sendmail_enable="NONE"
hostname="devel2"
ifconfig_vtnet0="DHCP"
sshd_enable="YES"
ntpd_enable="YES"
dumpdev="AUTO"
zfs_enable="YES"
Mar 16 2019, 4:10 PM
kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.

This breaks ifconfig_DEFAULT="DHCP" somehow. It works with either SYNCDHCP or this commit reverted.

Mar 16 2019, 1:27 PM

Sep 25 2018

kaktus updated the diff for D17282: new syscall: __sysctlbyname.

Update diff with minor fixes.

Sep 25 2018, 1:43 PM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Sep 25 2018, 1:41 PM

Sep 22 2018

kaktus updated the diff for D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:52 AM
kaktus created D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:43 AM

Dec 23 2017

kaktus updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Man: start a sentence from new line.

Dec 23 2017, 7:15 PM · tests
kaktus updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Add CAVEATS section to the man page to point out the rounding issue with too short buffers.

Dec 23 2017, 6:09 PM · tests
kaktus added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#284349, @kib wrote:

In one branch of the snprintf() use, we add divisor / 2 and remainder * 10, not remainder. Does this case need to be handled differently ?

Dec 23 2017, 6:07 PM · tests

Dec 22 2017

kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:37 PM · tests
kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:30 PM · tests
kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:08 PM · tests

Dec 21 2017

kaktus added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Dec 21 2017, 10:07 PM · tests