User Details
User Details
- User Since
- Mar 24 2015, 9:11 PM (348 w, 5 d)
Jul 31 2021
Jul 31 2021
kaktus added inline comments to D31056: time.h: reduce CLOCK_ namespace pollution, move to _clock_id.h.
Nov 26 2020
Nov 26 2020
libsysdecode: account for invalid protection flags
Nov 25 2020
Nov 25 2020
libsysdecode: correctly decode mmap flags
Nov 24 2020
Nov 24 2020
kaktus added a comment to D27312: libsysdecode: PROT_MAX() decoding bug.
.Good catch, tanks.
Oct 8 2020
Oct 8 2020
[pf] /etc/rc.d/pf should REQUIRE routing
Aug 12 2020
Aug 12 2020
kaktus committed rS364150: MFC userland part of r351729.
MFC userland part of r351729
Aug 4 2020
Aug 4 2020
kaktus committed rS363832: MFC kernel part of r351729.
MFC kernel part of r351729
Jul 19 2020
Jul 19 2020
Jul 9 2020
Jul 9 2020
Jul 6 2020
Jul 6 2020
kern.tty_info_kstacks: set compact format as default
kern.tty_info_kstacks: add a compact format
Jul 5 2020
Jul 5 2020
truss: print more information about traced sysctls
Jul 4 2020
Jul 4 2020
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
__assert_unreachable in correct place
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
Use __assert_unreachable().
Shorten the code by two LOC.
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
dev.ixl.<N>.debug: mark as MPSAFE
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
Use atomic_load
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
Use correct diff this time…
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
Address /some/ comments.
Jul 3 2020
Jul 3 2020
Jun 27 2020
Jun 27 2020
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.
Address comments.
kaktus added a comment to D25408: dev.ixl.<N>.debug: mark as MPSAFE.
Not really, no. This one was found with a power of grep while searching for NEEDGIANT nodes.
kaktus requested review of D25487: kern.tty_info_kstacks: add a compact format.
Jun 25 2020
Jun 25 2020
bhyve: allow for automatic destruction on power-off
man page of select(2) should mention pselect(2)
Jun 24 2020
Jun 24 2020
kaktus added a comment to D25414: bhyve: allow for automatic destruction on power-off.
As mentioned on irc, I believe we're bound by the already defined exit codes, as describes in section EXIT STATUS of bhyve(8).
Jun 23 2020
Jun 23 2020
kaktus updated the diff for D25414: bhyve: allow for automatic destruction on power-off.
Update man page.
kaktus requested review of D25414: bhyve: allow for automatic destruction on power-off.
kaktus requested review of D25408: dev.ixl.<N>.debug: mark as MPSAFE.
kaktus requested review of D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
kaktus requested review of D25169: man page of select(2) should mention pselect(2).
Jun 21 2020
Jun 21 2020
net.link.generic.ifdata.<ifindex>.linkspecific: rework handler
Jun 20 2020
Jun 20 2020
kaktus added a comment to D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
I was thinking about that too as there is no in-tree driver that support that call anyway, but bsnmpd have an option to query it if the driver supports it, so it'd have to be removed too. Anyway, it's probably task for another patch.
Jun 18 2020
Jun 18 2020
kaktus added inline comments to D25351: Document that umount -A does not unmount /dev.
kaktus committed rS362343: hw.bus.info: rework handler.
hw.bus.info: rework handler
kaktus requested review of D25321: hw.bus.info: rework handler.
May 29 2020
May 29 2020
kaktus added a comment to D25041: Add jail_attach2 syscall.
ACK. Wasn't sure about the JAIL_ATTACH namespace anyway.
May 28 2020
May 28 2020
kaktus requested review of D25041: Add jail_attach2 syscall.
May 16 2020
May 16 2020
sysctl: fix setting net.isr.dispatch during early boot
kaktus updated the summary of D24858: fix setting net.isr.dispatch during early boot.
kaktus requested review of D24858: fix setting net.isr.dispatch during early boot.
May 1 2020
May 1 2020
kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.
Guys, thanks for the constructive comments.
Apr 26 2020
Apr 26 2020
kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.
I was told 2.5 years ago that jail_attach(2) is insecure and I shouldn't use it. Apparently it's no longer the case - see for example rS360356. Can I please have it accepted now?
kaktus retitled D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0 from Enable VNET operations for ifconfig and route to ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.
Apr 15 2020
Apr 15 2020
sysctl_handle_string: Put logical or in parentheses.
sysctl(9): fix handling string tunables.
kaktus updated the summary of D24429: sysctl(9): fix handling string tunables.
kaktus updated the summary of D24429: sysctl(9): fix handling string tunables.
Apr 14 2020
Apr 14 2020
Nice one. LGTM.
Apr 1 2020
Apr 1 2020
Mar 3 2020
Mar 3 2020
kaktus added a reviewer for D23935: New port: security/py-angr: multi-architecture binary analysis toolkit: kaktus.
kaktus added inline comments to D23935: New port: security/py-angr: multi-architecture binary analysis toolkit.
Mar 2 2020
Mar 2 2020
kaktus committed rS358548: sys/: Document few more sysctls..
sys/: Document few more sysctls.
Feb 27 2020
Feb 27 2020
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many)
kaktus added a comment to D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
OK, I'll mark them as mpsafe in a commit.
Feb 26 2020
Feb 26 2020
kaktus updated the diff for D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Use full context diff.
kaktus committed rS358334: Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be.
Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be
kaktus added a comment to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Commited as rS358333
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)
kaktus updated the diff for D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Sync with rS358330 and split sys/dev/random bits to a separate review for so@ approval.
Feb 25 2020
Feb 25 2020
kaktus added a comment to D23839: Make ipf sysctl mpsafe.
That it'll not be run more than one at a time (from userspace).
kaktus added a comment to D23839: Make ipf sysctl mpsafe.
No, because the sysctl handler was running under Giant implicitly (as it wasn't marked as MPSAFE).
SYSCTL_ROOT_NODE should use the SYSCTL_ENFORCE_FLAGS macro too.
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (16 of many)
Feb 24 2020
Feb 24 2020
kaktus added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Committed as rS358286.
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (15 of many)
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (14 of many)