Page MenuHomeFreeBSD

kaktus (Paweł Biernacki)
User

Projects

User Details

User Since
Mar 24 2015, 9:11 PM (473 w, 7 h)

Recent Activity

May 7 2023

kaktus added inline comments to D25155: CISS: Support >48 JBOD drives, fix SES enumeration, no panic on unplug, sysctl tunables &more verbosity....
May 7 2023, 8:03 PM

May 1 2023

kaktus added a comment to D39440: fparseln(3) reduce diff against NetBSD.

I think this seems fine, dropping the 3rd and 4th clauses certainly. Is there something that motivated the macro addition, or just diff reduction against NetBSD?

May 1 2023, 7:16 PM

Apr 6 2023

kaktus added inline comments to D39440: fparseln(3) reduce diff against NetBSD.
Apr 6 2023, 9:22 AM
kaktus updated the diff for D39440: fparseln(3) reduce diff against NetBSD.
Apr 6 2023, 9:21 AM

Apr 5 2023

kaktus requested review of D39440: fparseln(3) reduce diff against NetBSD.
Apr 5 2023, 8:15 PM

Mar 13 2023

kaktus committed rG35b6e52c30a2: net.inet6.ip6.log_interval: use ppsratecheck(9) internally (authored by kaktus).
net.inet6.ip6.log_interval: use ppsratecheck(9) internally
Mar 13 2023, 4:50 PM
kaktus closed D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally.
Mar 13 2023, 4:50 PM
kaktus closed D38644: netinet6: allow disabling excess log messages.
Mar 13 2023, 4:50 PM
kaktus committed rG3eaffc626589: netinet6: allow disabling excess log messages (authored by kaktus).
netinet6: allow disabling excess log messages
Mar 13 2023, 4:50 PM

Mar 2 2023

kaktus updated the diff for D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally.

Make all virtualised variables static and only expose ip6_log_ratelimit() function.

Mar 2 2023, 11:02 AM

Feb 28 2023

kaktus updated subscribers of D38644: netinet6: allow disabling excess log messages.
Feb 28 2023, 1:08 PM
kaktus added a comment to D38644: netinet6: allow disabling excess log messages.
In D38644#881703, @mjg wrote:
Feb 28 2023, 1:08 PM
kaktus added a comment to D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally.

This review is a response for a comment made by mjg in D38644 in which I added a sysctl to completely disable such logging on per vnet basis.
The whole logging section appeared in 1999 in one of the KAME commits and since then wasn’t particularly maintained apart of adding vnet support some time ago.
ppsratecheck is used like this is other parts of the kernel, for example in linuxkpi, and apparently is a preferred way to limit certain actions on time basis.

Feb 28 2023, 1:07 PM
kaktus updated subscribers of D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally.
Feb 28 2023, 1:07 PM

Feb 24 2023

kaktus added a reviewer for D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally: mjg.
Feb 24 2023, 4:24 PM
kaktus requested review of D38758: net.inet6.ip6.log_interval: use ppsratecheck(9) inernally.
Feb 24 2023, 4:24 PM

Feb 23 2023

kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.

as requested mention RFC4443 in man page

Feb 23 2023, 12:40 PM

Feb 22 2023

kaktus added inline comments to D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 9:19 PM
kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.

Address comments:

  • by popular demand don't mention firewall
  • update man page wording
Feb 22 2023, 9:19 PM
kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.

Rename to match log statement, stats variable and counter description presented by netstat -s.

Feb 22 2023, 5:24 PM
kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 4:02 PM
kaktus added inline comments to D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 3:56 PM
kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 3:54 PM

Feb 16 2023

kaktus updated the diff for D38644: netinet6: allow disabling excess log messages.
Feb 16 2023, 8:18 PM
kaktus requested review of D38644: netinet6: allow disabling excess log messages.
Feb 16 2023, 6:39 PM

Oct 19 2022

kaktus committed rGa20a02abcdc9: pmc: remove write-only variable (authored by kaktus).
pmc: remove write-only variable
Oct 19 2022, 9:03 PM

Oct 6 2022

kaktus committed R9:0f800b4a8667: Update my GPG key. (authored by kaktus).
Update my GPG key.
Oct 6 2022, 5:23 PM

Feb 8 2022

kaktus accepted D34171: Restore access to "user.*" variables in sysctlbyname().

I agree with @se on this. There was no direct user case before introducing sysctlbyname(2), it worked as an by-effect of implementation of how sysctl(3) handled that.
IMO the issue is in how the user.* is implemented and maybe that should be fixed in the long term, but as a band-aid that version LGTM.

Feb 8 2022, 5:58 PM

Feb 4 2022

kaktus added a comment to D34171: Restore access to "user.*" variables in sysctlbyname().
In D34171#773087, @alfix86_gmail.com wrote:

However, it is strange but real, sysctlbyname() returns 0 but does not set the "value", while sysctlbyname-improved sets "value" correctly:

Feb 4 2022, 9:45 PM
kaktus added inline comments to D34171: Restore access to "user.*" variables in sysctlbyname().
Feb 4 2022, 9:15 PM

Jul 31 2021

kaktus accepted D31369: clock_id: These symbols weren't in 4.4BSD, adjust copyright.

lgtm

Jul 31 2021, 11:54 PM
kaktus added inline comments to D31056: time.h: reduce CLOCK_ namespace pollution, move to _clock_id.h.
Jul 31 2021, 10:30 PM

Nov 26 2020

kaktus committed rS368053: libsysdecode: account for invalid protection flags.
libsysdecode: account for invalid protection flags
Nov 26 2020, 9:08 AM

Nov 25 2020

kaktus closed D27312: libsysdecode: PROT_MAX() decoding bug.
Nov 25 2020, 4:31 PM
kaktus committed rS368022: libsysdecode: correctly decode mmap flags.
libsysdecode: correctly decode mmap flags
Nov 25 2020, 4:31 PM

Nov 24 2020

kaktus added a comment to D27312: libsysdecode: PROT_MAX() decoding bug.

.Good catch, tanks.

Nov 24 2020, 4:06 PM
kaktus accepted D27312: libsysdecode: PROT_MAX() decoding bug.
Nov 24 2020, 4:06 PM

Oct 8 2020

kaktus committed rS366537: [pf] /etc/rc.d/pf should REQUIRE routing.
[pf] /etc/rc.d/pf should REQUIRE routing
Oct 8 2020, 11:45 AM

Aug 12 2020

kaktus committed rS364150: MFC userland part of r351729.
MFC userland part of r351729
Aug 12 2020, 10:03 AM

Aug 4 2020

kaktus committed rS363833: regen.
regen
Aug 4 2020, 12:45 PM
kaktus committed rS363832: MFC kernel part of r351729.
MFC kernel part of r351729
Aug 4 2020, 12:43 PM

Jul 19 2020

kaktus committed rS363326: MFC r362947.
MFC r362947
Jul 19 2020, 3:17 PM

Jul 9 2020

kaktus committed rS363059: MFC r362612.
MFC r362612
Jul 9 2020, 8:55 PM
kaktus committed rS363058: MFC r362612.
MFC r362612
Jul 9 2020, 8:54 PM

Jul 6 2020

kaktus committed rS362969: kern.tty_info_kstacks: set compact format as default.
kern.tty_info_kstacks: set compact format as default
Jul 6 2020, 4:34 PM
kaktus committed rS362967: kern.tty_info_kstacks: add a compact format.
kern.tty_info_kstacks: add a compact format
Jul 6 2020, 4:33 PM
kaktus closed D25487: kern.tty_info_kstacks: add a compact format.
Jul 6 2020, 4:33 PM

Jul 5 2020

kaktus committed rS362947: truss: print more information about traced sysctls.
truss: print more information about traced sysctls
Jul 5 2020, 7:54 PM

Jul 4 2020

kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

__assert_unreachable in correct place

Jul 4 2020, 7:26 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use __assert_unreachable().
Shorten the code by two LOC.

Jul 4 2020, 7:11 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 6:56 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 6:48 PM
kaktus committed rS362932: dev.ixl.<N>.debug: mark as MPSAFE.
dev.ixl.<N>.debug: mark as MPSAFE
Jul 4 2020, 2:20 PM
kaktus closed D25408: dev.ixl.<N>.debug: mark as MPSAFE.
Jul 4 2020, 2:20 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use atomic_load

Jul 4 2020, 11:05 AM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Use correct diff this time…

Jul 4 2020, 10:39 AM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jul 4 2020, 10:37 AM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Address /some/ comments.

Jul 4 2020, 10:35 AM

Jul 3 2020

kaktus committed rS362912: MFC r362611.
MFC r362611
Jul 3 2020, 11:46 AM
kaktus committed rS362911: MFC r362611.
MFC r362611
Jul 3 2020, 11:44 AM

Jun 27 2020

kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 5:20 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 4:50 PM
kaktus added inline comments to D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 4:23 PM
kaktus updated the diff for D25487: kern.tty_info_kstacks: add a compact format.

Address comments.

Jun 27 2020, 4:19 PM
kaktus added a reviewer for D25408: dev.ixl.<N>.debug: mark as MPSAFE: mjg.
Jun 27 2020, 4:11 PM
kaktus added a comment to D25408: dev.ixl.<N>.debug: mark as MPSAFE.

Not really, no. This one was found with a power of grep while searching for NEEDGIANT nodes.

Jun 27 2020, 4:11 PM
kaktus requested review of D25487: kern.tty_info_kstacks: add a compact format.
Jun 27 2020, 2:01 PM

Jun 25 2020

kaktus closed D25414: bhyve: allow for automatic destruction on power-off.
Jun 25 2020, 12:35 PM
kaktus committed rS362612: bhyve: allow for automatic destruction on power-off.
bhyve: allow for automatic destruction on power-off
Jun 25 2020, 12:35 PM
kaktus closed D25169: man page of select(2) should mention pselect(2).
Jun 25 2020, 12:31 PM
kaktus committed rS362611: man page of select(2) should mention pselect(2).
man page of select(2) should mention pselect(2)
Jun 25 2020, 12:31 PM

Jun 24 2020

kaktus added a comment to D25414: bhyve: allow for automatic destruction on power-off.

As mentioned on irc, I believe we're bound by the already defined exit codes, as describes in section EXIT STATUS of bhyve(8).

Jun 24 2020, 7:35 PM

Jun 23 2020

kaktus updated the diff for D25414: bhyve: allow for automatic destruction on power-off.

Update man page.

Jun 23 2020, 10:05 PM
kaktus requested review of D25414: bhyve: allow for automatic destruction on power-off.
Jun 23 2020, 5:58 PM
kaktus requested review of D25408: dev.ixl.<N>.debug: mark as MPSAFE.
Jun 23 2020, 10:03 AM
kaktus requested review of D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
Jun 23 2020, 3:27 AM
kaktus closed D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
Jun 23 2020, 3:22 AM
kaktus requested review of D25169: man page of select(2) should mention pselect(2).
Jun 23 2020, 3:21 AM

Jun 21 2020

kaktus committed rS362468: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.
net.link.generic.ifdata.<ifindex>.linkspecific: rework handler
Jun 21 2020, 6:40 PM
kaktus accepted D23942: Document that gettimeofday() is obsolescent.
Jun 21 2020, 9:36 AM

Jun 20 2020

kaktus added a comment to D25348: net.link.generic.ifdata.<ifindex>.linkspecific: rework handler.

I was thinking about that too as there is no in-tree driver that support that call anyway, but bsnmpd have an option to query it if the driver supports it, so it'd have to be removed too. Anyway, it's probably task for another patch.

Jun 20 2020, 7:36 PM

Jun 18 2020

kaktus accepted D25351: Document that umount -A does not unmount /dev.
Jun 18 2020, 11:07 PM
kaktus added inline comments to D25351: Document that umount -A does not unmount /dev.
Jun 18 2020, 10:38 PM
kaktus closed D25321: hw.bus.info: rework handler.
Jun 18 2020, 9:43 PM
kaktus committed rS362343: hw.bus.info: rework handler.
hw.bus.info: rework handler
Jun 18 2020, 9:43 PM
kaktus requested review of D25321: hw.bus.info: rework handler.
Jun 18 2020, 9:18 AM

May 29 2020

kaktus added a comment to D25041: Add jail_attach2 syscall.

ACK. Wasn't sure about the JAIL_ATTACH namespace anyway.

May 29 2020, 9:19 AM
kaktus added a comment to D25041: Add jail_attach2 syscall.
In D25041#551522, @mjg wrote:

Disabling ptrace should not be an option, it should be mandatory no matter what.

May 29 2020, 9:19 AM

May 28 2020

kaktus requested review of D25041: Add jail_attach2 syscall.
May 28 2020, 9:33 PM

May 16 2020

kaktus committed rS361113: sysctl: fix setting net.isr.dispatch during early boot.
sysctl: fix setting net.isr.dispatch during early boot
May 16 2020, 5:06 PM
kaktus closed D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 5:06 PM
kaktus updated the summary of D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 10:09 AM
kaktus requested review of D24858: fix setting net.isr.dispatch during early boot.
May 16 2020, 10:00 AM

May 1 2020

kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.

Guys, thanks for the constructive comments.

May 1 2020, 4:47 PM · network

Apr 26 2020

kaktus added a comment to D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.

I was told 2.5 years ago that jail_attach(2) is insecure and I shouldn't use it. Apparently it's no longer the case - see for example rS360356. Can I please have it accepted now?

Apr 26 2020, 10:46 PM · network
kaktus retitled D9649: ifconfig(8) and route(8) should be able to manage vnet configurations from prison0 from Enable VNET operations for ifconfig and route to ifconfig(8) and route(8) should be able to manage vnet configurations from prison0.
Apr 26 2020, 10:46 PM · network

Apr 15 2020

kaktus committed rS359976: sysctl_handle_string: Put logical or in parentheses..
sysctl_handle_string: Put logical or in parentheses.
Apr 15 2020, 4:55 PM
kaktus closed D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 4:34 PM
kaktus committed rS359975: sysctl(9): fix handling string tunables..
sysctl(9): fix handling string tunables.
Apr 15 2020, 4:34 PM
kaktus updated the summary of D24429: sysctl(9): fix handling string tunables.
Apr 15 2020, 10:49 AM