Page MenuHomeFreeBSD

kaktus (Paweł Biernacki)
User

Projects

User Details

User Since
Mar 24 2015, 9:11 PM (261 w, 4 d)

Recent Activity

Tue, Mar 3

kaktus added a reviewer for D23935: New port: security/py-angr: multi-architecture binary analysis toolkit: kaktus.
Tue, Mar 3, 1:16 AM
kaktus added inline comments to D23935: New port: security/py-angr: multi-architecture binary analysis toolkit.
Tue, Mar 3, 1:16 AM

Mon, Mar 2

kaktus committed rS358548: sys/: Document few more sysctls..
sys/: Document few more sysctls.
Mon, Mar 2, 3:31 PM
kaktus closed D23759: Add many sysctl descriptions in kern.
Mon, Mar 2, 3:31 PM
kaktus accepted D23759: Add many sysctl descriptions in kern.
Mon, Mar 2, 3:28 PM
kaktus added a reviewer for D23759: Add many sysctl descriptions in kern: kaktus.
Mon, Mar 2, 2:34 PM

Feb 27 2020

kaktus committed rS358379: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many)
Feb 27 2020, 1:12 PM
kaktus closed D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 27 2020, 1:12 PM
kaktus added a comment to D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

OK, I'll mark them as mpsafe in a commit.

Feb 27 2020, 1:04 PM

Feb 26 2020

kaktus updated the diff for D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Use full context diff.

Feb 26 2020, 3:19 PM
kaktus created D23841: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 26 2020, 3:17 PM
kaktus committed rS358334: Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be.
Move the SYSCTL_ENFORCE_FLAGS to SYSCTL_NODE_WITH_LABEL where it should be
Feb 26 2020, 3:12 PM
kaktus added a comment to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Commited as rS358333

Feb 26 2020, 2:51 PM
kaktus committed rS358333: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)
Feb 26 2020, 2:28 PM
kaktus updated the diff for D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Sync with rS358330 and split sys/dev/random bits to a separate review for so@ approval.

Feb 26 2020, 1:59 PM

Feb 25 2020

kaktus added a comment to D23839: Make ipf sysctl mpsafe.

That it'll not be run more than one at a time (from userspace).

Feb 25 2020, 9:48 PM
kaktus accepted D23839: Make ipf sysctl mpsafe.
Feb 25 2020, 9:05 PM
kaktus added a comment to D23839: Make ipf sysctl mpsafe.

No, because the sysctl handler was running under Giant implicitly (as it wasn't marked as MPSAFE).

Feb 25 2020, 9:05 PM
kaktus committed rS358318: SYSCTL_ROOT_NODE should use the SYSCTL_ENFORCE_FLAGS macro too..
SYSCTL_ROOT_NODE should use the SYSCTL_ENFORCE_FLAGS macro too.
Feb 25 2020, 7:13 PM
kaktus committed rS358316: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (16 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (16 of many)
Feb 25 2020, 7:04 PM
kaktus closed D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 25 2020, 7:04 PM

Feb 24 2020

kaktus closed D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:56 AM
kaktus accepted D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:56 AM
kaktus added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Committed as rS358286.

Feb 24 2020, 10:54 AM
kaktus committed rS358286: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (15 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (15 of many)
Feb 24 2020, 10:51 AM
kaktus committed rS358285: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (14 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (14 of many)
Feb 24 2020, 10:47 AM
kaktus closed D23639: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:47 AM
kaktus committed rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many)
Feb 24 2020, 10:45 AM
kaktus closed D23635: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:45 AM
kaktus committed rS358283: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (12 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (12 of many)
Feb 24 2020, 10:43 AM
kaktus closed D23637: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:43 AM
kaktus committed rS358280: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many)
Feb 24 2020, 10:41 AM
kaktus closed D23636: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:41 AM
kaktus committed rS358277: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (10 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (10 of many)
Feb 24 2020, 10:38 AM
kaktus closed D23629: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:38 AM
kaktus committed rS358276: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (8 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (8 of many)
Feb 24 2020, 10:36 AM
kaktus closed D23628: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:36 AM
kaktus committed rS358275: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (8 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (8 of many)
Feb 24 2020, 10:33 AM
kaktus closed D23627: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 24 2020, 10:33 AM

Feb 21 2020

kaktus committed rS358224: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (7 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (7 of many)
Feb 21 2020, 4:32 PM
kaktus closed D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 21 2020, 4:32 PM
kaktus committed rS358223: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (6 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (6 of many)
Feb 21 2020, 4:23 PM
kaktus closed D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 21 2020, 4:23 PM
kaktus added a comment to D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

That is the plan - document current state now, review and fix what have to be fixed later. The flag itself doesn't change anything, it's just a more explicit way of showing that the handler may be not-MPSAFE.

Feb 21 2020, 3:45 PM

Feb 20 2020

kaktus updated the diff for D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Address comments and update to rS358167.

Feb 20 2020, 3:49 PM
kaktus updated the diff for D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Use correct diff.

Feb 20 2020, 3:17 PM
kaktus updated the diff for D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Update diff.

Feb 20 2020, 3:15 PM
kaktus added inline comments to D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 20 2020, 3:14 PM
kaktus updated the diff for D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Add missed file.

Feb 20 2020, 1:37 PM
kaktus updated the diff for D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Address comments.

Feb 20 2020, 1:34 PM
kaktus added inline comments to D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 20 2020, 1:33 PM
kaktus updated the diff for D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Address comments.

Feb 20 2020, 1:09 PM
kaktus updated the diff for D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Upload the correct patch.

Feb 20 2020, 1:08 PM
kaktus updated the diff for D23626: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Address comments.

Feb 20 2020, 1:02 PM

Feb 19 2020

kaktus added inline comments to D23759: Add many sysctl descriptions in kern.
Feb 19 2020, 8:06 PM
kaktus added a reviewer for D23759: Add many sysctl descriptions in kern: docs.
Feb 19 2020, 8:04 PM
kaktus accepted D23733: Teach libsysdecode/kdump/truss about shm_open2.

Although it'd be nice to decode the first argument in ktrace/kdump case just like truss does it here.

Feb 19 2020, 2:06 PM

Feb 16 2020

kaktus added inline comments to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 9:39 PM
kaktus updated the diff for D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Address comments and fix many more obvious cases.

Feb 16 2020, 9:27 PM
kaktus added a comment to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Generic comment: maybe it would be better to commit all non-leaf nodes CTLFLAG_MPSAFE changes and let the reviews look into the real cases where CTLFLAG_NEEDGIANT is necessary?

Feb 16 2020, 9:07 PM
kaktus updated the summary of D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 5:37 PM
kaktus updated the summary of D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 5:37 PM
kaktus abandoned D23110: Introduce CTLFLAG_NEEDGIANT.

This work has been split for several smaller batches: D23378, D23625 D23626 D23627 D23628 D23629 D23630 D23631 D23632 D23633 D23634 D23635 D23636 D23637 D23638 D23639 D23640, D23678 and D23718

Feb 16 2020, 5:19 PM
kaktus committed rS358004: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (5 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (5 of many)
Feb 16 2020, 5:12 PM
kaktus closed D23633: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 5:12 PM
kaktus closed D23632: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 5:07 PM
kaktus added a comment to D23632: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

That was committed in rS357972 and should be auto-closed.

Feb 16 2020, 5:07 PM
kaktus added inline comments to D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 5:02 PM
kaktus created D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 4:41 PM
kaktus updated the diff for D23636: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

This sysctl is MPSAFE.

Feb 16 2020, 4:02 PM
kaktus added inline comments to D23634: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 11:50 AM
kaktus added inline comments to D23636: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 11:34 AM
kaktus added inline comments to D23633: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 11:33 AM
kaktus added inline comments to D23635: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 16 2020, 11:30 AM

Feb 15 2020

kaktus committed rS357974: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (4 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (4 of many)
Feb 15 2020, 6:58 PM
kaktus closed D23625: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 15 2020, 6:58 PM
kaktus closed D23631: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 15 2020, 6:55 PM
kaktus committed rS357973: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many)
Feb 15 2020, 6:55 PM
kaktus committed rS357972: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many)
Feb 15 2020, 6:52 PM
kaktus committed rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many).
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many)
Feb 15 2020, 6:48 PM
kaktus closed D23640: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 15 2020, 6:48 PM
kaktus added a comment to D23675: The SYSCTL_NODE / MPSAFE / NEEDGIANT saga.

The amount of work to change the SYSCTL_NODEs with handlers into SYSCTL_PROCs and remove the handler from SYSCTL_NODEs will cause a lot more code changes.
Yes it'll limit the amount of CTLFLAG_MPSAFE being added (and later removed) to SYSCTL_NODEs without handlers.
But the question of should SYSCTL_NODEs be allowed to have handlers is a very different one, and one may suggest it's a bug or just a rarely used feature.
I would want to concentrate on the current approach: mark SYSCTL_NODES without handlers as MPSAFE, nad masrk SYSCTL_NODES and SYSCT_PROCS with handlers that are not marked as MPSAFE now as NEEDGIANT and continue the work pushing the Giant off the sysctl. Fixing semantics of SYSCTL_NODE can be done later and has nothing to do with the MPSAFE/NEEDGIANT work.

Feb 15 2020, 11:39 AM

Feb 14 2020

kaktus committed rS357921: sysctl(9): properly use xor in ENFORCE_FLAGS macro.
sysctl(9): properly use xor in ENFORCE_FLAGS macro
Feb 14 2020, 4:57 PM
kaktus closed D23678: sysctl(9): properly use xor in ENFORCE_FLAGS macro.
Feb 14 2020, 4:57 PM
kaktus added a comment to D23675: The SYSCTL_NODE / MPSAFE / NEEDGIANT saga.

For documentation only, because committing this breaks the other patches and this review was created for brainstorming, but the whole discussion moved to IRC.

Feb 14 2020, 4:47 PM
kaktus added a comment to D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Marking them as NEEDGIANT is default to document the current state - all handlers not marked as MPSAFE are implicitly run under Giant. The new flag makes that a bit more explicit and allows for reviews like this to actually assess if that's really needed.
I'll take a look if we have any precedent on how to deal with sysctls operating on devices that can disappear. All other can probably by marked as MPSAFE, I'll update the patch.

Feb 14 2020, 12:14 PM
kaktus updated the summary of D23678: sysctl(9): properly use xor in ENFORCE_FLAGS macro.
Feb 14 2020, 12:47 AM
kaktus created D23678: sysctl(9): properly use xor in ENFORCE_FLAGS macro.
Feb 14 2020, 12:45 AM

Feb 13 2020

kaktus updated the summary of D23675: The SYSCTL_NODE / MPSAFE / NEEDGIANT saga.
Feb 13 2020, 10:33 PM
kaktus created D23675: The SYSCTL_NODE / MPSAFE / NEEDGIANT saga.
Feb 13 2020, 10:26 PM
kaktus added a comment to D23632: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

SYSCTL_*_NODE is MPSAFE if the handler is NULL (what is true for most of them) or if the handler takes care of locking internally.

Feb 13 2020, 5:00 PM
kaktus updated the diff for D23632: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Mark the nodes as MPSAFE.

Feb 13 2020, 4:50 PM
kaktus updated the diff for D23625: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Mark the nodes as MPSAFE.

Feb 13 2020, 4:48 PM
kaktus updated the diff for D23640: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

These nodes are MPSAFE.

Feb 13 2020, 4:47 PM
kaktus added a comment to D23640: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

Because they weren't marked as MPSAFE before :-) but after checking I think we can assume they are MPSAFE.

Feb 13 2020, 4:46 PM
kaktus added a comment to D23630: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).

That is exactly the reason: sysctl's that weren't before marked as MPSAFE are marked as NEEDGIANT, but if you're happy with current locking (or lack of it if unneeded) I can mark them as MPSAFE.

Feb 13 2020, 4:39 PM

Feb 11 2020

kaktus created D23640: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 11 2020, 9:16 PM
kaktus created D23639: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 11 2020, 9:15 PM
kaktus created D23638: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 11 2020, 9:14 PM
kaktus created D23637: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).
Feb 11 2020, 9:13 PM