- User Since
- Mar 24 2015, 9:11 PM (252 w, 1 d)
Fri, Jan 17
OK, I'll cut it into smaller batches.
Thu, Jan 16
Oops! Include proper diff.
Mark few more nodes.
Don't mark sysctl's that are already MPSAFE as NEEDGIANT.
Create macro to add MPSAFE flag for SYSCTL_NODEs that are not marked as NEEDGIANT instead of correcting every single entry.
Wed, Jan 15
Because the write path in sysctl_handle_string() and sysctl_handle_opaque() isn't locked yet?
Mark everything that was left since the last revision.
Sun, Jan 12
Mark all SYSCTL_NODEs using custom handler and not already marked as MPSAFE as CTLFLAG_NEEDGIANT.
Mark all SYSCTL_NODEs with NULL handler as MPSAFE.
Fri, Jan 10
Yes, many of the sysctls can be trivially be made / already are but aren't marked as MPSAFE but this was mostly sed + vim macros + a bit of manual fixes to add the flag where MPSAFE isn't set (yet).
The question is: should fixing this be done in this (already huge) diff or as a separate work later.
Thu, Jan 9
I'm not going to die for a name, but! we still have D_NEEDGIANT and the name still describe what is being done in this case.
Fix few typos and be more consistent on style(9).
Wed, Jan 8
lgtm, at least from the vmstat -m perspective
Mon, Jan 6
Sun, Jan 5
Thu, Jan 2
Wed, Jan 1
Update diff to use CTLFLAG_SKIP instead of completely removing KERN_DUMMY.
Tue, Dec 31
No problems, no. I understand that it was introduced as a combat for 3rd party binaries that hardcoded 1.31 as the oid, but the value 0 isn't helpful either.
How about CTLFLAG_SKIP so it wouldn't show up in sysctl(8) list?
Mon, Dec 30
Make the comment style(9) friendly.
Check if the flags provided are supported, otherwise return EINVAL.
Sun, Dec 29
There are no flags defined for now and kern_copy_file_range explicitly checks for flags != 0.
But if it's a problem, I can add a local flag variable and set it to 0 because this is what we support for now anyway.
% file 12.1/bin/df 12.1/bin/df: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.1, FreeBSD-style, stripped
Remove the now unneeded include of libc_private.h too.
Oct 1 2019
But there is also dma, sendmail and parts of kerberos… :-)
Wouldn't /usr/libexec be a better place for it, like for many other such daemons (like fingerd etc…)?
Sep 30 2019
Sep 27 2019
Sep 26 2019
sort it alphabetically, actually
Sep 19 2019
rewrite the return path
Sep 18 2019
don't return too early
Style and s/Int/Sizet/ where appropriate.
Address @kib comments.
Add space after comma.
Sep 17 2019
Use constants defined in D21693.
Sep 2 2019
add a missing file
Aug 27 2019
Address @kib's comments.
Update to r351542 and bump __FreeBSD_version again.
Aug 26 2019
Add a lightweight compat layer in libc.
Aug 25 2019
Check for ENOSYS.
Split the function for one that do the actual work and teach sys___sysctlbyname and freebsd32___sysctlbyname to call it properly.
Aug 21 2019
Update diff to r351302 and address some comments.
Mar 17 2019
I confirm that it works.
Mar 16 2019
% cat /etc/rc.conf clear_tmp_enable="YES" syslogd_flags="-ss" sendmail_enable="NONE" hostname="devel2" ifconfig_vtnet0="DHCP" sshd_enable="YES" ntpd_enable="YES" dumpdev="AUTO" zfs_enable="YES"
This breaks ifconfig_DEFAULT="DHCP" somehow. It works with either SYNCDHCP or this commit reverted.
Sep 25 2018
Update diff with minor fixes.
Sep 22 2018
Dec 23 2017
Man: start a sentence from new line.
Add CAVEATS section to the man page to point out the rounding issue with too short buffers.