Page MenuHomeFreeBSD
Feed Advanced Search

Oct 1 2019

kaktus added a comment to D21724: Move simple_httpd out of picobsd, add HTTPD option.

But there is also dma, sendmail and parts of kerberos… :-)

Oct 1 2019, 5:03 PM
kaktus added a comment to D21724: Move simple_httpd out of picobsd, add HTTPD option.

Wouldn't /usr/libexec be a better place for it, like for many other such daemons (like fingerd etc…)?

Oct 1 2019, 4:43 PM

Sep 30 2019

kaktus committed rS352914: linux_renameat2: don't add extra \n on error..
linux_renameat2: don't add extra \n on error.
Sep 30 2019, 7:05 PM
kaktus closed D21852: linux_renameat2: don't add extra \n on error.
Sep 30 2019, 7:05 PM
kaktus closed D21706: libsysdecode: decode PROT_MAX allocations.
Sep 30 2019, 7:03 PM
kaktus committed rS352913: libsysdecode: decode PROT_MAX flags.
libsysdecode: decode PROT_MAX flags
Sep 30 2019, 7:03 PM
kaktus created D21852: linux_renameat2: don't add extra \n on error.
Sep 30 2019, 3:39 PM

Sep 27 2019

kaktus closed D21811: Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:19 AM
kaktus committed rS352791: Add myself (kaktus) as a src commiter..
Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:19 AM
kaktus committed rD53439: Add myself (kaktus) as a src commiter.
Add myself (kaktus) as a src commiter
Sep 27 2019, 10:17 AM
kaktus closed D21810: Add myself (kaktus) as a src commiter.
Sep 27 2019, 10:17 AM

Sep 26 2019

kaktus updated the summary of D21706: libsysdecode: decode PROT_MAX allocations.
Sep 26 2019, 8:38 PM
kaktus retitled D21706: libsysdecode: decode PROT_MAX allocations from truss and ktrace should decode PROT_MAX allocations to libsysdecode: decode PROT_MAX allocations.
Sep 26 2019, 8:33 PM
kaktus updated the diff for D21811: Add myself (kaktus) as a src commiter.

sort it alphabetically, actually

Sep 26 2019, 8:22 PM
kaktus retitled D21811: Add myself (kaktus) as a src commiter from add myself to src/ to Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:12 PM
kaktus retitled D21810: Add myself (kaktus) as a src commiter from add myself to doc/ to Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:12 PM
kaktus created D21811: Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:02 PM
kaktus created D21810: Add myself (kaktus) as a src commiter.
Sep 26 2019, 8:00 PM
lwhsu renamed kaktus from pawel.biernacki-gmail.com to kaktus.
Sep 26 2019, 6:39 PM

Sep 19 2019

kaktus created D21715: libntp: build with closefrom.
Sep 19 2019, 2:01 PM
kaktus updated the diff for D21706: libsysdecode: decode PROT_MAX allocations.

rewrite the return path

Sep 19 2019, 10:25 AM

Sep 18 2019

kaktus updated the summary of D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 9:43 PM
kaktus added inline comments to D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 9:40 PM
kaktus updated the diff for D21706: libsysdecode: decode PROT_MAX allocations.

don't return too early

Sep 18 2019, 9:39 PM
kaktus created D21706: libsysdecode: decode PROT_MAX allocations.
Sep 18 2019, 7:12 PM
kaktus updated the diff for D21688: make truss decode sysctl names.

Style and s/Int/Sizet/ where appropriate.

Sep 18 2019, 11:25 AM
kaktus updated the diff for D21688: make truss decode sysctl names.

Address @kib comments.

Sep 18 2019, 8:34 AM
kaktus updated the diff for D21693: sysctl: use names instead of magic numbers.

Add space after comma.

Sep 18 2019, 8:30 AM

Sep 17 2019

kaktus added inline comments to D21688: make truss decode sysctl names.
Sep 17 2019, 11:00 PM
kaktus updated the summary of D21688: make truss decode sysctl names.
Sep 17 2019, 11:00 PM
kaktus updated the diff for D21688: make truss decode sysctl names.

Use constants defined in D21693.

Sep 17 2019, 10:57 PM
kaktus created D21693: sysctl: use names instead of magic numbers.
Sep 17 2019, 10:55 PM
kaktus created D21688: make truss decode sysctl names.
Sep 17 2019, 1:56 PM

Sep 2 2019

kaktus updated the diff for D17282: new syscall: __sysctlbyname.

add a missing file

Sep 2 2019, 1:52 PM

Aug 27 2019

kaktus created D21445: library should not modify global process state by calling sigaction(2).
Aug 27 2019, 10:32 PM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Aug 27 2019, 6:39 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Address @kib's comments.

Aug 27 2019, 6:39 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Update to r351542 and bump __FreeBSD_version again.

Aug 27 2019, 9:04 AM

Aug 26 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Add a lightweight compat layer in libc.

Aug 26 2019, 11:17 AM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Aug 26 2019, 9:06 AM

Aug 25 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Check for ENOSYS.

Aug 25 2019, 11:19 PM
kaktus added a comment to D17282: new syscall: __sysctlbyname.

Split the function for one that do the actual work and teach sys___sysctlbyname and freebsd32___sysctlbyname to call it properly.

Aug 25 2019, 11:08 PM

Aug 21 2019

kaktus added a comment to D17282: new syscall: __sysctlbyname.

Update diff to r351302 and address some comments.

Aug 21 2019, 8:42 PM

Mar 17 2019

kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.

I confirm that it works.

Mar 17 2019, 1:10 AM

Mar 16 2019

kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.
% cat /etc/rc.conf
clear_tmp_enable="YES"
syslogd_flags="-ss"
sendmail_enable="NONE"
hostname="devel2"
ifconfig_vtnet0="DHCP"
sshd_enable="YES"
ntpd_enable="YES"
dumpdev="AUTO"
zfs_enable="YES"
Mar 16 2019, 4:10 PM
kaktus added a comment to D19488: Enhance IPv6 autoconf startup scripts.

This breaks ifconfig_DEFAULT="DHCP" somehow. It works with either SYNCDHCP or this commit reverted.

Mar 16 2019, 1:27 PM

Sep 25 2018

kaktus updated the diff for D17282: new syscall: __sysctlbyname.

Update diff with minor fixes.

Sep 25 2018, 1:43 PM
kaktus added inline comments to D17282: new syscall: __sysctlbyname.
Sep 25 2018, 1:41 PM

Sep 22 2018

kaktus updated the diff for D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:52 AM
kaktus created D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:43 AM

Dec 23 2017

kaktus updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Man: start a sentence from new line.

Dec 23 2017, 7:15 PM · tests
kaktus updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Add CAVEATS section to the man page to point out the rounding issue with too short buffers.

Dec 23 2017, 6:09 PM · tests
kaktus added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#284349, @kib wrote:

In one branch of the snprintf() use, we add divisor / 2 and remainder * 10, not remainder. Does this case need to be handled differently ?

Dec 23 2017, 6:07 PM · tests

Dec 22 2017

kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:37 PM · tests
kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:30 PM · tests
kaktus updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:08 PM · tests

Dec 21 2017

kaktus added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Dec 21 2017, 10:07 PM · tests
kaktus updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Address @cem comments about style(9).

Dec 21 2017, 10:06 PM · tests
kaktus added a reviewer for D13578: humanize_number(3): fix edge case for rounding 999.5+: robak.
Dec 21 2017, 9:39 PM · tests
kaktus created D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 21 2017, 9:30 PM · tests

Dec 1 2017

kaktus added a comment to D13228: vmstat: fix style(9) violations and bump WARNS.

I'm fine with it. I've one question about what is the correct way of sorting local variables? style(9) use two different versions (or I'm reading it wrong):

int
main(int argc, char *argv[])
{
        char *ep;
        long num;
        int ch;
Dec 1 2017, 6:32 PM

Nov 29 2017

kaktus updated the summary of D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 29 2017, 5:45 PM
kaktus updated the diff for D13228: vmstat: fix style(9) violations and bump WARNS.

Address @kib comments. Also more and more style(9) cleanup like moving variables from body to top of the functions, removing unneeded empty lines, PRIu64 changed to %ju with uintmax_t cast, sorting, etc...

Nov 29 2017, 4:21 PM
kaktus added inline comments to D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 29 2017, 4:18 PM

Nov 24 2017

kaktus created D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 24 2017, 4:08 PM

Nov 23 2017

kaktus added a comment to D13199: vmstat: use 64-bit counters from struct vmtotal.

vmstat(1) is full of style(9) violations, mostly related to libxo integration. I'd like to clean this in a separate patch.

Nov 23 2017, 4:36 PM
kaktus updated the diff for D13199: vmstat: use 64-bit counters from struct vmtotal.

Move uintmax_t cast to vmstat_pgtok macro.

Nov 23 2017, 4:30 PM
kaktus updated the diff for D13199: vmstat: use 64-bit counters from struct vmtotal.

Change u_int64_t to uint64_t in prthuman() and all invocations.

Nov 23 2017, 12:56 PM

Nov 22 2017

kaktus updated the summary of D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 11:25 PM
kaktus added inline comments to D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 10:47 PM
kaktus created D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 10:46 PM

Nov 21 2017

kaktus updated the summary of D13105: systat: use and correctly display 64bit counters.
Nov 21 2017, 11:43 AM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

s/divider/divisor/

Nov 21 2017, 10:38 AM
kaktus updated the summary of D13105: systat: use and correctly display 64bit counters.
Nov 21 2017, 10:33 AM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

Rename real_putuint64() to do_putuint64(), style(9) fixes.

Nov 21 2017, 10:33 AM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

No need to use 64 bit arithmetics for namei cache.

Nov 21 2017, 2:36 AM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

Use correctly generated diff.

Nov 21 2017, 12:36 AM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

Split printing integer values to putint() and putuint64() functions, calling the actual implementation with parameter selecting using SI or IEC divisor. Update all memory related values to use putuint64().

Nov 21 2017, 12:33 AM

Nov 17 2017

kaktus added a comment to D13105: systat: use and correctly display 64bit counters.
In D13105#273075, @kib wrote:
In D13105#272897, @pawel.biernacki-gmail.com wrote:

Address @kib comments:

  • Drop 1000 as a divider and stick to expected 1024.

So we have two uses of putint(). One is for (possibly very large) VM counters, and others for (usually not too large) event counts e.g. syscall/intr and so on.
Should the new function used only for 'large' counters, leaving old display algorithm around for slow counters ? This question jibes with the note that changed function should be called putuint64.

Nov 17 2017, 6:01 PM

Nov 16 2017

kaktus added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 16 2017, 10:17 PM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.

Address @kib comments:

Nov 16 2017, 10:16 PM

Nov 15 2017

kaktus added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 7:19 PM
kaktus added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 7:18 PM
kaktus updated the diff for D13105: systat: use and correctly display 64bit counters.
  • Update with long diff.
  • Use correct formatting for uint64_t in snprintf.
Nov 15 2017, 7:16 PM
kaktus added a comment to D13105: systat: use and correctly display 64bit counters.

Sorry, uploaded the short patch. Will upload long one with fixes.

Nov 15 2017, 5:06 PM
kaktus created D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 4:18 PM

Nov 14 2017

kaktus updated the diff for D13018: vmtotal: extend counters to match reality.

Fix the alignment issue by introducing spare filed of 3x16 bit ints.

Nov 14 2017, 8:23 PM
kaktus added a comment to D13018: vmtotal: extend counters to match reality.

Reordering didn't really helped. There is 5 16-bit fields that seems to be aligned on amd64 leaving 3x16bit hole which is only 1x16bit on i386.
Any ideas how to fix it? Enforce struct alignment to 8 bytes? Add an extra 32bit field as a spare?

Nov 14 2017, 7:53 PM
kaktus updated the diff for D13018: vmtotal: extend counters to match reality.

Address the style(9) comments. Also there is no need to call sysctl_handle_opaque in the last return as all we do now is returning fully populated struct. SYSCTL_OUT is enough.

Nov 14 2017, 2:59 PM
kaktus updated the diff for D13018: vmtotal: extend counters to match reality.

Address @kib comments:

Nov 14 2017, 1:10 PM

Nov 13 2017

kaktus added inline comments to D13018: vmtotal: extend counters to match reality.
Nov 13 2017, 11:55 PM
kaktus updated the diff for D13018: vmtotal: extend counters to match reality.
  • Extend all counters to uint64_t.
  • Introduce new P_OSREL_VMTOTAL64 define to mark extension of the struct vmtotal.
  • Provide sysctl(8) compatibility.
  • Bump FreeBSD_version.
Nov 13 2017, 11:53 PM

Nov 9 2017

kaktus added a comment to D13018: vmtotal: extend counters to match reality.

From what I see, sysctl(8) first calls sysctl(3) to get the size of vmtotal. As defined in

SYSCTL_PROC(_vm, VM_TOTAL, vmtotal, CTLTYPE_OPAQUE|CTLFLAG_RD|CTLFLAG_MPSAFE,
    0, sizeof(struct vmtotal), vmtotal, "S,vmtotal", 
    "System virtual memory statistics");

it'll return the size of the current vmtotal. It later compares it with the compile time size of struct vmtotal and report mismatch.

Nov 9 2017, 6:27 PM
kaktus created D13018: vmtotal: extend counters to match reality.
Nov 9 2017, 2:50 PM
kaktus added inline comments to D12985: bhyve: don't try to capsicumise after failed open.
Nov 9 2017, 2:33 PM · bhyve

Nov 7 2017

kaktus updated the summary of D12985: bhyve: don't try to capsicumise after failed open.
Nov 7 2017, 11:56 PM · bhyve
kaktus created D12985: bhyve: don't try to capsicumise after failed open.
Nov 7 2017, 11:22 PM · bhyve
kaktus added inline comments to D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 9:17 PM
kaktus updated the test plan for D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 3:51 PM
kaktus updated the diff for D12972: sysctl_kern_proc_umask: fast path when operating on curproc.

Address @mjg comments and remove extra FILEDESC locks.

Nov 7 2017, 3:51 PM