Page MenuHomeFreeBSD

sysctl(9): fix handling string tunables
ClosedPublic

Authored by kaktus on Apr 15 2020, 10:22 AM.

Details

Summary

rS357614 changed internals of handling string sysctls, and inadvertently broke setting string tunables. Take them into account.

Reported by: jhb, np
PR: 245463

Test Plan

kenv hw.cxgbe.config_file="kern_tls"
kldload if_cxgbe

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Apr 15 2020, 2:24 PM
sys/kern/kern_sysctl.c
1657 ↗(On Diff #70591)

While there, fix style.

if ((oidp->oid_kind & CTLFLAG_WR) == 0 && (oidp->oid_kind & CTLFLAG_TUN) == 0

In fact I would write this as

if ((oidp->oid_kind & (CTLFLAG_WR | CTLFLAG_TUN)) == 0
This revision was automatically updated to reflect the committed changes.