sysctl(9): fix handling string tunables
ClosedPublic
Actions

Authored by kaktus on Apr 15 2020, 10:22 AM.

Details

Reviewers

kib
jhb
np
erj
jeb
emaste
imp

Commits

rS359975: sysctl(9): fix handling string tunables.

Summary

rS357614 changed internals of handling string sysctls, and inadvertently broke setting string tunables. Take them into account.

Reported by: jhb, np
PR: 245463

Test Plan

kenv hw.cxgbe.config_file="kern_tls"
kldload if_cxgbe

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Apr 15 2020, 10:22 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 15 2020, 10:22 AM

Harbormaster completed remote builds in B30513: Diff 70591.Apr 15 2020, 10:22 AM

kaktus edited the summary of this revision. (Show Details)Apr 15 2020, 10:23 AM

kaktus edited the summary of this revision. (Show Details)Apr 15 2020, 10:48 AM

imp accepted this revision.Apr 15 2020, 2:24 PM

This revision is now accepted and ready to land.Apr 15 2020, 2:24 PM

kib added inline comments.Apr 15 2020, 3:29 PM

sys/kern/kern_sysctl.c
1657 ↗	(On Diff #70591)	While there, fix style. if ((oidp->oid_kind & CTLFLAG_WR) == 0 && (oidp->oid_kind & CTLFLAG_TUN) == 0 In fact I would write this as if ((oidp->oid_kind & (CTLFLAG_WR \| CTLFLAG_TUN)) == 0

kib accepted this revision.Apr 15 2020, 3:30 PM

jhb accepted this revision.Apr 15 2020, 3:56 PM

Closed by commit rS359975: sysctl(9): fix handling string tunables. (authored by kaktus). · Explain WhyApr 15 2020, 4:34 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS359975: sysctl(9): fix handling string tunables..

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_sysctl.c

11 lines

Diff 70607

View Options

head/sys/kern/kern_sysctl.c

sysctl(9): fix handling string tunablesClosedPublicActions