Differential D54289

ixl(4): Enable building driver on ARM64
ClosedPublic
Actions

Authored by kgalazka on Dec 18 2025, 4:33 PM.

Project Tags

None

Referenced Files

None

Subscribers

emaste

imp

Details

Reviewers

erj
kbowling
dch
andrew
manu

Commits

rGa3d472219c5a: ixl(4): Enable building driver on ARM64

Summary

For consistency with other drivers enable building ixl
on ARM64 target.

Please be advised that it is only compile tested.
Intel will continue to test Ethernet drivers only on x86-64
platforms, and is not going to provide support for issues,
which cannot be reproduced in such environment.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Suggested-by: Dave Cottlehuber <dch@FreeBSD.org>
Sponsored by: Intel Corporation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69407
Build 66290: arc lint + arc unit

Event Timeline

kgalazka created this revision.Dec 18 2025, 4:33 PM

Herald added a reviewer: andrew. · View Herald TranscriptDec 18 2025, 4:33 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

kgalazka requested review of this revision.Dec 18 2025, 4:33 PM

Harbormaster completed remote builds in B69374: Diff 168330.Dec 18 2025, 4:33 PM

Maybe start with enabling the module for arm64 ?
It's unlikely that anyone will test adding the driver to their kernel config if they didn't tested with the module before.
Also I don't see why anyone would want the driver in the kernel if a module exists.

This revision now requires changes to proceed.Dec 18 2025, 4:42 PM

Enable building the driver as a module.

Harbormaster completed remote builds in B69407: Diff 168457.Dec 19 2025, 6:23 PM

Approving as mentor, wait for @manu to re-review before commiting

Since the module will be built for all arch why not adding the config to sys/conf/files directly ? It's already present in files.amd64 and files.powerpc and now you're adding this to files.arm64, it doesn't make sense.

This revision now requires changes to proceed.Dec 20 2025, 11:14 AM

The module will build only on 64-bit arch (amd64 and powerpc64 was already there, this patch adds arm64). I don't think it was ever tested on 32-bits, and I don't have too many spare cycles to look into that.

In D54289#1241834, @kgalazka wrote:

The module will build only on 64-bit arch (amd64 and powerpc64 was already there, this patch adds arm64). I don't think it was ever tested on 32-bits, and I don't have too many spare cycles to look into that.

Ah yes indeed I've missed that.
Looks like we should have a files.64 for cases like this.

This revision is now accepted and ready to land.Dec 23 2025, 7:33 AM

I'd still be tempted to put it in files and just spike 32bit builds. Sure, you can put it in the config file and yhe error is delayed until you build, but that's ok imho. Lots of things in files that don't work evertwhere. No need for a files.64.

In D54289#1242003, @imp wrote:

I'd still be tempted to put it in files and just spike 32bit builds. Sure, you can put it in the config file and yhe error is delayed until you build, but that's ok imho. Lots of things in files that don't work evertwhere. No need for a files.64.

That's also fine with me.

Closed by commit rGa3d472219c5a: ixl(4): Enable building driver on ARM64. · Explain WhyJan 9 2026, 10:44 PM

This revision was automatically updated to reflect the committed changes.

kgalazka added a commit: rGa3d472219c5a: ixl(4): Enable building driver on ARM64.