Page MenuHomeFreeBSD
Differential D46295

add virtio file system device support
Needs ReviewPublic
Actions

Authored by emil_etsalapatis.com on Aug 14 2024, 3:53 PM.
Tags
None
Referenced Files
F144386980: D46295.id156288.diff
Sun, Feb 8, 4:32 AM
F144383548: D46295.id142082.diff
Sun, Feb 8, 4:13 AM
F144323849: D46295.id149165.diff
Sat, Feb 7, 8:36 PM
F144315069: D46295.id156285.diff
Sat, Feb 7, 7:32 PM
Unknown Object (File)
Tue, Feb 3, 2:30 AM
Unknown Object (File)
Tue, Feb 3, 2:10 AM
Unknown Object (File)
Tue, Feb 3, 2:08 AM
Unknown Object (File)
Mon, Feb 2, 10:37 PM
View All Files
Subscribers
crest_freebsd_rlwinm.de
imp
lwhsu

Details

Reviewers
asomers
editor_callfortesting.org
Summary

Supporting the virtiofs requires a device driver for the virtio fs device. Add the virtio file system driver before introducing the file system itself.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 64544
Build 61428: arc lint + arc unit

Event Timeline

emil_etsalapatis.com created this revision.Aug 14 2024, 3:53 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 14 2024, 3:53 PM
emil_etsalapatis.com requested review of this revision.Aug 14 2024, 3:53 PM
Harbormaster completed remote builds in B59021: Diff 142082.Aug 14 2024, 3:53 PM
lwhsu added a subscriber: lwhsu.Aug 14 2024, 4:29 PM
lwhsu added inline comments.
sys/dev/virtio/fs/virtio_fs.h
5

We need a copyright holder here, and may drop "all rights reserved."

crest_freebsd_rlwinm.de added a subscriber: crest_freebsd_rlwinm.de.Aug 15 2024, 6:39 PM
asomers requested changes to this revision.Aug 21 2024, 7:30 PM
asomers added inline comments.
sys/dev/virtio/fs/virtio_fs.c
59

This line is redundant with the one in virtio_fs.h

297
551–552
sys/dev/virtio/fs/virtio_fs_internal.h
11

If these messages are just for debugging purposes, shouldn't there be a way to turn them off?

This revision now requires changes to proceed.Aug 21 2024, 7:30 PM
emil_etsalapatis.com updated this revision to Diff 149165.Jan 13 2025, 1:16 AM

address reviewer feedback

Harbormaster completed remote builds in B61687: Diff 149165.Jan 13 2025, 1:16 AM
emil_etsalapatis.com updated this revision to Diff 156285.May 30 2025, 2:26 AM
  • sys/dev/virtio/fs: drain virtqueues one at a time
Harbormaster completed remote builds in B64541: Diff 156285.May 30 2025, 2:26 AM
lwhsu added inline comments.May 30 2025, 2:51 AM
sys/dev/virtio/fs/virtio_fs.h
3

BSD-2-Clause is fine, no need -FreeBSD suffix

emil_etsalapatis.com updated this revision to Diff 156288.May 30 2025, 4:34 AM
  • sys/dev/virtio/fs: use regular BSD-2-Clause license
Harbormaster completed remote builds in B64544: Diff 156288.May 30 2025, 4:34 AM
emil_etsalapatis.com updated this revision to Diff 170959.Sun, Feb 1, 11:56 PM

bug fixes and style updates

Harbormaster completed remote builds in B70328: Diff 170959.Sun, Feb 1, 11:56 PM
emil_etsalapatis.com updated this revision to Diff 170963.Mon, Feb 2, 12:04 AM

adjust SPDX License Identifier

Harbormaster completed remote builds in B70331: Diff 170963.Mon, Feb 2, 12:04 AM
emil_etsalapatis.com mentioned this in D55047: fuse: Do not unconditionally overwrite local vnode size with remote.Mon, Feb 2, 3:50 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
1 line
conf/
1 line
dev/
virtio/
fs/
44 lines
617 lines
50 lines
modules/
virtio/
2 lines
fs/
11 lines

Diff 156288

View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/dev/virtio/fs/virtio_fs.h

Loading...
View Options

sys/dev/virtio/fs/virtio_fs.c

Loading...
View Options

sys/dev/virtio/fs/virtio_fs_internal.h

Loading...
View Options

sys/modules/virtio/Makefile

Loading...
View Options

sys/modules/virtio/fs/Makefile

Loading...