Is umbctl needed in boot or single user mode? perhaps it's more suitable in /usr/sbin ?

If this is ported from NetBSD, we need the full VCS string.

"All rights reserved" is not necessary anymore.

We don't add VCS string in new files anymore.

Need full NetBSD VCS string.

To confirm: do you (they) mean to use the 3-clause BSD license?

We don't add VCS string anymore.

Full NetBSD VCS string.

To confirm: do you (they) mean to use the 3-clause BSD license?

To confirm: do you (they) mean to use the 3-clause BSD license?

Those blank lines are leftover from removing $FreeBSD$ and not needed anymore

I think it's possible to encounter situations where umb(4) will be needed early by the user, since it's a network interface and there is no dependency on anything from /usr. NFS over broadband network is an example, however unlikely it might be. In a broader picture, umbctl(8) is really an extension to ifconfig(8), which resides in /sbin itself.

Adista asked me to use this text explicitly for their part of the license terms.

Got it. Then we need to add all of them in the SPDX header, possibly it will be like: SPDX-License-Identifier: (BSD-2-Clause AND BSD-3-Clause)

You could still indent it if you want but that doesn't work well with sometimes narrow consoles and giant fonts.

We usually put what options are needed to build it into the kernel, and any sysctls that can be used to configure it. Lately a little about devmatch. u3g(4) is how I normally see it, vt(4) is the absolute best one I know of, and rtw89(4) for the most recent one with the devmatch example.

This section gets pulled into the hardware notes, so it needs to have the driver name and device type for searching. I've been writing a section for style.mdoc but it's maybe not ready yet. Bullet lists make a really nice subsections.

https://www.freebsd.org/releases/14.2R/hardware/#misc-network

We don't have this one.

What does original mean in this context?

I wrote this tool for NetBSD originally, under my own copyright, before applying some changes under contract on behalf of ADISTA SAS.
I can check how close the version submitted here is to the NetBSD one, it is possible that the changes applied are not sufficient to justify the additional copyright and license, but IANAL so I'd rather not touch it if there's any doubt.

In the FreeBSD manual we always put the explaination before the example, with a colon instead of a period.

I see. Just wondering, thanks.

If it goes in this way, it will render super ragged in the hardware notes with no description. Here's what we have so far for the HARDWARE section style guide: https://reviews.freebsd.org/D48343

On the command line, the syntax expects parameters to be passed as separate arguments, as per ifconfig(8).

I believe this is a remnant of the original import from OpenBSD; I am not fluent in the macros for manual pages myself.

To keep consistent with other wrappers.

The line

	IFQ_SET_MAXLEN(&ifp->if_snd, ifqmaxlen);
	ifp->if_snd.ifq_drv_maxlen = ifqmaxlen;

can be replaced by the wrapper function

	if_setsendqlen(ifp, ifqmaxlen);

Use wrapper function.

The interface may be moved to another vnet, so this unconditional vnet0 will make troubles. We should set curvnet to interface's vnet, aka ifp->if_vnet.

Ditto.

And this.

Ditto.