Page MenuHomeFreeBSD
Differential D37357

Add support for an array of hwresets
ClosedPublic
Actions

Authored by andrew on Nov 11 2022, 9:28 AM.
Tags
None
Referenced Files
F138027038: D37357.diff
Fri, Nov 28, 7:30 AM
F138012150: D37357.id114354.diff
Fri, Nov 28, 3:35 AM
Unknown Object (File)
Wed, Nov 26, 11:31 PM
Unknown Object (File)
Tue, Nov 25, 8:10 AM
Unknown Object (File)
Sun, Nov 23, 1:37 AM
Unknown Object (File)
Wed, Nov 19, 2:49 AM
Unknown Object (File)
Sun, Nov 16, 11:36 AM
Unknown Object (File)
Tue, Nov 11, 2:38 AM
View All Files
Subscribers
bz
imp
mmel

Details

Reviewers
manu
bz
mmel
Group Reviewers
ARM
arm64
Commits
rG5930ae92913b: Add support for an array of hwresets
rG969935b86b17: Add support for an array of hwresets
Summary

In some drivers we need to assert and deassert a group of hardware
resets in any order. To support this add a new hwreset_array that
manages all hwresets defined for a device.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48296
Build 45182: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 11 2022, 9:28 AM
Herald added a reviewer: manu. · View Herald TranscriptNov 11 2022, 9:28 AM
Herald added a subscriber: imp. · View Herald Transcript
andrew requested review of this revision.Nov 11 2022, 9:28 AM
Harbormaster completed remote builds in B48294: Diff 112918.Nov 11 2022, 9:28 AM
manu added inline comments.Nov 11 2022, 9:42 AM
sys/dev/extres/hwreset/hwreset_array.c
121

Wouldn't ENOMEM would be better ?

andrew added inline comments.Nov 11 2022, 9:49 AM
sys/dev/extres/hwreset/hwreset_array.c
121

It should be removed. I thought mallocarray could return NULL on overflow, but it calls panic.

manu accepted this revision.Nov 11 2022, 9:51 AM
manu added inline comments.
sys/dev/extres/hwreset/hwreset_array.c
121

Ok, good for me then.

This revision is now accepted and ready to land.Nov 11 2022, 9:51 AM
andrew updated this revision to Diff 112920.Nov 11 2022, 9:51 AM

Remove unneeded NULL check

This revision now requires review to proceed.Nov 11 2022, 9:51 AM
Harbormaster completed remote builds in B48296: Diff 112920.Nov 11 2022, 9:51 AM
manu accepted this revision.Nov 11 2022, 10:00 AM
This revision is now accepted and ready to land.Nov 11 2022, 10:00 AM
bz accepted this revision.Nov 11 2022, 3:22 PM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/extres/hwreset/hwreset_array.c
128

You don't need the { } and you could just for (; i >= 0; i--) probably?

mmel accepted this revision.Nov 14 2022, 6:26 AM
mmel added a subscriber: mmel.

LGTM

Closed by commit rG969935b86b17: Add support for an array of hwresets (authored by andrew). · Explain WhyDec 21 2022, 11:29 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG969935b86b17: Add support for an array of hwresets.
andrew added a commit: rG5930ae92913b: Add support for an array of hwresets.Jan 23 2023, 12:38 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
extres/
hwreset/
8 lines
139 lines

Diff 112920

View Options

sys/conf/files

Loading...
View Options

sys/dev/extres/hwreset/hwreset.h

Loading...
View Options

sys/dev/extres/hwreset/hwreset_array.c

Loading...