Committed in rS355024
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 23 2019
Revert half of the previous change. Only _value needs initialization based on _start, and _offset does not.
In D22470#492498, @jeff wrote:I am not going to object to you committing yours first and me rebasing on top of that.
I am not going to object to you committing yours first and me rebasing on top of that.
First pass, just looked at stuff related to item_ctor.
Address a problem of finding a match at the start when start!=0.
Ok, if the long double part is dropped, the tests succeed. So LGTM.
Thank you for rearranging those. Maybe textproc/igor can help you a bit with the proper alignment or check the FDP primer for examples.
Let me know if you need help.
You can commit this one, too.
You can commit this one. Thanks!
Good to go. Thanks!
Ah, can you un-indent the lines below the description tag to align like the other entries? Thanks!
Fix stack space comment.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241803 has done part of this
Do you think we could add all of these test cases to the tree somewhere? (Not integrated w/ ATF presumably as we wouldn't have a convenient way to build Linux binaries.)
Set NO_WRKSUBDIR
@jrm wrote:I guess you tested with autom4te installed. In a clean environment, the test will fail otherwise.
Yes, in an unclean environment, that's right. I was more concerned with the functional breakage rather than what particular dependencies those tests might require which I trusted you'd figure out yourself. :-)
In D22351#492317, @danfe wrote:@zeus_gnu.org.ua wrote:but for now, there is an issue with mu tests which should be solved first
it's better to wait it's been solved, before applying the diffTests should pass fine now after rP518222; @jrm please rebase your patch, and I believe it's good to go.
Add missing test dependency
@dch the patch works for me.
Removed PORTREVISION bump from devel/geany/Makefile, and improved dependency check to test for a spefic colour theme file as suggested.