devel/geany: Added new option to install additional themes (devel/geany-themes).
devel/geany-themes: Removed dependency on "geany" to avoid circular dependency, bumped PORTREVISION.
Details
Details
- Reviewers
madpilot - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP518310: Make geany-themes an optional dependency of geany.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks for the patch. I'll commit it later, only changing the RUN_DEPENDS line.
| devel/geany/Makefile | ||
|---|---|---|
| 49 ↗ | (On Diff #64752) | This is wrong in this case. The geany port installs a file in this directory itself (alt.conf, a color theme included in geany distribution), so the directory will be there if the port is already installed. I'll change this to THEMES_RUN_DEPENDS=${LOCALBASE}/share/geany/colorschemes/bespin.conf:devel/geany-themesreferencing a specific file installed by geany-themes. |
Comment Actions
I forgot, there is also no need to bump geany PORTREVISION, since you're only adding a non default option. No need to force rebuilding the package/reinstalling.
It would have been necessary if you had made the new option the default.
Comment Actions
Removed PORTREVISION bump from devel/geany/Makefile, and improved dependency check to test for a spefic colour theme file as suggested.