Page MenuHomeFreeBSD

devel/geany: Add option to install geany-themes (invert dependency from geany-themes)
ClosedPublic

Authored by james.wright_digital-chaos.com on Fri, Nov 22, 7:59 PM.

Details

Summary

devel/geany: Added new option to install additional themes (devel/geany-themes).
devel/geany-themes: Removed dependency on "geany" to avoid circular dependency, bumped PORTREVISION.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Changed devel/geany/Makefile to remove THEMES option from default options.

madpilot accepted this revision.Sat, Nov 23, 1:32 PM

Thanks for the patch. I'll commit it later, only changing the RUN_DEPENDS line.

devel/geany/Makefile
49 ↗(On Diff #64752)

This is wrong in this case. The geany port installs a file in this directory itself (alt.conf, a color theme included in geany distribution), so the directory will be there if the port is already installed.

I'll change this to

THEMES_RUN_DEPENDS=${LOCALBASE}/share/geany/colorschemes/bespin.conf:devel/geany-themes

referencing a specific file installed by geany-themes.

This revision is now accepted and ready to land.Sat, Nov 23, 1:32 PM

I forgot, there is also no need to bump geany PORTREVISION, since you're only adding a non default option. No need to force rebuilding the package/reinstalling.

It would have been necessary if you had made the new option the default.

Removed PORTREVISION bump from devel/geany/Makefile, and improved dependency check to test for a spefic colour theme file as suggested.

This revision now requires review to proceed.Sat, Nov 23, 3:02 PM
madpilot accepted this revision.Sat, Nov 23, 3:32 PM
This revision is now accepted and ready to land.Sat, Nov 23, 3:32 PM
This revision was automatically updated to reflect the committed changes.