Page MenuHomeFreeBSD

Reorder the entries of hardware commercial page and add ThinkPenguin
Needs ReviewPublic

Authored by carlavilla on Fri, Nov 22, 8:25 PM.

Details

Reviewers
bcr
Summary

Reorder the entries of hardware commercial page and add ThinkPenguin

PR: 204085

Test Plan

Compile the website

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

carlavilla created this revision.Fri, Nov 22, 8:25 PM
bcr added a comment.Sat, Nov 23, 7:27 PM

Thank you for rearranging those. Maybe textproc/igor can help you a bit with the proper alignment or check the FDP primer for examples.
Let me know if you need help.

share/xml/commercial.hardware.xml
137

Those overlong lines need to align below the href until the </a> is reached. Same below.

346

The indentation here seems to be done with a single space instead of a tab.

347

This needs to be directly after the > of the href, to not have an extra whitespace in there.

carlavilla updated this revision to Diff 65017.Thu, Nov 28, 6:41 PM

Correct the identation

bcr added a comment.Fri, Nov 29, 6:58 AM

Another round of edits needed, but we're getting there. Thanks!

share/xml/commercial.hardware.xml
15

This would produce a visible space. You can break it up like this:
.../single_board_computers.html">Single
<tab>Board Computer Systems</a> ...

19

Same here, where you can use
<a
<tab>href="..">rackmount
<tab (same level as above)>LCD ... (after the closing </a>), unindent one level again.

21

and here

89

and here as well.

91

Another instance.

bcr added a comment.Fri, Nov 29, 7:04 AM

A few instances where there are extra spaces, but those are easy to fix.

share/xml/commercial.hardware.xml
142

Extra space here where there should not be one, see below.

144

Another superfluous space, see more below.

323

Extra space here?

502

There must not be a space between > and "Servaris"

504

s/asily/Easily/

520

This sentence needs to start on the same line as <description>.
textproc/igor can check for these and other things.

527

Another space where there should not be one. It should be:
<a
<tab>href="mailto:infor@server-rack-online.com?subject=FreeBSD Site">info@server-rack-online.com</a>

Even if it overflows the line. In those instances, it is OK and textproc/igor ignores these and won't give you a warning then.

529

Same here.