Reorder the entries of hardware commercial page and add ThinkPenguin
PR: 204085
Details
Details
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Thank you for rearranging those. Maybe textproc/igor can help you a bit with the proper alignment or check the FDP primer for examples.
Let me know if you need help.
| share/xml/commercial.hardware.xml | ||
|---|---|---|
| 137 | Those overlong lines need to align below the href until the </a> is reached. Same below. | |
| 346 | The indentation here seems to be done with a single space instead of a tab. | |
| 347 | This needs to be directly after the > of the href, to not have an extra whitespace in there. | |
Comment Actions
Another round of edits needed, but we're getting there. Thanks!
| share/xml/commercial.hardware.xml | ||
|---|---|---|
| 15 | This would produce a visible space. You can break it up like this: | |
| 19 | Same here, where you can use | |
| 21 | and here | |
| 89 | and here as well. | |
| 91 | Another instance. | |
Comment Actions
A few instances where there are extra spaces, but those are easy to fix.
| share/xml/commercial.hardware.xml | ||
|---|---|---|
| 142 | Extra space here where there should not be one, see below. | |
| 144 | Another superfluous space, see more below. | |
| 323 | Extra space here? | |
| 502 | There must not be a space between > and "Servaris" | |
| 504 | s/asily/Easily/ | |
| 520 | This sentence needs to start on the same line as <description>. | |
| 527 | Another space where there should not be one. It should be: Even if it overflows the line. In those instances, it is OK and textproc/igor ignores these and won't give you a warning then. | |
| 529 | Same here. | |
Comment Actions
The ThinkPenguin entry looks good. I found some other issues along the way.
If you want, you can just create a diff for this new entry and we'll reformat the rest in a separate commit.
| share/xml/commercial.hardware.xml | ||
|---|---|---|
| 20 | The closing </description> tag must follow right after the sentence stop, even if it overflows the line limit. | |
| 35 | You could safe some space by pulling at least the href into the previous line and break the line before "target" or even after it (putting the "rel=..." into the next line). | |
| 46 | Stray comma, this needs to go right after "LEDS" in the previous line (if that overflows it, break "LEDS" into this line. | |
| 48 | The extra space before "FreeBSD" must not be there (and you can replace "FreeBSD 4.0" with &os; 4.0). | |
| 110 | You can pull that single "<a" up into the previous line. | |
| 111 | Are these tabs or spaces? Tabs would be better... | |
| 114 | Same here, move the "<a" up to the previous line. | |
| 119 | This "<a" can also move to the end of the previous line. | |
| 123 | Another instance of a single "<a" that can move into the previous line. Goes for the rest of the "<a" in this part, too. | |
| 150 | Another stray comma. They must not be alone by themselves, always connected to a word. | |
Comment Actions
Any updates on this? I think after make the changes commented above, it can be committed.