- Remove the build dependency on Emacs since the installed elisp file is simple and does not need to be byte compiled.
- Do not forget to add Phab URL when committing.
jrm on Nov 13 2019, 8:11 PM.Authored by
poudriere tetsport for 11/12 i386/amd64 look ok
Zeus does not have Phabricator account AFAIK, he's one of those old school maintainers. Is there a PR for this, or just this differential? The patch is quite noisy because it contains lots of unrelated and needless changes (formatting, whitespace, etc.) but I'll take a closer look into Emacs/Python stuff you've added and update the port.
I could have separated out the formatting changes, but it's mostly formatting change, which I don't think are needless.
Zeus is CCed on the PR and I linked to this review there, so hopefully he will find this.
It's mostly formatting changes, so I do not think it's so difficult to distinguish the updates, fixes and the formatting changes. I also do not think the formatting changes are needless. tobik@ has made some nice tools to standardize the formatting to give us consistency.
You will update the port? Why? You are not the maintainer and I spent hours debugging different issues to come up with these changes.
They are non-functional, pessimize readability, and just gratuitous (why reformat MASTER_SITES and PLIST_SUB, why move GNU_CONFIGURE and shuffle around and and collapse the options' blocks?).
I've been doing most technical work on the port (and committing to it, as can be seen per svn log), while Zeus is actually using it actively in production and is our liaison contact with upstream author. If you insist on committing what you propose yourself I won't object, but I still prefer to leave out any formatting changes out of the diff and concentrate specifically on version update, Emacs and Python options. Everything else with the port's Makefile is fine as is.
Thanks. See how much better and clear it is now? :-) I've pinged Zeus in Jabber, he should be able to review and provide his feedback soon.
Again, there's no need for that.
I added a patch based on Joseph's patch here in the PR. It only addresses the EMACS circular dependency issue and doesn't include the update to 3.8. I attached the patch there instead of here to avoid confusion. Maybe there's a good way to present an alternate patchset on the phab page, but I don't know how.
Anyway the patch there removes consolidates the EMACS option (which is only used for installing the mailutils-mh.el) under the MH option, thus simplifying the OPTIONS list. And it fixes the emacs<->mailutils circular dependency (works whether emacs is installed or not at build time). Joseph did the heavy lifting for that - I just tweaked it.
sorry for delay
there is no objection against the diff
but for now, there is an issue with mu tests which should be solved first
it's better to wait it's been solved, before applying the diff
Yes, in an unclean environment, that's right. I was more concerned with the functional breakage rather than what particular dependencies those tests might require which I trusted you'd figure out yourself. :-)
My tinderbox is currently a bit broken WRT running tests, I hope to look into this issue soonish.