Sorry for the delay. Approved!

Thanks for noticing this. It clearly was an oversight on my part!

In D22533#492663, @tcberner wrote:

Moin moin

Please use arc diff to create the diffs, or use patches with all context shown :)

Moin moin

Upload the correct diff file

Add a missing underscore.

recreated diff with just the missing pieces

... I need to recreate this. I had an ancient version

... and I head an ancient version of bsd-family-tree for some reasons

add 11.3

and the graph too

add freebsd...

Attempts to theorize on reduction of scope of this have failed, apparently we do in fact need to be backing this much up when calling the resolver.

If there are no complaints, I will commit this within 24 hours.

Sorry for the tardiness.

I just confirmed it still works on powerpc, nothing broke.

You found the bugs with the kyua tests, did you retest post-changes?

Steal from jeffr's D22470 & D22491:

• Match procedure signatures, s/uma_zctor/item_ctor/ etc.
• Incorporate cleanup on constructor failure.

Reorder operations to avoid reading the word past the end of the bitstring, and ignoring it.