Page MenuHomeFreeBSD

Allow opt-out of automatic ntpd leapfile checking/fetching
ClosedPublic

Authored by ian on Nov 20 2019, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 8:03 PM
Unknown Object (File)
Feb 23 2024, 8:03 PM
Unknown Object (File)
Feb 23 2024, 3:31 PM
Unknown Object (File)
Feb 23 2024, 3:16 PM
Unknown Object (File)
Feb 23 2024, 12:28 AM
Unknown Object (File)
Jan 11 2024, 11:05 PM
Unknown Object (File)
Dec 20 2023, 8:09 AM
Unknown Object (File)
Sep 18 2023, 10:52 PM
Subscribers

Details

Summary

When a system has no internet connection, or when it is configured to obtain ntpd leapfiles from some source other than the internet, or even when the sysadmin has decided for some reason to customize ntp.conf to eliminate use of the leapfile, the rc.d/ntpd script emits various error messages related to the file.

This change allows setting the rc var ntp_db_leapfile to NONE to disable all automatic processing related to that file in rc.d/ntpd.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy requested changes to this revision.Nov 24 2019, 2:07 AM

Sorry for the tardiness.

We should put ntp_db_leapfile="YES" in /etc/defaults/rc.conf for the sake of documentation. Otherwise looks good..

This revision now requires changes to proceed.Nov 24 2019, 2:07 AM
In D22461#492560, @cy wrote:

Sorry for the tardiness.

We should put ntp_db_leapfile="YES" in /etc/defaults/rc.conf for the sake of documentation. Otherwise looks good..

It's already in /etc/defaults/rc.conf:

ntp_db_leapfile="/var/db/ntpd.leap-seconds.list"

The change is to allow opting out by setting it to "NONE" instead of a path/filename.

Freebsd documentation for ntp is a thing that increasingly bugs me. I think we just take the docs from ntp verbatim when we import new versions, and maintaining our own deltas to those would just increase the pain of doing the imports. I wish there was some straightforward way to document freebsd-specific ntp stuff in a manpage (because I have the feeling few people actually read the handbook -- I never do.) But, all of that is outside the scope of this review.

This revision is now accepted and ready to land.Nov 24 2019, 6:31 PM