Page MenuHomeFreeBSD

[PowerPC] Fix floating point environment manipulation
ClosedPublic

Authored by bdragon on Nov 24 2019, 12:56 AM.

Details

Summary
  • Fix endianness problems in functions accessing and manipulating the floating point environment via fenv.h. (jhibbits wrote the original bits)
  • Fix bugs regarding synchronization requirements after writing SPEFSCR.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

You found the bugs with the kyua tests, did you retest post-changes?

lib/msun/powerpc/fenv.h
94–95 ↗(On Diff #64789)

I think these need line wrapped.

ugh, think that was the wrong diff. Moment.

Actually upload the *correct* diff this time

bdragon marked an inline comment as done.
This revision is now accepted and ready to land.Dec 12 2019, 4:47 PM